Repository navigation
Mount NFS, FTPS and \\server\share addresses - #35
Open
dalmasluca wants to merge 1 commit into
Open
dalmasluca wants to merge 1 commit into
dalmasluca wants to merge 1 commit into
Conversation
[Medium impact] The PR appears safe to merge; no new actionable issues were found. SummaryThe path bar accepts more network addresses and gives clearer guidance when an address cannot be mounted as written.
No new actionable issues found. Reviews (9) · Last reviewed commit: "Mount NFS, FTPS and \\server\share addre..." · Reviewed by Greptile |
dalmasluca
force-pushed
the
connect-to-server
branch
2 times, most recently
from
November 11, 2026 16:29
74eb74e to
ceb5594
Compare
dalmasluca
force-pushed
the
connect-to-server
branch
2 times, most recently
from
November 11, 2026 20:52
0c11013 to
0e9a57b
Compare
Contributor
|
Thanks for this, and for already splitting it down from the larger version. It still bundles a few separate things, though, and it conflicts with today's main, so here's what would make it mergeable:
Happy to look again once it's split. |
dalmasluca
force-pushed
the
connect-to-server
branch
from
November 18, 2026 15:44
f05200d to
7b02a3f
Compare
Author
|
Thanks! Split as you asked:
|
The path bar now also takes nfs://, ftps:// and Windows \\server\share paths, and the ssh://, cifs://, webdav:// and webdavs:// spellings of the schemes it already mounts. An NFS address without its export, or an address with a password in it, says what to change instead of failing in GVfs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
dhh
force-pushed
the
connect-to-server
branch
from
November 18, 2026 16:29
7b02a3f to
06b9593
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path bar mounts more of the addresses people paste from elsewhere:
nfs://host/exportandftps://host/, which GVfs already mounts.\\server\share\folder, assmb://server/share/folder.ssh://,cifs://,webdav://andwebdavs://, as thesftp://,smb://,dav://anddavs://they stand for.An NFS address without its export (
nfs://nas) says to add one, since there's nothing to pick from, and an address with a password in it says to leave the password out and give it when asked to sign in. A Windows host on its own (smb://nas,\\nas) goes through unchanged, for #145 to list its shared folders.🤖 Generated with Claude Code