Skip to content

Mount NFS, FTPS and \\server\share addresses - #35

Open
dalmasluca wants to merge 1 commit into
omacom:mainfrom
dalmasluca:connect-to-server
Open

dalmasluca wants to merge 1 commit into
omacom:mainfrom
dalmasluca:connect-to-server

Conversation

@dalmasluca

@dalmasluca dalmasluca commented Nov 11, 2026 •

Copy link
Copy Markdown

The path bar mounts more of the addresses people paste from elsewhere:

  • nfs://host/export and ftps://host/, which GVfs already mounts.
  • A Windows path, \\server\share\folder, as smb://server/share/folder.
  • ssh://, cifs://, webdav:// and webdavs://, as the sftp://, smb://, dav:// and davs:// they stand for.

An NFS address without its export (nfs://nas) says to add one, since there's nothing to pick from, and an address with a password in it says to leave the password out and give it when asked to sign in. A Windows host on its own (smb://nas, \\nas) goes through unchanged, for #145 to list its shared folders.

🤖 Generated with Claude Code

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no new actionable issues were found.

Summary

The path bar accepts more network addresses and gives clearer guidance when an address cannot be mounted as written.

  • Folio mounts more kinds of pasted server addresses.
  • Incomplete NFS and password-bearing addresses get a clear message.

No new actionable issues found.

Reviews (9) · Last reviewed commit: "Mount NFS, FTPS and \\server\share addre..." · Reviewed by Greptile

Comment thread src/places.cpp Resolved
Comment thread src/places.cpp Resolved
Comment thread src/places.cpp Resolved
Comment thread src/ConnectDialog.qml Resolved
Comment thread src/Sidebar.qml Resolved
@dalmasluca
dalmasluca force-pushed the connect-to-server branch 2 times, most recently from 74eb74e to ceb5594 Compare November 11, 2026 16:29
Comment thread src/backend.cpp Resolved
@dalmasluca
dalmasluca force-pushed the connect-to-server branch 2 times, most recently from 0c11013 to 0e9a57b Compare November 11, 2026 20:52
@dalmasluca dalmasluca changed the title Connect to SMB, NFS and other servers from the window Mount NFS, FTPS and \\server\share addresses, and sign in with a domain, as a guest or with the keyring Nov 11, 2026
@omarchybot omarchybot added the enhancement New feature or request label Nov 15, 2026
@dhh

dhh commented Nov 18, 2026 •

Copy link
Copy Markdown
Contributor

Thanks for this, and for already splitting it down from the larger version. It still bundles a few separate things, though, and it conflicts with today's main, so here's what would make it mergeable:

  1. Split it in two. One PR for the addresses (nfs://, ftps://, \\server\share paths and the ssh:///cifs:///webdav:// aliases), and one for signing in (the domain field, Connect as Guest, the keyring checkbox). Each is easy to review and decide on alone.
  2. Drop the smb://nas/ refusal. List a Windows host's shared folders to pick from #145 (fixing SMB: Can't Browse a Host for Shared Folders List #131) goes the other way: a bare SMB host lists its shared folders to pick from, so "Add the shared folder" would get in its way. Rebase onto main once List a Windows host's shared folders to pick from #145 is settled.
  3. Screenshots of the sign-in dialog before and after, since it changes what people see.
  4. Keep the PR body to what changed and why; no Testing section.

Happy to look again once it's split.

@dalmasluca dalmasluca changed the title Mount NFS, FTPS and \\server\share addresses, and sign in with a domain, as a guest or with the keyring Mount NFS, FTPS and \\server\share addresses Nov 18, 2026
@dalmasluca

Copy link
Copy Markdown
Author

Thanks! Split as you asked:

The path bar now also takes nfs://, ftps:// and Windows \\server\share
paths, and the ssh://, cifs://, webdav:// and webdavs:// spellings of
the schemes it already mounts. An NFS address without its export, or an
address with a password in it, says what to change instead of failing
in GVfs.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@dhh
dhh force-pushed the connect-to-server branch from 7b02a3f to 06b9593 Compare November 18, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants