Repository navigation
Conversation
[Medium impact] This PR appears safe to merge; no actionable issue remains from this review. SummaryThis PR makes the sidebar and top bar quieter.
No new actionable issues were found. The added sidebar test covers Delete on views and both ends of the pinned section. Tests and visual checks were not run during this review. Reviews (10) · Last reviewed commit: "Edit the path with a click on the empty ..." · Reviewed by Greptile |
thisisgm
force-pushed
the
calmer-chrome
branch
2 times, most recently
from
November 11, 2026 11:25
46958e9 to
41bc977
Compare
thisisgm
force-pushed
the
calmer-chrome
branch
3 times, most recently
from
November 11, 2026 15:09
00b1619 to
8158498
Compare
thisisgm
force-pushed
the
calmer-chrome
branch
from
November 11, 2026 15:45
8158498 to
713f33b
Compare
thisisgm
force-pushed
the
calmer-chrome
branch
2 times, most recently
from
November 11, 2026 19:16
ed49b7c to
53b7d99
Compare
A path wider than its bar was cut through the middle of a crumb. Crumbs that do not fit now fold whole into a leading ellipsis that goes to the deepest folded folder and names the folded path in a tooltip; only a lone current folder elides. Mirrored, the ellipsis leads from the right.
The HOME heading was the only mouse route home and looked like the inert labels. Home is now the first row of the first section, with its glyph, taking drops like any folder row; Recents and Trash end that section in place of a Views heading.
The sidebar row for where you are stayed accent-lit while the files had the keyboard, so two accent things competed. It is grey until the sidebar takes the keyboard, then accent as before.
An on button sat on an accent plate, a second accent beside the folder's own. The details button now draws off in the secondary ink, and on in whichever of foreground and brightForeground stands out more; no plate.
Only Ctrl+L and a click on the current folder made the path editable. A click beside the crumbs now opens the field too, and a double click there keeps the whole path selected; the other crumbs and the ellipsis keep their clicks.
thisisgm
force-pushed
the
calmer-chrome
branch
from
November 11, 2026 19:46
53b7d99 to
bd2100e
Compare
Contributor
|
Thanks @thisisgm. The chrome this was written against has changed a lot, so I'm closing it:
Folding a long path into a leading |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A tidier sidebar and top bar: one route home, one accent at a time, and a path that never cuts a folder in half. One commit per change; each says what was wrong and what it does now. The suite passes.
The sidebar
The top bar
…that goes to the deepest folded folder and names the folded path in a tooltip. It hid the leading folders with nothing to say so. Only a lone current folder elides.…keep their clicks.Screenshots
Before on the left, after on the right, osaka-jade at 1100x700, on the current main.
Home heads the sidebar as a row of its own, and Recents and Trash end its section.
While the files hold the keys, the open place in the sidebar draws grey.
After Tab the sidebar holds the keys and the open place takes the accent.
The top bar buttons with details on.
Exports/web/final in a narrow pane: the leading folders fold into a leading "…".
One click right of the path opens the field.
Not pictured are the folded-path tooltip (it needs the pointer held on
…) and the double click.