Skip to content

Calmer chrome: Home row, quieter toggles and a folding path - #19

Closed
thisisgm wants to merge 5 commits into
omacom:mainfrom
thisisgm:calmer-chrome
Closed

thisisgm wants to merge 5 commits into
omacom:mainfrom
thisisgm:calmer-chrome

Conversation

@thisisgm

@thisisgm thisisgm commented Nov 11, 2026 •

Copy link
Copy Markdown
Contributor

A tidier sidebar and top bar: one route home, one accent at a time, and a path that never cuts a folder in half. One commit per change; each says what was wrong and what it does now. The suite passes.

The sidebar

  • Home is a row. The HOME heading was the only mouse route home and looked like the labels that do nothing. Home is now the first row, with its glyph, and takes drops like any folder row. Recents and Trash end that section, in place of a Views heading.
  • The open place is grey while the files have the keys. It stayed accent-lit, so two accent things competed. It turns accent once the sidebar takes the keys, as before.

The top bar

  • A long path folds whole folders into a leading … that goes to the deepest folded folder and names the folded path in a tooltip. It hid the leading folders with nothing to say so. Only a lone current folder elides.
  • A click on the empty part of the bar edits the path, as Ctrl+L and a click on the current folder already do; a double click keeps the whole path selected. The other folders and the … keep their clicks.
  • The details toggle says on by brightness. It sat on an accent plate when on, a second accent beside the folder's own. It now draws off in the secondary ink and on in whichever of foreground and bright foreground stands out more. The sort button keeps its plate while its menu is open.

Screenshots

Before on the left, after on the right, osaka-jade at 1100x700, on the current main.

Home heads the sidebar as a row of its own, and Recents and Trash end its section.

Home heads the sidebar as a row of its own, and Recents and Trash end its section.

While the files hold the keys, the open place in the sidebar draws grey.

While the files hold the keys, the open place in the sidebar draws grey.

After Tab the sidebar holds the keys and the open place takes the accent.

After Tab the sidebar holds the keys and the open place takes the accent.

The top bar buttons with details on.

The top bar buttons with details on.

Exports/web/final in a narrow pane: the leading folders fold into a leading "…".

Exports/web/final in a narrow pane: the leading folders fold into a leading "…".

One click right of the path opens the field.

One click right of the path opens the field.

Not pictured are the folded-path tooltip (it needs the pointer held on …) and the double click.

@greptile-apps

greptile-apps Bot commented Nov 11, 2026 •

Copy link
Copy Markdown

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] This PR appears safe to merge; no actionable issue remains from this review.

Summary

This PR makes the sidebar and top bar quieter.

  • Home, Recents, and Trash now sit together as sidebar destinations.
  • The active sidebar row changes brightness with keyboard focus.
  • Long paths fold leading folders behind a clickable ellipsis.
  • Clicking blank path-bar space now opens path editing.
  • The Details button shows its state through glyph brightness.

No new actionable issues were found. The added sidebar test covers Delete on views and both ends of the pinned section. Tests and visual checks were not run during this review.

Reviews (10) · Last reviewed commit: "Edit the path with a click on the empty ..." · Reviewed by Greptile

Comment thread src/places.cpp Resolved
Comment thread src/PathBar.qml Resolved
Comment thread src/PathBar.qml Resolved
@thisisgm
thisisgm force-pushed the calmer-chrome branch 2 times, most recently from 46958e9 to 41bc977 Compare November 11, 2026 11:25
@thisisgm
thisisgm force-pushed the calmer-chrome branch 3 times, most recently from 00b1619 to 8158498 Compare November 11, 2026 15:09
@thisisgm thisisgm changed the title Calmer chrome: standard places, Home row and compact path Calmer chrome: Home row, quieter toggles and a folding path Nov 11, 2026
@thisisgm
thisisgm force-pushed the calmer-chrome branch 2 times, most recently from ed49b7c to 53b7d99 Compare November 11, 2026 19:16
A path wider than its bar was cut through the middle of a crumb. Crumbs
that do not fit now fold whole into a leading ellipsis that goes to the
deepest folded folder and names the folded path in a tooltip; only a lone
current folder elides. Mirrored, the ellipsis leads from the right.
The HOME heading was the only mouse route home and looked like the inert
labels. Home is now the first row of the first section, with its glyph,
taking drops like any folder row; Recents and Trash end that section in
place of a Views heading.
The sidebar row for where you are stayed accent-lit while the files had
the keyboard, so two accent things competed. It is grey until the sidebar
takes the keyboard, then accent as before.
An on button sat on an accent plate, a second accent beside the folder's
own. The details button now draws off in the secondary ink, and on in
whichever of foreground and brightForeground stands out more; no plate.
Only Ctrl+L and a click on the current folder made the path editable. A
click beside the crumbs now opens the field too, and a double click
there keeps the whole path selected; the other crumbs and the ellipsis
keep their clicks.
@dhh

dhh commented Nov 18, 2026

Copy link
Copy Markdown
Contributor

Thanks @thisisgm. The chrome this was written against has changed a lot, so I'm closing it:

Folding a long path into a leading … (today the path bar scrolls to keep its end in view) and a click on the empty part of the bar editing the path still look worth having. Each is welcome as its own small PR on today's main.

@dhh dhh closed this Nov 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants