Repository navigation
Check out the full history in CI so the recorded checksum check runs - #113
Merged
Merged
Conversation
The suites job checked out omarchy-mac-pkgs at depth 1, so tools/release/test/omacom-lane skipped its check that real omarchy-mac-pkgs commits hash to the checksums makepkg recorded in omarchy-pkgs, and printed ok for it. Fetch the full history so the check runs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
scottjones
approved these changes
Nov 9, 2026
scottjones
left a comment
Collaborator
There was a problem hiding this comment.
Thanks, small and exactly right. It's a one-line change with no new permissions, secrets or actions. With full history the checksum check actually runs and passes, where before it skipped with "ok - # skip". The package resolution failure here comes from the live repo databases, not from this PR.
Contributor
Author
|
Note 🤖 Opus 5.5 replying on behalf of Victor. @scottjones, thank you for the review. Checking that it adds no permissions, secrets or actions is the right bar for a workflow change, and thanks for confirming in this PR's own run that the checksum check now runs and passes, and that the package resolution failure comes from the live databases. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
tools/release/test/omacom-lanechecks that four real omarchy-mac-pkgs commits hash to the checksums makepkg recorded for them in omacom/omarchy-pkgs. It needs those commits in the checkout, and skips without them. The suites job checks out omarchy-mac-pkgs atactions/checkout's default depth of 1, so CI always skips it and printsok. Main's latest run (42426384788, at 24430b4) shows:A change that broke how releases compute a git source's checksum would merge with green CI. AGENTS.md: "a skipped test, or a job that failed before reaching the tests, is not a pass."
Change
.github/workflows/tests.yml:fetch-depth: 0on the suites job's omarchy-mac-pkgs checkout, so the four commits are present and the check runs.tools/release/test/omacom-lane: the comment no longer says a shallow CI checkout lacks the history.The repository is about 2 MiB packed, so the full checkout costs little. A fixed depth would break again as
mainmoves on: the oldest of the four commits is already about 200 commits back.Scope and approval
CI only. No package behaviour changes, so
omarchy-mac/versionstays as it is, and nothing here needs cold-boot evidence or a manual change.The audit that found this also suggested installing
cryptsetupsotest/integration/factory-reset-luks-test.shruns its real LUKS2 volume case. It is not needed: the Arch image already has cryptsetup, and main's runs already printok - on a real LUKS2 volume with a token, ....Verification
The two runs below are the real test in a depth-1 clone of 24430b4 (what CI checks out today) and in a full clone of this branch.
Before: depth-1 clone of main, the checksum check skips and the suite exits 0.
After: full clone of this branch, the checksum check runs and passes.
actionlint .github/workflows/tests.yml: exit 0 on main and on this branch.bash tools/release/test/omacom-laneexits 0, with the skip line.ok - omarchy-mac-pkgs commits hash to the checksums makepkg recorded in omarchy-pkgs.not ok - the checksum of omarchy-mac-pkgs 5b2c815f007d is not the 00000000e396 makepkg recorded, while the depth-1 clone still exits 0 on the skip.Not checked
ok - omarchy-mac-pkgs commits hash to the checksums makepkg recorded in omarchy-pkgsunder "Tooling suites", where main prints the skip.ok, so a shallow checkout would hide the check again. Failing instead of skipping under CI would be a separate change.Prior PRs
#27 added this check and its skip for shallow checkouts. #13, #30 and #76 also edit
tests.yml; #30 addsfetch-depth: 2to the separate scope job, so the two do not conflict.Generated with Claude Opus 5.5 and GPT-6.1 Sol in T3 Code Nightly