Repository navigation
Port generic Voxtype, Brave Widevine and setup-failure fixes from quattro - #531
Merged
Merged
Conversation
omarchy-hw-vulkan reports a Vulkan runtime, not whether this voxtype build has a Vulkan backend. The aarch64 voxtype-bin package ships only the CPU and ONNX binaries, so on any aarch64 machine with a Vulkan driver setup ran `voxtype setup gpu --enable` and printed "Vulkan backend not installed" in the middle of an otherwise working install. Require the backend binary too. x86_64 voxtype-bin always ships /usr/lib/voxtype/voxtype-vulkan, so x86 installs still switch to the GPU backend as before. Ported from #483. Co-authored-by: Oliver Lukschander <oliver@lukschander.com>
The widevine package registers its CDM for Chromium and Firefox only. Brave looks for the CDM in its own install directory, finds nothing, and DRM sites (Netflix, Apple TV+, Spotify) fail with a blank player and no useful error. This hits machines where Widevine comes from that package, such as aarch64 ones, since no Widevine component is published for them. Link /opt/WidevineCdm/chromium into /opt/brave-bin and /opt/brave-origin-bin when Brave or Brave Origin is installed, and add a migration that repairs existing installs. Both do nothing when the widevine package is absent or the browser already has a CDM, so x86 installs, where Brave fetches its own, are unchanged. Ported from #474, extended to Brave Origin. Co-authored-by: Caleb Marshall <cjmrshl@pm.me>
With file logging, run_logged sends a failing leaf's output and its "Failed:" marker to the install log only, so the caller sees setup stop with an exit status and nothing else. A missing command (exit 127) was the case that made this hard to diagnose. Print the failed script, its exit status and the log path on stderr. Stdout logging mode already shows the failure marker and is unchanged, and successful steps stay quiet. Ported from #389 (the logging part). Co-authored-by: Scott Jones <scottajones@gmail.com>
This was referenced Sep 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket 63 of the Apple Silicon convergence plan. Ports three generic fixes that were merged on
quattrobut never reachedquattro-upstreamor omacom/omarchyquattro(found by the merged-work audit, #522). Each is its own commit so it can go upstream as is; upstreamquattrohas the same bugs in the same code.voxtype setup gpu --enablewhen the Vulkan runtime and/usr/lib/voxtype/voxtype-vulkanare both present. aarch64voxtype-binships no Vulkan backend, so any aarch64 machine with a Vulkan driver printed "Vulkan backend not installed" during setup. x86_64voxtype-binalways ships that binary, so x86 still gets the GPU backend./opt/WidevineCdm/chromium(from thewidevinepackage) into the browser's install directory, and a migration repairs existing installs. It does nothing without thewidevinepackage or when the browser already has a CDM, which is the x86 case. Brave Origin is new here; its/opt/brave-origin-binpath comes from the AUR package and has not been tried on hardware.Original authors are credited in the commits.
Tests: new
voxtype-install-test.shandbrave-widevine-test.sh, extendedlogging-test.sh; each fails on the unfixed code. The fulltest/shell.dsuite ran as non-root in an x86_64 Arch container on this branch and onquattro-upstream, and again with the same commits on upstreamquattro: results match the base apart from the two new tests passing (quattro-upstream 263 pass / 27 fail vs 260 / 28; upstream 223 / 31 vs 222 / 30). The remaining failures are the same on base and branch and come from tools missing in the container (lua, gum, ssh-keygen and so on). Two timing-sensitive tests,sleep-lockandsystem-sleep-ownership-migration, flipped between runs; rerun three times on every tree, they are as flaky on the base as on the branch. The three focused tests also pass as root (nothing written outside the scratch dirs) and on aarch64 Arch.Second review: first round found test gaps (stderr not separated, no non-executable backend case, migration test not asserting link state or idempotence, test touching
/etcwhen run as root); all fixed. It agreed that replacing a danglingWidevineCdmlink is a repair, not a bug.Upstream submission (not opened yet): the same three commits on top of omacom/omarchy
quattroare onmac/63-generic-quattro-fixes-upstream.