Repository navigation
Conversation
|
Reviewed and tested on a disposable Omarchy VM (inotify-tools 4.25.9, quickshell 0.3.1). The fix works, and nothing in it needs changing before a maintainer decides. What was checked. A local plugin under
The coalescing is what fixes #10702. Tests. Second opinion. Codex Medium reviewed the same diff. It agreed the problem is real and the change is proportionate (independence is not guaranteed, since it can read this review's working notes). It also raised three non-blocking points, checked against the source:
Nothing was pushed to this branch. It now waits on the maintainer. |
|
Fixes #10702. Current Ready for review from here; consider coordinating with #15023 / #13911 so we do not stack three partial reload fixes. |
quattro reworked localPluginReloadTimer to rescan when only new plugins appeared and fully reload only when a loaded plugin changed (omacom#18198). Keep that onTriggered and carry this branch's 1000ms interval onto it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
It greps PluginRegistry.qml and shell.qml for the strings this branch adds, which AGENTS.md rules out for a config value change, and its .git check already passes on quattro because localPluginIdForPath mentions /.git/. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This branch had stopped merging into What I pushed.
What was checked. Everything ran on a disposable Omarchy VM (inotify-tools 4.26, quickshell 0.3.2), with the shell running from each tree in turn. The test plugin was a local plugin whose
All of the improvement comes from the longer interval. Tests. Passed on the VM at this head: Second opinion. Codex Medium and muse-wonder (pi, thinking high) reviewed the merged head and the measurements, and neither found a blocking defect. Both agreed the timer merge and the regex are correct, and that removing the test was right. Their independence is not guaranteed, since they can read this review's working notes. They added two points about
Related pull requests. I compared the other open pull requests that touch the plugin watcher or the reload timer. Each fixes a different bug or a single trigger: #12189 (runtime-state writes), #12020 (bytecode, already covered on This waits on CI approval and then on the maintainer. |
[Medium impact] The PR appears safe to merge. SummaryFilters plugin watcher events from
Reviews (1) · Last reviewed commit: "Drop the source-grepping plugin watch te..." · Reviewed by Greptile |
Fixes #10702
inotifywait -m -ron~/.config/omarchy/pluginswatches every plugin.git. Working-tree writes (git checkout, editor saves) still firelocalPluginChanged, andlocalPluginReloadTimerreloads the whole graph every 150ms. An omamail checkout here produced a reload storm, then no bar (with #10703).--excludefor.git/__pycache__/node_modulestest/shell.d/plugin-watch-test.shasserts both--excludefilters events, not watches; skipping.gitin the watch list would be a follow-up.