Repository navigation
Keep lock password field focused - #10944
ArveLomsland wants to merge 1 commit into
Conversation
|
Thanks for this, @ArveLomsland. Reviewed by Claude Opus 5.5 in Claude Code and, as a second opinion, Codex at medium effort. The verdict is that #8560 is the better fix for the same problem, so this one is left for the maintainer to decide on rather than brought to ready. What ran. On a disposable VM with a real compositor, I locked the session, first serving Which part does the work. Of the three mechanisms, the one that addresses the real reports (#12525, focus lost across suspend) is the Neither fix can restore focus the compositor withheld, because Next: waiting on the maintainer to choose between this and #8560. #13907 also re-focuses after a failed password. |
|
Tested the |
|
Thanks, @brightwalker25, that report was worth following up. Reviewed again by Claude Opus 5.5 in Claude Code, with Codex at medium effort as the second opinion. My earlier comment here said the What was missing. While the password is checked, the field is disabled. Qt takes active focus away from a disabled item but remembers that it should have focus, and gives focus back when the item is enabled again. That is why a plain wrong password works on What ran. On a disposable VM with a real compositor, I hosted the real onAuthenticatingPasswordChanged: {
if (inputEnabled && !authenticatingPassword) Qt.callLater(forcePasswordFocus)
}A VM cannot suspend, so this models the focus change in a window, not the resume itself or a real PAM check. Which one. #8560 is the older fix. It has a behavioural test and has been confirmed after resume on several machines. This handler is the only part of this PR it lacks. So I have handed the handler to #8560 to add, credited to @ArveLomsland, rather than bringing this one forward. Codex preferred bringing this PR forward instead, for the same missing case. With the handler added to #8560, that case is no longer a difference between them. Codex also noted that Next: waiting on the maintainer. The handler goes to #8560, and the choice between the two is theirs. Nothing is needed from you. |
…ring While the password is checked the field is disabled, and Qt only gives focus back to a re-enabled item if nothing else took focus meanwhile. If the surface or another item takes it during the check, the field comes back unfocused and the onActiveFocusChanged reclaim never fires again, because the field had already lost active focus when it was disabled. Refocus when the check ends, and cover both cases in the fixture. The handler is @ArveLomsland's, from omacom#10944. Co-Authored-By: Arve Lømsland <arve@lomsland.no> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ring While the password is checked the field is disabled, and Qt only gives focus back to a re-enabled item if nothing else took focus meanwhile. If the surface or another item takes it during the check, the field comes back unfocused and the onActiveFocusChanged reclaim never fires again, because the field had already lost active focus when it was disabled. Refocus when the check ends, and cover both cases in the fixture. The handler is @ArveLomsland's, from omacom#10944. Co-Authored-By: Arve Lømsland <arve@lomsland.no> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit 39691c1)
Summary
Tests