Repository navigation
Conversation
MacBookPro13,2/13,3/14,2/14,3 pair a Cirrus CS8409 HDA bridge with a MAX98706 speaker amp that the in-tree snd_hda_codec_cs8409 driver never initialises, so the card comes up with speaker_outs=0 and only headphones work. fix-t2.sh does not cover these models: it gates on the T2 PCI ID (106b:180[12]), which the Touch Bar Macs predate. Install the davidjo/snd_hda_macbookpro DKMS codec patch on those models, excluding real T2 hardware. DKMS rebuilds it on every kernel bump, so the fix survives updates.
Add a migration that runs the same pre-T2 Touch Bar MacBook detection and installs snd-hda-macbookpro-dkms-git when it is missing, so machines set up before the install leaf existed get the fix without a manual re-apply after each omarchy update.
c45ae30 to
1ed9d45
Compare
|
Reviewed at 1. The package does not exist where 2. The model gate leaves out MacBookPro13,1 and 14,1. Not resolved here: #11619 reports that on a MacBookPro14,1 the stock Related: #12689 (draft) covers the same CS8409 models plus 13,1, 14,1 and the CS8409 iMacs, using Nothing was pushed to the branch. This now waits on the maintainer to decide whether and how the driver package is shipped. After that, the model gate needs widening and the change needs testing on one of these Macs, reboot included. |
|
Thanks for the review — both points are fair.
If maintainers would rather land #12689 instead, I'm fine closing this in its favour. Either way I can run a reboot test on my MacBookPro13,2, including the initramfs question from #11619, as soon as an installable package exists. |
Owners report CS8409 on the non-Touch Bar 13,1 and 14,1 too, so widen the model gate to 13,1-13,3 and 14,1-14,3. Skip the install when snd_hda_macbookpro is already registered with DKMS or its /usr/src tree exists: pacman would otherwise refuse the overlapping files and fail setup or the migration, and a second DKMS version would race a hand-built fork for updates/dkms. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] The change affects audio drivers on a narrow set of older MacBook Pros. Include the driver in the offline ISO package source before merging so affected MacBooks can complete setup. Findings
SummaryAdds a Cirrus speaker-driver installer for pre-T2 MacBooks, a migration for existing installs, and tests for hardware detection and existing drivers.
Reviews (1) · Last reviewed commit: "Cover MacBookPro13,1/14,1 and keep hand-..." · Reviewed by Greptile |
| echo "Existing snd_hda_macbookpro driver found; leaving it in place" | ||
| else | ||
| echo "Detected pre-T2 MacBook with Cirrus CS8409 speakers" | ||
| omarchy-pkg-add snd-hda-macbookpro-dkms-git |
There was a problem hiding this comment.
Offline setup cannot install driver
This step requests snd-hda-macbookpro-dkms-git, but the package is missing from install/omarchy-other.packages, which tells the ISO builder which extra packages to include. Fresh ISO installs still use an offline package source here. omarchy-pkg-add only runs pacman; it cannot fetch the AUR package. On a matching MacBook without a hand-built driver, this step fails instead of restoring the speakers. Make the package available through the package repository and include it in the ISO package list.
|
Re-reviewed at The model gate is fixed. The package still can't be installed. On a disposable Omarchy worker, #12689 (draft) installs the same driver family on these Macs and also covers the CS8409 iMacs. The two reviewers disagreed on which approach should go forward. One kept this PR as the older one, and because #12689's CS8409 path has no guard for hand-built drivers. The other preferred #12689 for its iMac coverage. Neither can install its package today, so the choice is left to the maintainer. Nothing was pushed. This is waiting on the maintainer to publish a CS8409 driver package and decide between this PR and #12689. After that, it needs the package name switched and your reboot test on the |
Problem
Pre-T2 2016–2017 MacBook Pros (
MacBookPro13,1–13,3,MacBookPro14,1–14,3) pair a Cirrus CS8409 HDA bridge with a MAX98706 speaker amp. The in-treesnd_hda_codec_cs8409driver never initialises the amp, so the card comes up withspeaker_outs=0and only headphone output works.install/hardware/apple/fix-t2.shdoes not help here — it gates on the T2 PCI ID (106b:180[12]), which these models predate. So today there is no path in Omarchy that restores speaker output on these Macs, and users have to re-apply an out-of-tree patch by hand after every update.Write-up of the underlying issue and manual fix: https://medium.com/@chris.xg.wang/installing-omarchy-linux-on-your-old-mac-heres-the-fix-for-your-sound-1a0c289377f4
Change
install/hardware/apple/fix-cirrus-speakers.sh(new) — detects the affected models via/sys/class/dmi/id/product_name, excludes real T2 hardware, skips machines that already have a hand-builtsnd_hda_macbookprodriver (registered with DKMS or/usr/src/snd_hda_macbookpro-0.1present), and otherwise installssnd-hda-macbookpro-dkms-git(davidjo/snd_hda_macbookpro). DKMS rebuilds the codec patch on every kernel bump, so the fix survives updates — no manual re-apply.install/hardware/all.sh— dispatches the new leaf next to the otherapple/lines, right afterfix-t2.sh.migrations/1788959623.sh(new) — same detection and hand-built-driver guard, idempotent (omarchy-pkg-presentguard), backfills the package on installs set up before the leaf existed.test/shell.d/cirrus-speakers-test.sh(new) — static checks plus stubbed runs of both the installer and the migration across the six target models, rejected models, T2 hardware, the already-installed case, and both hand-built-driver cases.Both scripts read
lspciinto a variable before matching to avoid thegrep -qSIGPIPE /pipefailmisfire (#6608).Verification
./test/shell— new test passes; the only failing files (config,locate,snapper,unowned-system-paths) fail identically on a cleanquattrohere (they need a localomarchy-pkgscheckout).MacBookPro13,2: after the DKMS build + reboot,dmesg | grep -i cs8409shows the patched codec,wpctl statuslists the speaker sink, andspeaker-test -D hw:0,0 -c 2 -t sine -f 440produces output from both speakers.Open questions for maintainers
-gitAUR dependency.snd-hda-macbookpro-dkms-githas no pinned release. Happy to switch to a versioned/vendored package or move it into the Omarchy package repo if you'd prefer.13,1–13,3/14,1–14,3after the review: owners report CS8409 on the non-Touch Bar13,1/14,1too (MacBook Pro 2015-2017 audio broken — need snd_hda_macbookpro driver #11619), and davidjo/snd_hda_macbookpro covers all six. Only13,2is hardware-tested here.linux-t2/apple-t2-audio-confignow covers any of these, shrinking the target.