Repository navigation
Stop screensaver busy-loop when branding text is missing - #11146
caueguerra wants to merge 1 commit into
Conversation
Fall back to $OMARCHY_PATH/logo.txt when the user branding file is absent, and exit instead of relaunching ttfx when it fails to start.
|
Another reason to merge this: the same An orphaned instance (terminal gone, reparented to It still happens on current master (4.0.0.r6687.gb18ab49). Repro, stopped after one second: setsid -f omarchy-screensaver </dev/null >/dev/null 2>&1
sleep 1; pgrep -xc ttfx # I get 8 -> 19 -> 29 at 0.25s steps
pkill -f '/omarchy-screensaver$'; pkill -x ttfx
hyprctl keyword cursor:invisible falseThis PR tracks |
|
Reviewed at dd1d7c7 against Reproduced. With Tests. The new Exiting on a non-zero Related. It closes #11090. #6813, #11178 and #11626 rewrite the same loop as part of larger changes and will conflict with this one. None of them is a focused fix for this bug. Second opinion. None ran: the reviewer answered a ping, but the day's review budget was already spent. This review is Claude Opus 5.5's alone, and that is why this is labelled |
|
Checked again because this no longer merges into What changed on Does the bug survive the replacement? Not as far as the source shows:
Second opinion. Codex at medium effort, given the diff and both codebases, reached the same answer. It cited the same commit and source lines, and found that any key press, Escape included, dismisses the native overlay. It also ran the installed package with no controlling tty and a nonexistent What happens next. Nothing here needs fixing, and the new test file targets a script that no longer exists, so it can't carry over either. I recommend closing this PR, and closing #11090 as fixed on |
If
~/.config/omarchy/branding/screensaver.txtis missing,ttfxexits immediately andomarchy-screensaverrelaunches it in a tight loop. The keyboard poll lives insidewhile pgrep, so Escape never dismisses it — only Ctrl+C works. To the user this looks like a crashed fullscreen terminal floodingError reading input file.$OMARCHY_PATH/logo.txt(the same fileomarchy branding screensaver resetalready copies).ttfxchild and exit when it fails, so a missing/unreadable file cannot spin the CPU. A clean effect completion still relaunches the next random effect.Fixes #11090