Skip to content

Keep the screensaver up until it has been focused once - #12258

Open
z23 wants to merge 6 commits into
omacom:quattrofrom
z23:fix/screensaver-focus-race
Open

z23 wants to merge 6 commits into
omacom:quattrofrom
z23:fix/screensaver-focus-race

Conversation

@z23

@z23 z23 commented Sep 17, 2026 •

Copy link
Copy Markdown

Fixes #12225.

The screensaver watchdog previously exited on its first unfocused poll. If the terminal had not received focus yet, the idle service interpreted that premature exit as a user dismissal and cancelled the pending lock.

Remember whether the terminal has received focus before treating focus loss as dismissal. A manual launch that never receives focus gives up after eight unfocused polls. An idle launch forwards --idle through every supported terminal and keeps the pending lock armed.

Also observe keyboard and mouse activity independently of terminal focus during an idle screensaver cycle. Once the launcher finishes restoring monitor focus, an input-only IdleMonitor cancels the pending lock, terminates the screensaver terminals through their normal signal cleanup and wakes the displays. Mapping activity retains the original launch guard; continued inactivity still reaches the lock deadline.

Validation: 42 focused assertions across the idle, activity, watchdog and launcher tests pass. Regression mutations removing cancellation, terminal dismissal or the launch guard are rejected. A clean integration tree with current quattro also passes those tests, the screensaver workspace test, style checks and command metadata. QML lint completes with warnings about incomplete Quickshell signal type metadata. No disposable graphical VM was available, so a live idle/lock acceptance cycle has not been run.

The watchdog treated the first unfocused poll as dismissal, so a mapping
race exited in about a second and cancelled the pending idle lock too.
@llstrk

llstrk commented Sep 25, 2026

Copy link
Copy Markdown

Automated AI review

Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review.

Verified: the change removes the self-exit behind #12225. A screensaver that is not the active window at its first focus poll no longer closes itself, so the idle service no longer treats it as a dismissal and the pending lock stays armed. Keypress dismissal, dismissal on focus loss after first focus, and the lock path behave as before. The new BASH_SOURCE guard does not affect any launch path in the repository (all terminal -e launches and the bash -lc fallback execute the script directly). The new test fails on base and passes on head.

One behavior trade-off is worth handling, plus an optional test improvement.

A screensaver that never receives focus now stays up with no bound

screensaver_lost_focus returns false on every poll until the screensaver has been the active window once (bin/omarchy-screensaver#L14-L20). If Hyprland never focuses it, nothing in the watchdog ends it. Hyprland 0.56.2 withholds initial focus from a newly mapped window when an interactive layer holds keyboard focus (Omarchy's menu, clipboard, emoji picker, polkit prompt and reminder overlays), when the focused surface has an active pointer constraint, or when a stay_focused window is visible (Window.cpp#L2425-L2458, FocusState.cpp#L109-L112). In the overlay case the map-time fullscreen rule is skipped too (Window.cpp#L2473-L2490), and closing the overlay refocuses the previously focused window, not the screensaver.

Screensaver never becomes the active window
                    base                           head
watchdog            exits on first poll (~1 s)     keeps polling, no exit
keypress            goes to the focused surface    goes to the focused surface
idle-cycle launch   cycle cancelled, no lock       lock fires at its deadline
manual launch       flashes and vanishes           stays up until focused or locked

The table is from source review of Hyprland 0.56.2 and Omarchy, plus stubbed runs of the watchdog loop (stub hyprctl returning a non-screensaver class). The focus-withholding cases were not reproduced in a live compositor.

Impact: in an idle cycle, the idle service ignores activity while a screensaver window exists (Service.qml#L158-L171), so a user who returns and types into the focused app is still locked at the deadline. A manual launch (System menu > Screensaver, branding previews, CLI) has no lock timer, so while the user keeps working the unfocused screensaver stays up until it is hovered or clicked and then dismissed, or the session is locked. While it exists, further launches silently do nothing (omarchy-launch-screensaver#L6). Omarchy's own menu path normally unmaps its overlay before the screensaver maps, so the manual case needs an extra condition such as a user keybind over an overlay or a pointer-locking app.

Suggested change: bound the pre-focus state instead of waiting indefinitely. Optional approaches: exit after a few seconds without first focus only when the screensaver was not launched by an idle cycle (the idle service already tracks that with screensaverStartedThisCycle), or have the idle service keep the lock armed when a never-focused screensaver closes. Either keeps the #12225 fix on the idle path. Neither approach was tested.

Note on the stated cause: in Hyprland 0.56.2 the openwindow event and initial focus happen in the same synchronous map handler (Window.cpp#L2366-L2371), so a later hyprctl activewindow poll cannot land "before Hyprland has focused the new window". The failing cycles in #12225 are more consistent with focus being withheld or taken at map, which is the case above. The fix does not depend on the explanation, but the code comment could say "the screensaver may not be the active window when the first poll runs".

Optional test improvement: the only check on the watchdog loop is a negative rg for the exact old line. In mutation runs, the test still passed with the loop changed to if read -n1 -t 1; then (focus ignored entirely) and with the old condition restored as read -t 1 -n1 || ! screensaver_in_focus. A positive assertion that the loop condition calls screensaver_lost_focus, or moving the loop decision into a small function tested with the existing stub, would catch both. Adding require_command rg would also stop the negative check from passing when rg is missing.


Review information

Test scope: Pinned head 89b4f538. Source review of the watchdog, launcher, idle service and lock script, and of Hyprland 0.56.2 focus and map handling. Sandboxed runs with all compositor, process and terminal commands stubbed: the new test on head and against the base script, three mutations of the head script, and the watchdog loop under scripted focus sequences. No live Hyprland session, idle cycle or terminal emulator was run.

AI process: Opus 5.5 Medium coordination and synthesis, independent Opus 5.5 Xhigh and GPT 6 Sol Xhigh technical assessments with targeted follow-up questions, Opus 5.5 Medium editorial check.

Opt out: To stop receiving these reviews, reply to this comment saying so.

Manual launches give up after a few unfocused polls. Idle-cycle launches pass --idle and keep waiting, so that exit is not treated as a dismissal that cancels the lock.
@z23

z23 commented Sep 26, 2026

Copy link
Copy Markdown
Author

Thanks. The unbounded manual launch was a real hole. 7514816 bounds it.

  • The comment now says the screensaver may not be the active window on the first poll, instead of claiming Hyprland focuses it after openwindow.
  • A launch that never receives focus exits after 8 unfocused polls, about eight seconds.
  • The idle service launches with omarchy-launch-screensaver --idle, and the launcher forwards that to omarchy-screensaver. Those launches do not give up. The idle service treats a screensaver exit as a dismissal and would cancel the lock, which is the Screensaver self-exits within ~1s, canceling the pending idle lock too #12225 failure.
  • The test requires rg, asserts the watchdog calls screensaver_lost_focus, and checks both the manual give-up and the idle wait.

I did not also teach the idle service to keep the lock armed when a never-focused screensaver closes. --idle keeps the original fix on the idle path without a second policy in the service. I have not run a live idle cycle.

@llstrk

llstrk commented Sep 27, 2026

Copy link
Copy Markdown

Automated AI review

Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review.

Follow-up on the earlier review, checked at 75148165 after the author's reply.

Verified: all three earlier points are resolved. The follow-up commit introduces one new problem: it drops the executable bit on both screensaver scripts. Three other open PRs also rewrite the same watchdog loop, and a fourth replaces the idle launch line.

Earlier point Status at 75148165
Never-focused screensaver stays up with no bound Resolved. A manual launch gives up after 8 unfocused polls. An --idle launch keeps waiting.
Code comment on the stated cause Resolved. The comment now says the screensaver may not be the active window when the first poll runs.
Optional test improvement (rg, loop assertion) Resolved. require_command rg and a positive assertion for screensaver_lost_focus were added. Both mutations that survived before now fail the test.

Verified: the author's claims hold. Runs of the real watchdog script, with no input and a stub hyprctl returning a non-screensaver class unless noted:

Launch                                  89b4f538 (earlier head)    75148165 (this head)
manual, never focused                   still up at 20 s           exits at ~8 s (8 polls)
--idle, never focused                   n/a                        still up at 25 s
manual or --idle, focused 3 to 12 s     n/a                        exits on focus loss (~12 s)

The launcher forwards --idle as a trailing argument after -e for Alacritty, Ghostty, foot and kitty (stubbed launcher runs, plus each terminal's upstream argument parsing). The idle service passes --idle (Service.qml#L69), so the #12225 fix still holds on the idle path. A never-focused idle screensaver now stays up until the lock deadline, where the lock script closes it. Keypress dismissal and dismissal on focus loss after first focus behave as before. The branch merges cleanly into current quattro, where the watchdog timings and the PR's test match the PR head.

The follow-up commit drops the executable bit on both scripts

75148165 changes bin/omarchy-launch-screensaver and bin/omarchy-screensaver from mode 100755 to 100644 (git diff --summary 89b4f538 75148165). Both are 100755 on the base and on current quattro. The test file's mode also changed, which is harmless because the test runner invokes tests with bash.

Impact:

  • Merged into current quattro: test/shell.d/screensaver-workspace-test.sh (added on quattro after this PR's base) runs "$ROOT/bin/omarchy-launch-screensaver" force directly and fails with Permission denied (exit 126). With the mode restored, the same merged tree passes.
  • Dev-linked checkouts: PATH lookup skips a non-executable file and falls through to the packaged /usr/bin/omarchy-launch-screensaver, which does not know --idle. Testing this PR through a dev link then exercises the released scripts, not the PR's. The omarchy command router also skips non-executable bin/ files (from source reading, not run).
  • Packaged installs: unaffected, because the PKGBUILDs install every bin/* with install -Dm755.

Suggested change: restore the mode, for example git add --chmod=+x bin/omarchy-launch-screensaver bin/omarchy-screensaver, and commit.

Other open PRs change the same watchdog and launch line

The first three PRs below replace the same read -n1 -t 1 || ! screensaver_in_focus condition in bin/omarchy-screensaver with their own focus handling. The fourth changes the idle launch line in Service.qml:

PR Overlap with this PR
#12808 (WezTerm support) Its own 10 s launch deadline with no idle exception. Adds a WezTerm launcher branch ending in -- omarchy-screensaver, which does not forward --idle.
#13475 (panel dismiss) Its own 5 s focus grace period.
#12730 (multi-monitor screensaver) Its own handling of an empty active-window class (exits after 3 empty polls), plus a --check-focus hook. Also adds test/shell.d/screensaver-test.sh, the same path this PR adds.
#10483 (configurable screensaver command) Replaces the idle launch line this PR changes; its default command is plain omarchy-launch-screensaver, without --idle. Already conflicting with its base.

Impact: whichever of the first three PRs merges second has to reconcile the watchdog by hand. The #12808 launcher itself merges without a conflict, so the missing forwarding would not surface as one. If this PR's watchdog is kept alongside #12808's WezTerm branch as written, an idle-cycle launch in WezTerm runs without --idle. If that screensaver never becomes the active window, it gives up after 8 unfocused polls and the pending lock is cancelled, the #12225 failure. This follows from the code in both PRs and was not run in WezTerm. If #12808's watchdog is kept instead, its 10 s deadline applies to idle launches too. Resolving #10483's conflict with its default command as written would also drop --idle from idle launches.

Suggested change: coordinate with the other PR authors on one watchdog policy. If this PR merges first, #12808's WezTerm branch needs "${screensaver_cmd[@]}" like the other four terminals.

Optional test improvement: the --idle plumbing is checked only as text. The launcher grep on line 17 already matches the array assignment. The test sources the watchdog and sets screensaver_idle=1 itself, so the argument loop is never exercised. Three mutations still pass the test:

  • the argument loop no longer sets screensaver_idle, so an idle launch that never takes focus gives up after 8 unfocused polls (consequence read from the code);
  • all four terminal branches revert to -e omarchy-screensaver;
  • the launcher never matches --idle.

Moving the argument parsing into a function above the BASH_SOURCE guard and testing that function would catch the first. On quattro, the stubbed launch in screensaver-workspace-test.sh already records the exact exec command, so a --idle case asserting that the command contains -e omarchy-screensaver --idle would catch the other two.


Review information

Test scope: Pinned head 75148165, compared with the earlier reviewed head 89b4f538, the base, and a local merge into current quattro. Source review of the changed scripts, idle service and callers, of four open PRs that touch the same files, and of the argument handling in upstream Alacritty, Ghostty, foot and kitty source. Sandboxed runs with compositor, process and terminal commands stubbed: the PR's test on base, the earlier head, the current head and the merge; mutations of the head scripts; the launcher's exec commands for each terminal; and the watchdog under scripted focus sequences. The mode effects were checked with a sandboxed PATH-lookup probe and a run of quattro's test on the merge. No live Hyprland session, terminal emulator, WezTerm, dev-linked session or idle cycle was run.

AI process: Opus 5.5 Medium coordination and synthesis, Opus 5.5 Xhigh technical review and final fact check, GPT 6 Sol Xhigh search for related issues, Opus 5.5 Medium editorial check.

Opt out: To stop receiving these reviews, reply to this comment saying so.

z23 added 2 commits September 28, 2026 10:10
The follow-up commit dropped the executable bit on both scripts. Record
--idle before the source guard so the argument is covered without starting
the effect.
@z23

z23 commented Sep 28, 2026 •

Copy link
Copy Markdown
Author

Thanks for the follow-up. The three earlier points stay resolved. Taken in b359a76:

  • Restored the executable bit on bin/omarchy-launch-screensaver and bin/omarchy-screensaver. Packaged installs were already 755; a dev-linked checkout was not.
  • --idle is parsed in screensaver_apply_args above the source guard, and the test calls that function. A text check also requires each of the four terminal branches to exec "${screensaver_cmd[@]}", so dropping --idle from the array or reverting a branch to -e omarchy-screensaver fails the test.

I did not fold in the other open screensaver pull requests. This branch keeps its own watchdog: a manual launch gives up after 8 unfocused polls, and an --idle launch does not. If #12808 lands its WezTerm branch without forwarding --idle, an idle launch from WezTerm would hit that give-up and cancel the pending lock. That branch needs "${screensaver_cmd[@]}", the same as the other four terminals. Happy to rebase if one of those lands first.

@llstrk

llstrk commented Sep 29, 2026

Copy link
Copy Markdown

Automated AI review

Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review.

Outcome: No defects in the new commits; one clash with #7193 not raised before.

Follow-up on the second review and reply, at 77961872.

  • Executable bits: resolved.
  • Optional --idle tests: mostly resolved, 2 of 3 mutations caught.
  • Overlapping PRs: still present, more than listed.
  • First review's points: still resolved.

#7193's native screensaver exits on --idle

#7193 merges with this PR without a conflict. Its launcher execs the native binary with "$@" before the --idle handling, and the binary exits 2 on unknown arguments. Impact: with it installed, idle cycles show no screensaver; the lock still fires. Not run.

Suggested change: strip --idle before the native exec, or have the binary accept it.

Details: #7193 source
Details: overlapping open PRs

The four PRs named in the second review (#12808, #13475, #12730, #10483) have not changed since then and still overlap as described. Other open PRs on the same lines:

PR Overlap
#13637, #7102 Replace the same watchdog condition with a "stay up until first focus" latch, with no bound for a never-focused launch and no idle exception. Conflict in bin/omarchy-screensaver. #13637 was opened after the second review; #7102 already existed then.
#13647 Rewrites the same watchdog condition. Conflict in bin/omarchy-screensaver.
#7307, #7766, #10751 #7307 and #7766 rewrite all four terminal exec lines, #10751 the kitty line, with plain -e omarchy-screensaver. Conflict in the launcher. The new four-branch check fails a resolution that keeps their lines.
#9493 Moves the idle launch out of Service.qml with a fallback command without --idle. Conflict in Service.qml.
#11146, #11191, #6813, #8556 Add the same test/shell.d/screensaver-test.sh path, like #12730.

Conflicts are from merge checks of each PR head against 77961872.

Details: verified
  • Both scripts are mode 100755 again. Merged into current quattro, screensaver-test.sh and quattro's screensaver-workspace-test.sh both pass. With the launcher set back to 0644, the workspace test fails with Permission denied (exit 126).
  • Mutations now caught: the argument loop no longer setting screensaver_idle, and any terminal branch reverted to -e omarchy-screensaver.
  • Stubbed runs of the executed watchdog: a manual launch that never gets focus exits after 8 polls; an --idle launch keeps polling.
  • Nothing else in the head tree or quattro sources bin/omarchy-screensaver, and the test runner passes the test no arguments, so the screensaver_apply_args "$@" call above the source guard does nothing there.
Optional test notes

1. The top-level screensaver_apply_args "$@" call is untested. Deleting it still passes the test, and that mutant makes an idle launch give up after 8 unfocused polls (stubbed run). Sourcing the script with --idle and asserting screensaver_idle == 1 catches it.

Run from a checkout of the PR head 77961872. Removing the top-level screensaver_apply_args "$@" call, so that omarchy-screensaver --idle never takes the idle path, still passes the test:

sed -i '/^screensaver_apply_args "\$@"$/d' bin/omarchy-screensaver
bash test/shell.d/screensaver-test.sh
ok - screensaver does not treat the first unfocused poll as dismissal
ok - screensaver stays up before it has been focused
ok - screensaver stays up once it is focused
ok - screensaver dismisses after losing focus
ok - manual screensaver gives up when it never receives focus
ok - idle screensaver keeps waiting for focus
ok - screensaver records --idle from its arguments
ok - every terminal launcher forwards the screensaver command
[exit 0]

Appending this to test/shell.d/screensaver-test.sh sources the script with --idle as its argument, the way the terminal runs it:

# Source the script the way the terminal runs it, with --idle as its argument,
# so the top-level call to screensaver_apply_args is covered too.
screensaver_idle=0
source "$ROOT/bin/omarchy-screensaver" --idle
((screensaver_idle == 1)) || fail "omarchy-screensaver --idle takes the idle path"
pass "omarchy-screensaver --idle takes the idle path"

With the call removed, the extended test fails:

ok - screensaver does not treat the first unfocused poll as dismissal
ok - screensaver stays up before it has been focused
ok - screensaver stays up once it is focused
ok - screensaver dismisses after losing focus
ok - manual screensaver gives up when it never receives focus
ok - idle screensaver keeps waiting for focus
ok - screensaver records --idle from its arguments
ok - every terminal launcher forwards the screensaver command
not ok - omarchy-screensaver --idle takes the idle path
[exit 1]

On the unmodified head, the extended test passes:

ok - screensaver does not treat the first unfocused poll as dismissal
ok - screensaver stays up before it has been focused
ok - screensaver stays up once it is focused
ok - screensaver dismisses after losing focus
ok - manual screensaver gives up when it never receives focus
ok - idle screensaver keeps waiting for focus
ok - screensaver records --idle from its arguments
ok - every terminal launcher forwards the screensaver command
ok - omarchy-screensaver --idle takes the idle path
[exit 0]

[exit N] lines are the command's exit status, added by the harness.

2. The exact count of 4 does not see a fifth terminal branch that does not use -e. After merging #12808 (keeping this PR's watchdog), the test passes while the WezTerm branch runs a bare -- omarchy-screensaver. Failing on any bare -e omarchy-screensaver or -- omarchy-screensaver catches it.

From a checkout of the PR head 77961872, merge #12808 at its current head c77e26d7:

git fetch origin c77e26d7e055b5141be88248922a1a77cc171351
git merge --no-ff --no-edit c77e26d7e055b5141be88248922a1a77cc171351
Auto-merging bin/omarchy-launch-screensaver
Auto-merging bin/omarchy-screensaver
CONFLICT (content): Merge conflict in bin/omarchy-screensaver
Recorded preimage for 'bin/omarchy-screensaver'
Automatic merge failed; fix conflicts and then commit the result.

Keep this PR's side of the watchdog conflict (output of these three commands omitted):

git checkout --ours bin/omarchy-screensaver
git add bin/omarchy-screensaver
git commit --no-edit

The launcher merged without a conflict and the test passes, but the WezTerm branch still runs a bare omarchy-screensaver:

bash test/shell.d/screensaver-test.sh
grep -nE -- '(-e|--) omarchy-screensaver( |$)' bin/omarchy-launch-screensaver
ok - screensaver does not treat the first unfocused poll as dismissal
ok - screensaver stays up before it has been focused
ok - screensaver stays up once it is focused
ok - screensaver dismisses after losing focus
ok - manual screensaver gives up when it never receives focus
ok - idle screensaver keeps waiting for focus
ok - screensaver records --idle from its arguments
ok - every terminal launcher forwards the screensaver command
[exit 0]
80:    hypr_exec wezterm-gui --config-file "$OMARCHY_PATH/default/wezterm/screensaver.lua" start --always-new-process --class org.omarchy.screensaver -- omarchy-screensaver
[exit 0]

A check that fails on any bare -e omarchy-screensaver or -- omarchy-screensaver would catch this:

if grep -nE -- '(-e|--) omarchy-screensaver( |$)' "$ROOT/bin/omarchy-launch-screensaver"; then
  fail "every terminal launcher forwards the screensaver command"
fi

The same grep matches nothing on the unmerged PR head, so the check passes there.

[exit N] lines are exit statuses, added by the harness.

3. The launcher's --idle match is still untested (the text checks cover the array and the exec lines). Making it never match passes the test. After a rebase onto quattro, an --idle case in screensaver-workspace-test.sh asserting the exec command contains -e omarchy-screensaver --idle would catch it.

Run from a checkout of the PR head 77961872. Making the launcher never match --idle, so every launch gets the plain omarchy-screensaver command, still passes the test:

sed -i 's/== --idle ]]/== --never-idle ]]/' bin/omarchy-launch-screensaver
grep -n 'never-idle' bin/omarchy-launch-screensaver
bash test/shell.d/screensaver-test.sh
11:if [[ ${1:-} == --never-idle ]]; then
ok - screensaver does not treat the first unfocused poll as dismissal
ok - screensaver stays up before it has been focused
ok - screensaver stays up once it is focused
ok - screensaver dismisses after losing focus
ok - manual screensaver gives up when it never receives focus
ok - idle screensaver keeps waiting for focus
ok - screensaver records --idle from its arguments
ok - every terminal launcher forwards the screensaver command
[exit 0]

[exit N] is the test's exit status, added by the harness.


Review information

Test scope: Source, merge checks and stubbed sandbox runs at 77961872; no live session or native binary run.

AI process: Opus 5.5 Medium coordination and synthesis, Opus 5.5 Xhigh technical review and final fact check, GPT 6 Sol Xhigh search for related issues, Opus 5.5 Medium editorial check.

Opt out: To stop receiving these reviews, reply to this comment saying so.

@greptile-apps

greptile-apps Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium risk] Screensaver focus behavior and idle-cycle integration.

The PR appears safe to merge based on the reviewed changes.

Summary

The PR keeps an unfocused screensaver running until it has received focus, forwards --idle through terminal launches, and adds an input monitor to dismiss an idle-cycle screensaver without cancelling its pending lock during launch. Tests cover argument forwarding, focus transitions, and the idle-cycle activity path.

Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  A[Idle cycle] --> B[Launch screensaver with --idle]
  B --> C[Wait for windows and restore monitor focus]
  C --> D[Watch for input]
  D -->|Activity| E[Dismiss screensaver and cancel lock timer]
  D -->|No activity| F[Lock at deadline]
Loading

Reviews (2) · Last reviewed commit: "Dismiss idle screensavers on input witho..."

Comment thread bin/omarchy-screensaver Resolved
@z23

z23 commented Oct 2, 2026

Copy link
Copy Markdown
Author

Thanks for the follow-up. The argument parser is now exercised through the script's top-level call, and the launcher is tested with actual stubbed exec commands for manual and --idle launches in all four supported terminals. Those tests pass, including in a clean integration tree with current quattro.

I agree the --idle interface will need reconciliation if the native screensaver in #7193 lands. That PR is still open and its native dispatch is not part of this branch, so I am keeping that integration change with the merge that introduces it rather than adding speculative native-binary handling here. The same applies to the other alternative watchdog implementations: whichever lands next needs to preserve the launch guard and explicit input dismissal. This update handles the activity gap in the current terminal implementation without incorporating those separate proposals.

@omarchybot

Copy link
Copy Markdown
Collaborator

Read at head 2518786: the diff, #12225, and the review thread above. Nothing was run on a worker yet, because the classification is not settled.

The classification is unsettled. I (Claude Opus 5.5) classified this as a bug fix for #12225: on quattro, bin/omarchy-screensaver exits on its first unfocused poll, and the idle service takes that exit as a dismissal and cancels the pending lock. The second model, Codex Medium, asked separately without my answer, classified it as an enhancement. Two models that disagree leave it without a class label.

The split follows the shape of the change. The focus latch in bin/omarchy-screensaver is the fix #12225 asks for. The rest adds behaviour that was not there before: the --idle flag through bin/omarchy-launch-screensaver and all four terminals, manual launches giving up after eight unfocused polls, and a new input-only IdleMonitor in shell/plugins/services/idle/Service.qml that dismisses an idle screensaver on keyboard or mouse input without focus.

#13637 and #13475 change the same watchdog loop for the same issue; this is the oldest of the three.

Waiting on the maintainer to decide what this is, and with it whether the fix and the new input handling land together or as two pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Screensaver self-exits within ~1s, canceling the pending idle lock too

3 participants