Repository navigation
Conversation
1 task done
Co-authored-by: AnPod <AnPod@users.noreply.github.com>
cursor
Bot
force-pushed
the
fix/screensaver-panel-focus-dismiss
branch
from
September 29, 2026 21:04
9da44f0 to
cbf5c0b
Compare
This was referenced Oct 2, 2026
|
Thanks for this. A few notes:
|
This was referenced Oct 9, 2026
Open
Working implementation across Bar, Shell, and Idle ServiceWe encountered and verified this issue on Omarchy 4.5.0 ( Here is a tested implementation that cleanly resolves both the visual overlay and the input grab across all panel types (both bar-widget popups and overlay panel loaders):
function closeAllPopouts() {
if (activePopout) {
if (typeof activePopout.close === "function") activePopout.close()
activePopout = null
}
for (var i = 0; i < moduleSlots.length; i++) {
var slot = moduleSlots[i]
if (slot && slot.activeItem && typeof slot.activeItem.close === "function") {
if (slot.activeItem.opened === true || slot.activeItem.open === true) {
slot.activeItem.close()
}
}
}
return true
}
function closeAllPanels() {
if (shell.bar && typeof shell.bar.closeAllPopouts === "function") {
shell.bar.closeAllPopouts()
}
for (var id in panelLoaders) {
hide(id)
}
for (var openId in openPanelIds) {
hide(openId)
}
return true
}
function launchScreensaver() {
root.screensaverStartedThisCycle = true
screensaverLaunchGraceTimer.restart()
if (shell && typeof shell.closeAllPanels === "function") shell.closeAllPanels()
runProcess(screensaverProcess, "screensaver", "[[ $(omarchy-shell lock isLocked 2>/dev/null) == \"true\" ]] || omarchy-launch-screensaver")
}
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a bar widget's
KeyboardPanel(such as the calendar) is open and the idle screensaver launches, the overlay surface holds exclusive/on-demand focus and a full-screen input region. That stops the screensaver window from becoming active, soomarchy-screensaverexited within ~1s believing the user had dismissed it (#13265).This:
omarchy-shell shell hideOpenPanelswhen launching the screensaver.omarchy-screensaverso temporary focus lag after mapping cannot immediately trigger self-dismissal.Fixes #13265
Testing
test/shell.d/screensaver-panel-focus-test.shverifying panel dismissal and focus grace.bash test/shell.d/screensaver-panel-focus-test.sh(all 5 assertions passed).