Repository navigation
Detect FocalTech match-on-chip fingerprint readers - #11387
alanwcurry-dev wants to merge 4 commits into
Conversation
johnpippett
left a comment
There was a problem hiding this comment.
Source commit: 26745881380a7217d0dc35cf68de730b71df399e.
Comparison commit: 31bd80daa4613ffdee995ac27467fce5a2990806.
Codex did the isolated tests on 2026-09-12. All 40 independent cases gave the expected results.
The cases included missing device information, driver exclusions, multiple devices, and setup failures.
The upstream fingerprint suite gave the expected results for 11 base assertions and 13 head assertions.
Call records showed the expected package and enrollment steps.
The tests used the actual scripts with synthetic USB device files.
Test programs replaced the package, enrollment, and verification commands.
Bubblewrap used private home, process, runtime, and network namespaces. The source files did not permit writes.
I do not have this reader. These tests did not include physical enrollment or authentication.
I have a question about the device detection rule.
The description reports successful hardware tests for 2808:a57a and explains that FocalTech touch controllers have kernel drivers.
The new vendor rule accepts every device with vendor ID 2808 that has no kernel driver.
What device or driver documentation shows that all FocalTech devices without kernel drivers are fingerprint readers?
If the documentation describes only 2808:a57a, could the rule use that vendor and product pair instead?
This is a question about device coverage. Our tests did not show incorrect detection of a physical device.
They do not establish compatibility with every FocalTech product.
|
Reviewed at 2674588, on a disposable Omarchy worker. The fix does what it says, and nothing in the diff needs changing. What was checked
One thing for the maintainer to weigh. That same package also lists several FocalTech readers it knows of but has no driver for ( Second opinion: none. The configured reviewer (Codex Medium) answers, but today's review budget was spent before this item was reached, so this review is mine alone (Claude Opus 5.5). What it waits on: this is hardware a worker does not have. The stubbed sysfs proves the detection logic, not the laptop. The only on-device confirmation so far comes from the PR's author, and that cannot double as independent confirmation. It needs a maintainer, or another owner of a |
|
Tested on an ASUS ExpertBook B9406CAA with a FocalTech |
|
Re-checked at 2674588 after @jddmgt's report, this time with a second opinion. Nothing in the diff needs changing. What's new since the last review
Second opinion (Codex Medium): found no defect in the change, and agreed that adding the vendor is the proportionate fix. It confirmed that the What it waits on: the maintainer. This is hardware a worker does not have, and a confirmation on a real device counts toward readiness only when it comes from the issue's reporter or a maintainer. Here the reporter is also the PR's author, so @jddmgt's test is useful corroboration but does not settle it. If a maintainer runs |
|
Re-checked at 2674588. The diff is unchanged and still correct. What has changed is who can confirm it. What's new. This pull request now also closes #14089, which @jddmgt opened. A reporter's confirmation on real hardware is what a fingerprint fix like this needs, since a worker has no FocalTech reader. That confirmation can come from the person who opened an issue the fix closes, but not from the pull request's author. So @jddmgt's test now counts, where the last review could only call it corroboration. There is one gap: the rule asks for the full commit the test ran on, and the earlier comment names @jddmgt, could you reply here with the result at the full commit curl -fsSL https://raw.githubusercontent.com/alanwcurry-dev/omarchy/26745881380a7217d0dc35cf68de730b71df399e/bin/omarchy-hw-fingerprint -o /tmp/omarchy-hw-fingerprint
bash /tmp/omarchy-hw-fingerprint; echo $?
What was checked this time. Second opinion (Codex Medium): it read the diff against current What it waits on: @jddmgt's confirmation at the full commit. A maintainer's confirmation on a FocalTech machine would also do. |
|
Confirmed at the full commit |
|
Re-checked at 2674588 after @jddmgt's confirmation. The diff is unchanged, and it is now verified on real hardware. The confirmation. @jddmgt opened #14089, which this pull request closes, and has confirmed at the full commit What was checked this time, on a disposable Omarchy worker, with this head merged into current
Second opinion (Codex Medium): found no defect. It agreed the change is proportionate, and it confirmed the What it waits on: the maintainer. Nothing is left for the author. |
quattro's omacom#14675 added platform-named readers to omarchy-hw-fingerprint and its test. The script merged cleanly; the test conflicted only because both appended cases at the end, so the FocalTech cases now follow the platform ones, after the platform file is removed, and still exercise the USB scan alone. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This branch stopped merging after What was checked at
Second opinion (Codex Medium): it read the merge and found no defect. It confirmed that nothing from either side was lost, that the test's copy of the script carries the What it waits on: a confirmation on real hardware at the new head. A merge commit is a new head, so @jddmgt's confirmation at curl -fsSL https://raw.githubusercontent.com/alanwcurry-dev/omarchy/aad2b220af3ef64115e25dc2b77da452738ec668/bin/omarchy-hw-fingerprint -o /tmp/omarchy-hw-fingerprint
bash /tmp/omarchy-hw-fingerprint; echo $?
|
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryAdds FocalTech fingerprint readers to hardware detection while keeping the existing check that excludes devices with bound kernel drivers.
No actionable issues found. Reviews (2) · Last reviewed commit: "Drop the FocalTech rejection test the ex..." · Reviewed by Greptile |
|
Confirmed at the full commit |
|
Thanks, @jddmgt. Your confirmation that Together with the worker run and the Codex Medium second opinion described in the comment above, both at this same head, it is now labelled |
FocalTech joins the same vendor list the file's existing driver-rejection test already exercises, and that block passed on the base branch. Co-Authored-By: Opus 5.5 High <noreply@anthropic.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
I merged current What was checked, on an Omarchy worker, against the merged branch:
Claude Opus 5.5 at high effort reviewed the changes as a second opinion; its findings are folded in. Its independence from my review isn't guaranteed. Greptile scores the new head 5/5 with no open findings. This waits on the maintainer, starting with approving the workflow run: CI hasn't run on this head yet. |
Fixes #11384.
omarchy-hw-fingerprintmisses FocalTech match-on-chip readers, soomarchy setup security fingerprintaborts with "No fingerprint sensor detected." on a laptop whose reader the pinnedlibfprint-gitalready supports (upstream lists2808:a57aas "Focaltech MOC Sensors").The reader reports
FocalTech FT9365 ESSand misses both detection paths:2808is not infingerprint_vendors, and the product string names no function, so none of thefingerprint/biometric/elan:arm-m4/fpcpatterns match it. The vendor ID is the only thing that can carry these readers, and the existing driver check is what keeps FocalTech's touch controllers out — they bindusbhid/i2c-hid, while a match-on-chip reader sits there driverless, exactly the shapehas_kernel_driveralready tests for.Because the wizard bails before it installs anything, affected machines end up with no
fprintd/libfprintat all, which makes it look like the sensor does not exist. The same detector also gatessetup-fingerprint.hook, so those machines never get the post-update invitation either.Testing
test/shell.d/hw-fingerprint-test.shgains two cases: a driverless2808:a57adevice is detected by vendor, and the same device withusbhidbound is rejected.2808:a57a) the patched script exits 0 against real sysfs where it previously exited 1, andomarchy setup security fingerprintthen runs end to end: enrollment,fprintd-verifymatch, PAM stacks written, and the fingerprint accepted by bothsudoand polkit../test/allhere:test/shell.d/hw-fingerprint-test.shpasses.config-test.sh,snapper-test.shandunowned-system-paths-test.shfail identically at the parent commit on this machine because they want anomarchy-pkgscheckout that is not present — unrelated to this change.Fixes #14089