Repository navigation
Read notification hints through QVariantMap accessors - #11776
Closed
chessing234 wants to merge 1 commit into
Closed
chessing234 wants to merge 1 commit into
chessing234 wants to merge 1 commit into
Conversation
Quickshell 0.3.1 can wrap D-Bus a{sv} hints so custom keys are invisible
to bracket indexing. Prefer .value()/.get() before falling back so
omarchy-exec-argv click actions work again instead of silently no-oping.
1 of 2 tasks
Contributor
Author
|
folding into #12111 with the other notification hardening |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
omarchy-exec-argvcan sit on a QVariantMap wrapper wherehints[name]returns undefined..value()/.get()first, then plain indexing, so click-to-exec (crash diagnose, etc.) works again instead of silently no-oping.Fixes #8346
Test plan
bash test/shell.d/notifications-test.sh--execand confirm click / invokeLast runs it