Skip to content

Read notification hints through QVariantMap accessors - #11776

Closed
chessing234 wants to merge 1 commit into
omacom:quattrofrom
chessing234:fix/8346-notification-hint-value
Closed

chessing234 wants to merge 1 commit into
omacom:quattrofrom
chessing234:fix/8346-notification-hint-value

Conversation

@chessing234

@chessing234 chessing234 commented Sep 14, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • After the quickshell-git → quickshell 0.3.1 swap, custom D-Bus hints such as omarchy-exec-argv can sit on a QVariantMap wrapper where hints[name] returns undefined.
  • Read via .value() / .get() first, then plain indexing, so click-to-exec (crash diagnose, etc.) works again instead of silently no-oping.

Fixes #8346

Test plan

  • bash test/shell.d/notifications-test.sh
  • On quickshell 0.3.1: send a notification with --exec and confirm click / invokeLast runs it

Quickshell 0.3.1 can wrap D-Bus a{sv} hints so custom keys are invisible
to bracket indexing. Prefer .value()/.get() before falling back so
omarchy-exec-argv click actions work again instead of silently no-oping.
@chessing234

Copy link
Copy Markdown
Contributor Author

folding into #12111 with the other notification hardening

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

quickshell-git → quickshell 0.3.1 mid-update swap breaks omarchy-exec-argv notification hint, silently no-ops "Click to diagnose with AI"

1 participant