Skip to content

Harden notification image copies, exec tokens, and hint reads - #12111

Closed
chessing234 wants to merge 6 commits into
omacom:quattrofrom
chessing234:fold/notification-hardening
Closed

chessing234 wants to merge 6 commits into
omacom:quattrofrom
chessing234:fold/notification-hardening

Conversation

@chessing234

@chessing234 chessing234 commented Sep 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Test plan

  • notification-send-test.sh
  • notifications-test.sh (node; local runner broken on this host)

A same-uid sender can name file:///home/…/.ssh in a toast. The shell runs
as the user and used to copy that path into history.
The JS allowlist is not enough if /tmp/foo is a symlink onto a secret.
…opies.

History JSON must not keep a file:// path into /etc or ~/.ssh either.
Quickshell 0.3.1 can wrap D-Bus a{sv} hints so custom keys are invisible
to bracket indexing. Prefer .value()/.get() before falling back so
omarchy-exec-argv click actions work again instead of silently no-oping.
@chessing234

Copy link
Copy Markdown
Contributor Author

exec-token gate is on #13312 as a focused pr (with the startup/restore fixes)

@jandrusk

Copy link
Copy Markdown

Looks like a solid hardening fold (image allowlist + session token + hint accessors). #13312 is the token-only slice — this seems the better single merge.

One ask: confirm notifications-test.sh status (body says local runner broken) before merge.

@ryanrhughes

Copy link
Copy Markdown
Collaborator

Thanks @chessing234! Most of this is in the new notification engine (#15932): sender image paths go through one strict path policy (Security.localImagePath), and hints are read defensively in Store.snapshot. The exec-token piece I'm not taking, same reason as #13312: the click command is structural argv only, and a same-user process is out of scope (it's in docs/notifications.md). Closing, and thanks for pulling these together.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants