Repository navigation
Harden notification image copies, exec tokens, and hint reads - #12111
chessing234 wants to merge 6 commits into
Conversation
A same-uid sender can name file:///home/…/.ssh in a toast. The shell runs as the user and used to copy that path into history.
The JS allowlist is not enough if /tmp/foo is a symlink onto a secret.
…opies. History JSON must not keep a file:// path into /etc or ~/.ssh either.
Quickshell 0.3.1 can wrap D-Bus a{sv} hints so custom keys are invisible
to bracket indexing. Prefer .value()/.get() before falling back so
omarchy-exec-argv click actions work again instead of silently no-oping.
152a9f3 to
b7a787e
Compare
|
exec-token gate is on #13312 as a focused pr (with the startup/restore fixes) |
|
Looks like a solid hardening fold (image allowlist + session token + hint accessors). #13312 is the token-only slice — this seems the better single merge. One ask: confirm notifications-test.sh status (body says local runner broken) before merge. |
|
Thanks @chessing234! Most of this is in the new notification engine (#15932): sender image paths go through one strict path policy ( |
Summary
Test plan