Repository navigation
Conversation
The move gesture died with zero mapped clients because leaving the bar strip handed the pointer to the wallpaper and cancelled the grab. Eligibility no longer depends on toplevels, and a lost grab is handed to the move overlay so the edge preview can finish the drag. Co-authored-by: Steve Curry <thescurry@users.noreply.github.com>
Taking the pointer after a lost grab never armed the overlay, so a still release at the strip edge left the ghost mapped. Handoff now arms, a poll finishes a motionless button-up, and Escape, a secondary click, or a short timeout abort the same stuck state. Co-authored-by: Steve Curry <thescurry@users.noreply.github.com>
Live soak on my laptop (ASUS Vivobook, Intel Arc)Against #11915 with this PR applied over tip:
So the eligibility / “start the gesture without clients” part is real, but the empty-desktop handoff path does not survive Wayland grab cancel on Hyprland here. What we think is going wrong
With those local adjustments (deferred AskPlease don’t merge on the windowed-only path alone — empty desktop is the bug in #11915. A small follow-up (or revision) covering the handoff/ Not a +1 yet for empty-desktop; happy to re-soak after a revision. |
|
Reviewed at d71d46e by Claude Opus 5.5, with Codex Medium as a second opinion. Nothing was run on a worker: #12646 is a competing fix for #11915, and both reviews point to it as the one to bring forward, so this one was compared with it by reading the code rather than verified on its own. Why the handoff here doesn't finish the move on an empty desktop. When the strip loses the grab, Why #12646. It doesn't hand off the grab at all. The panel that owns the gesture expands to fill its output while the move is active, so the pointer never leaves the surface that holds the press, and the original One thing applies to both pull requests: This waits on the maintainer to choose between the two. If it's this one, it needs a mechanism that doesn't depend on the overlay seeing button state. |
|
Thank you for this, @thescurry. #12646 fixes the same problem in a way the review judged better, so this is closed in favour of it. If it does not cover your case, please say so there. Closed at the maintainer's request. The review comment above has the details; it was done by Claude Opus 5.5 with Codex Medium as a second opinion, whose agreement is not independent. |
Summary
Fixes #11915
Bar reposition-drag failed with zero mapped windows: after the pointer left the strip, Hyprland dropped the grab on wallpaper, and cancel aborted the move.
Test plan
bash test/shell.d/bar-test.sh(incl. arm-on-handoff + abort locks)Code QA Pass @ d71d46e (Fail 1 fixed). Fork review: thescurry#3