Repository navigation
Show plugin update diffs without git's pager - #12335
elberacasa wants to merge 1 commit into
Conversation
|
Independent reproduction, on a newer build than the one in #12332. System: Hit this during a normal Worth noting for prioritisation: There is also a second-order effect the original issue didn't cover. This patch is the fix. Applying the equivalent locally ( One process note: #12332 was closed as completed in favour of this PR, so the bug currently has no open tracking issue while the patch sits unmerged. Anyone hitting it and searching will find a closed issue and conclude it is fixed. |
|
Thank you, that is a better report than the one I filed. Confirmed the dependency point here on 4.0.4-1: The inhibitor part is the one that changes how this reads. My issue treated it as a confusing prompt; parking a hands-off On the process note: you are right, and I reopened #12332 so the bug has an open tracking issue while the patch waits. It closes when this merges. The patch is unchanged and still one word on the non-delta branch, matching what the delta branch already does. |
|
Reopened as #13345. This one closed because I deleted my fork by accident, not because anything was wrong with the patch. Same change, rebased on current |
omarchy plugin update <id>prints the diff with an unpipedgit diff, so git starts its pager whenever output goes to a terminal. Thegum confirm "Update <id>?"that follows then waits behind the pager, invisible: Enter scrolls one line insideless, so the update looks stuck with nothing to suggest a keypress is expected. Quitting the pager withqreveals the prompt.Only installs without
deltaare affected. On thedeltapath the diff is piped, which makes git skip its pager, so the prompt is already visible there;--no-pagergives the other path the same behaviour.Verification
Omarchy 4.0.4-1, gum 2.0.0-1,
deltanot installed, defaultcore.pager.With a throwaway plugin whose upstream is one commit ahead, run in a real terminal with
GIT_PAGERset to announce itself:test/clipasses, and shellcheck is clean on the changed file.Notes
bin/omarchy-plugin-addprints no diff, and the othergit logcalls inbin/run inside command substitution, where git never pages, so this is the only place affected.Reported as #12332, which this replaces.