Repository navigation
Show plugin update diffs without git's pager - #13345
elberacasa wants to merge 1 commit into
Conversation
Automated AI review
Verified: no problems found. The script was run in a 24x80 pseudo-terminal with git 2.55.0, less 704 and gum 2.0.0, against a synthetic plugin whose upstream was one commit ahead: In the head runs, Smaller notes
Review informationTest scope: source review of AI process: Opus 5.5 Medium coordination and synthesis, Opus 5.5 Xhigh technical review and final fact check, GPT 6 Sol Xhigh search for related issues, Opus 5.5 Medium editorial check. Opt out: To stop receiving these reviews, reply to this comment saying so. |
552b1dd to
4ecd694
Compare
|
Thank you for the source trace and the matrix; both notes are fair. Premise precision. You are right, and the comment now says it: with The Overlapping PRs. Noted, thank you: #10711, #10248 and #11242 rewrite or move the same |
Automated AI review
Outcome: No defects found at Follow-up to the earlier review and reply; since Earlier notes:
DetailsPseudo-terminal runs (24x80, git 2.55.0, less 704, gum 2.0.0, At the head, answering
Review informationTest scope: Source review and sandboxed pseudo-terminal runs at AI process: Opus 5.5 Medium coordination and synthesis, Opus 5.5 Xhigh technical review and final fact check, GPT 6 Sol Xhigh search for related issues, Opus 5.5 Medium editorial check. Opt out: To stop receiving these reviews, reply to this comment saying so. |
|
Reviewed at Reproduced on an Omarchy worker (git 2.55.0, less 704, gum 2.0.0, no
A short diff with the default Suite: Scope: it's one flag, on the only path that reaches the confirmation through git's pager. The Second opinion: Codex Medium reviewed the diff and the surrounding code and found no defects. It made the prompt-ordering point above, and it noted that Waiting on the maintainer. |
Reopens #12335, which closed when I deleted my fork by accident. The same change,
--no-pageron the non-delta branch with a comment saying why, rebased on currentquattro. Tracking issue: #12332.omarchy plugin update <id>prints the diff with an unpipedgit diff, so git starts its pager whenever output goes to a terminal. With git's defaultLESS=FRX,lessquits by itself on a diff that fits the screen; a longer diff, which a plugin a few versions behind produces, or aLESSwithoutF, or a custom pager, keeps it open. Thegum confirm "Update <id>?"that follows then waits behind the pager, invisible: Enter scrolls one line insideless, so the update looks stuck with nothing to suggest a keypress is expected. Quitting withqreveals the prompt.On the
deltapath the diff is piped, which makes git skip its pager, so the prompt is already visible there.--no-pagergives the other path the same behaviour.Why this is the default path, not an edge case
git-deltais in neitherdependsnoroptdependsof theomarchypackage, whilegitis. Confirmed on 4.0.4-1.What @Lifferado found on top of it, in #12335
It is also reached through
omarchy updatewhen a user's ownpost-update.dhook callsomarchy-plugin-update(no shipped hook does at this head; #10326 would call it from attendedomarchy updateruns), so the update parks at an invisible pager.omarchy-updateholds a rootsystemd-inhibit --what=sleep:idle --mode=blockfor its duration, and closing the terminal there leaves that inhibitor behind: the machine stops suspending and idle-locking, with the cause several steps removed from an update that merely looked like it failed.Verification
Omarchy 4.0.4-1, gum 2.0.0-1,
deltanot installed, defaultcore.pager. With a throwaway plugin whose upstream is one commit ahead, run in a real terminal withGIT_PAGERset to announce itself:shellcheckis clean on the changed file.test/clihas one failure,vscode generated theme references current theme file, which fails the same way on an unpatched checkout here.bin/omarchy-plugin-addprints no diff, and the othergit logcalls inbin/run inside command substitution, where git never pages, so this remains the only place affected.Fixes #12332