Repository navigation
Conversation
Automated AI review
Verified: With One issue remains when the config file does not exist. Missing
|
config.toml |
Base | This PR |
|---|---|---|
| present, unchanged | configure opens, shell restarts | configure opens, no restart |
| present, changed | configure opens, shell restarts | configure opens, shell restarts |
| missing | configure opens, shell restarts | exits 1, configure never opens |
Rows come from sandboxed runs with a stubbed launcher that simulates configure's file changes and a stubbed shell restart.
Impact: Voxtype's config editor supports a missing file: it loads an empty document and creates config.toml on first save (src/tui/config_editor.rs, Voxtype 1.1.0). omarchy-voxtype-install normally copies a default config, but the file is absent if the user removed it, installed Voxtype another way, or set XDG_CONFIG_HOME to somewhere other than ~/.config (the installer copies into ~/.config/voxtype). In that state, clicking the Dictation indicator or running omarchy voxtype config silently does nothing, where the previous script opened the configurator.
Suggested change: Let both hashes tolerate a missing file:
before=$(sha256sum "$config_file" 2>/dev/null || true)
...
after=$(sha256sum "$config_file" 2>/dev/null || true)A diagnostic copy with this change opened the configurator in every tested case, restarted the shell when the file was created during the session, skipped the restart when it stayed missing, and matched this PR in every case with the file present.
Review information
Test scope: Source review of head 6445a89, plus sandboxed runs of the base and head scripts. One set used a stubbed launcher; another used the real launcher script and real setsid with stubs for uwsm-app, xdg-terminal-exec, the terminal, voxtype and omarchy-restart-shell. Blocking behavior of uwsm-app, systemd-run --scope, xdg-terminal-exec and foot is based on their source (uwsm 0.27.0, systemd 262, xdg-terminal-exec 0.14.3, Voxtype 1.1.0). Real Voxtype, terminals and the Omarchy shell were not run. Terminals that hand off to an existing instance and exit early were not examined.
AI process: Opus 5.5 Medium coordination and synthesis, independent Opus 5.5 Xhigh and GPT 6 Sol Xhigh technical assessments, Opus 5.5 Medium editorial check.
Opt out: To stop receiving these reviews, reply to this comment saying so.
omarchy-voxtype-config always restarted the shell after closing the configure TUI, even when nothing was edited. The restart flashes the screen black for a couple of seconds, so just checking a setting and closing produces an unnecessary black flash. Compare a sha256 of config.toml before/after and only restart when it actually changed. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
6445a89 to
fac7d84
Compare
|
Under set -e an assignment takes its command substitution's exit status, so sha256sum failing on a missing config ended the script before voxtype configure opened. Voxtype's editor handles a missing file and creates it on save, so treat a missing file as an empty hash. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reviewed at a59873d, and the fix holds: closing Pushed a59873d to your branch, fixing the problem Greptile and the earlier community review both raised: with What ran, on a disposable Omarchy worker:
Second opinion: Codex at medium effort read the change and reached the same conclusions: the problem is real, the fix is proportionate, and the launcher waits for the terminal on the default path. Its independence from this review is not guaranteed. It raised two things I did not act on:
#13807 changes the same two lines of This is now waiting on the maintainer, and on the suite failure on |
|
Closing this one; that shell restart only existed to refresh the bar's Dictation indicator, and #14552 removed the indicator. Skipping the restart when nothing changed was the right instinct, though. Thanks! |
Summary
omarchy-voxtype-configalways restarted the shell after closing the configure TUI, even when nothing was editedconfig.tomlbefore/after and only restart when it actually changedTest plan
omarchy-voxtype-config, closed without changing anything — confirmed no restart/flashomarchy-voxtype-config, changed a setting and saved — confirmed the shell still restarts