Repository navigation
Conversation
Automated AI review
Outcome: The per-attempt Verified (source):
Stated root cause is not supported by Quickshell's
|
Gate the runWake() re-arm on an actual blank so fingerprints do not restart on every pointer move or key press, and re-arm the reader when the panel set changes (onScreensChanged), which previously cleared the blank flag without ever restarting a scan. Re-arm the blank timer there too so a panel that is still dark re-blanks instead of scanning with the panels off.
The lock screen reused one PamContext for every fingerprint attempt. After a session that started and then errored mid-identification, PamContext.active stayed set, so startFingerprint() never started another scan: a single miss could disable the reader until password unlock (see the late-identify capture in the linked issue). Create a fresh PamContext per attempt via a Component factory and destroy it when the attempt finishes or errors, and suspend fingerprinting while a password prompt is in flight.
…-attempt teardown - startFingerprint() refuses while a password check is in flight, and submitPassword() sets authenticatingPassword before runWake(), so a check stops fingerprint for its full duration instead of for one event - re-arm fingerprint when a password check finishes, covering the failed-password path that runWake no longer re-arms once the display is already awake - stopFingerprintPam() aborts before destroying, and the result/error handlers return when the completing context is no longer current, so a stopped context cannot reset state or restart the retry timer - sync lock-blank-fingerprint-test.sh with the braced handler
c429101 to
91e13fa
Compare
|
Closed with evidence; see #12420 for the fix that addresses the reported symptom. |
Closed
The stock A/B capture (issue comment) refuted this PR's premise:
authenticatingclears normally under stock and the 250 ms loop re-arms correctly — the dead-reader state is daemon/driver-side (thermal gating + a genuinefprintdSIGSEGV), not a stuck flag. A per-attempt factory does not change that symptom, and the leak this branch fixed only exists because of the factory'screateObject(root)parenting.The load-bearing fix is the blank gating, kept in #12420: stop arming the reader while the display is blank so the overnight self-heating cycle that trips the thermal gate never starts. Closing this in favor of that.