Repository navigation
Conversation
Contributor
Author
|
Closing in favor of #7366, which already addresses the same reserved namespace collision when cloning plugins as the omarchy user. |
sanjyay
deleted the
fix/issue-12678-plugin-clone-namespace-collision
branch
September 21, 2026 21:00
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When running
omarchy plugin clone <plugin>as useromarchy(the default username suggested by the Omarchy installer and used across clean/test systems),omarchy-plugin-clonecomputesnew_id="${USER}.${source_id#omarchy.}", resulting inomarchy.<id>.Because
PluginRegistry.qmlunconditionally rejects third-party plugins in theomarchy.*namespace (String(tk).indexOf("omarchy.") === 0), the cloned plugin is silently ignored during plugin scan. Furthermore,omarchy-plugin-clone's discovery loop checksany(.[]; .id == $new_id), which matches the built-in first-party plugin on disk, misleadingly reporting success even though the clone never loaded.Root cause and fix
user_prefixtolocalif the username isomarchyor starts withomarchy., keeping the clone id (local.<id>) in the valid third-party namespace accepted byPluginRegistry.qml.and (.firstParty | not)) rather than inadvertently matching the built-in plugin.Fixes #12678.
Verification
Tested in a disposable OMAVM guest (Omarchy 4.0.3-1, Hyprland 0.56.2, Quickshell 0.3.1) from the clean
freshsnapshot:test/shell.d/plugin-clone-test.shasserting that cloning underUSER=omarchyassigns thelocal.prefix and enables the clone. Tested inside OMAVM: all 21 assertions passed../test/cliinside OMAVM: passed cleanly.omarchy plugin clone omarchy.clockwithUSER=omarchyinside OMAVM: verifiedlocal.clockwas generated, discovered as a third-party plugin inomarchy plugin list, enabled, and rendered on the bar.omavm shot) showinglocal.clockactive on the desktop.