Repository navigation
fix: keep keepLoaded services across _syncServices disable - #12937
chessing234 wants to merge 6 commits into
Conversation
|
One lifecycle regression remains at Explicit disable keeps the old service runningThe new guards in Source tracing and a simulation using the extracted reconciliation functions show:
Impact: The registry reports the old service disabled, but its live behavior can continue. The idle service does not gate its idle monitoring on plugin enablement. Lock cloning also preserves the built-in Suggested change: Distinguish transient configuration fallback from deliberate disable/replacement. For example, retain the last valid configuration across temporary empty/invalid reads, and defer an active locker's teardown until it can safely release the session lock. Preserve explicit disable behavior for other services and ensure a clone switch leaves only the intended handler active. Simply restoring unconditional destruction would reintroduce the locked-session failure. Verified: In the extracted-code simulation, the PR preserves the same third-party lock instance through the reported defaults-window sequence; the base destroys and recreates it. This verifies the reconciliation change, not native suspend/resume recovery. Review informationTest scope: Pinned base/head source review, extracted JavaScript reconciliation with synthetic service creation and IPC routing, and the repository plugin-contract test at both revisions. No live Quickshell/Wayland lock, authentication, or suspend/resume test was performed. Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review. Automated AI review: Astra Medium initial inspection, independent Opus 5.5 High and GPT 6 Sol Xhigh technical assessments, then Astra Medium synthesis against source and targeted evidence. |
Explicit disable and clone replacement must tear down idle and unlocked lock instances. Defer teardown only when a keepLoaded service still holds the session lock.
|
good catch. keepLoaded alone no longer keeps a disabled service alive — only while the live instance still reports |
|
disabled keeploaded services are torn down again unless the instance still reports locked, so idle/clone originals do not stick around while a held session lock is still deferred. |
Automated AI review
Follow-up at Resolved: explicit disable and clone replacement again tear down an unlocked Verified in a simulation that runs the extracted reconciliation functions of each revision, with component creation and Quickshell's IPC registry stubbed:
This verifies the reconciliation decisions, not native A disabled lock can be kept without owning the session lockThe author's claim holds while unlocked. While the screen is locked, The retention step is model-verified. The stranded-check and re-lock steps are source-traced only. The issue #11389 journal shows the same Impact: after unlocking, a second lock screen can come from a plugin the registry reports disabled, while Suggested change: in the stranded-lock check, ignore a lock already held by another instance in the same shell (for example, re-read Optional test improvement: the #11389 path (a lock clone, reconciled through Documentation: Related PR: #12260 adds Review informationTest scope: Pinned source review of this head, the previous head and the merge-base; Quickshell v0.3.1 source; an extracted-code reconciliation simulation with stubbed component creation and IPC registry; repository AI process: Opus 5.5 Medium coordination and synthesis, Opus 5.5 Xhigh technical review and final fact check, GPT 6 Sol Xhigh search for related issues, Opus 5.5 Medium editorial check. Opt out: To stop receiving these reviews, reply to this comment saying so. |
|
stranded-lock false recover still needs a secure/locked re-check before requesting a new lock. will do that next unless you want it dropped. |
|
Reviewed at The bug in #11389 is real on
One thing this pull request covers that #7572 does not: a lock clone made before the change has no The two also conflict: both edit the same lines of both drop loops and both add to The independent second opinion did not run on this one: the configured reviewer, Codex Medium, had used up today's review allowance, so the comparison above is one model's reading (Claude Opus 5.5), checked against the source at both heads. Waiting on the maintainer to choose between this and #7572. If #7572 lands, #11389 should be checked against it, since the clone in that report predates |
[Medium impact] The follow-up appears safe to merge. SummaryDisabled
The earlier test-coverage finding was withdrawn by Reviews (4) · Last reviewed commit: "test: keep a locked service through disa..." · Reviewed by Greptile |
|
Re-reviewed at What the new commit fixes. My last comment said nothing here collected a retained, disabled lock service after unlock. That no longer holds. What is still open here, checked against the source:
What this pull request does that #7572 does not. A lock clone made before #7572 is a copy of the old Which one goes forward. #7572 is older, and this one is not clearly better: each misses cases the other handles, and the gaps above are on the path that keeps the lock alive. So #7572 stays the one taken forward, and it should take the improvement above. The second opinion split on this. Codex Medium preferred this pull request, mainly because of the old-clone case. muse-wonder (pi, thinking high) preferred #7572 with this pull request's Waiting on the maintainer to choose between this and #7572. |
|
Reviewed the new head The old-clone handoff from the previous review is now implemented in #7572 at Opus 5.5 High and muse-wonder via pi (thinking high) also compared the identical code tree against #7572; both preferred its broader teardown coverage. Their agreement is not guaranteed to be independent. This was a source comparison, not a runtime verification. Classification for the new SHA is unsettled. My classification is |
a helper that always returned false still satisfied the source check.
|
Read the new head My classification is |
|
Read the new head My classification is |
Summary
_syncServices()now skipsserviceKeepLoaded()services in both the public_servicesdrop loop and theAuthServiceStorereconciliation, matchingunloadPluginServices().ext-session-lock.Closes #11389
No visible change: keepLoaded services stay registered in the background. nothing on screen is redrawn.
Test plan
bash ./test/shell.d/plugins-test.sh(contract:_syncServiceshonors keepLoaded)bash ./test/shell.d/plugin-auth-boundary-test.sh(AuthServiceStore keepLoaded guard in_syncServices)bash ./test/shell.d/runtime-smoke-test.shwhen a Wayland compositor is available (disablement keeps keepLoaded instance marker)