Repository navigation
Conversation
After prunePluginApis destroys a third-party pluginShell facade, re-inject a fresh API into keepLoaded panel/menu Loader items so apps stay searchable.
|
No actionable issue found in the source-reviewed change at Verified (source inspection): For menu plugins, the replacement facade includes the application-library API used to build app rows. This addresses the missing reinjection path described in #12944 and #12989; end-to-end menu recovery was not tested. Review informationTest scope: Source inspection only. No native startup/menu reproduction or repository test run; the added test checks code-text wiring rather than app-row behavior. Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review. Automated AI review: Astra Medium initial inspection and synthesis, independent technical reviews by Opus 5.5 High and GPT 6 Sol Xhigh, and a fresh Astra Medium editorial check. |
|
Tested in the Omarchy VM running Omarchy 4.0.4-1 with Quickshell 0.3.1 and Hyprland 0.56.2:
Everything works as expected with no issues. |
|
Reviewed this against current What I ran, on a disposable Omarchy VM with the shell loaded from each tree: a third-party
Codex Medium reviewed it as a second opinion and found why #13439 fixes it, which I then checked in the source. Before #13439 the panel delegate read its manifest through Codex also pointed out that
This now waits on the maintainer, and I'd suggest closing it as already fixed by #13439. #12944 and #12989 describe the same bug, and #13439 fixes it for both. |
Fixes #12944. Refs #12989.
What
After
prunePluginApisdestroys a third-party scopedpluginShellfacade,syncPluginApisnow re-injects a fresh API into already-loadedkeepLoadedpanel/menu Loader items (reinjectLoadedPanelShellApis), matching how_syncServicesrefreshes kept service instances.Why still needed
Cloned menus are
keepLoaded: true, soLoader.onLoadedonly runs once. A startup reconcile (or capability-profile change) can revoke the scoped facade while the Loader item survives;shell(and thereforeappLibrary) stays null and installed apps disappear from menu/search. First-partyomarchy.menuis unaffected. Adjacent #12937 covers keepLoaded services, not panels/menus.Tests
bash ./test/shell.d/cloned-menu-shell-api-test.sh(pass)bash ./test/shell.d/plugin-auth-boundary-test.sh(pass; runtime fixture skipped without Wayland)Tip:
d3cfd53b997f8bdcf776b8db68bf0d735e7a065d(upstream/quattro)