Repository navigation
Conversation
The main idle monitor stays active after the screensaver launch blip, so pointer motion never re-signals handleActiveSignal. Arm a short dismiss monitor while a screensaver window is present: ignore launch activity until it settles, then pkill the screensaver script on the next seat input so the existing closewindow path cancels the idle/lock cycle. Fixes omacom#12650
|
Verified: No actionable defect found in the tested post-settle dismissal path at The source also preserves a menu-launched screensaver's window tracking when an idle cycle starts. The intended flow is: This is a source-supported flow, not an observed desktop sequence. The one-second quiet period is a meaningful boundary: pointer motion starting before it elapses can keep resetting it. Dismissal then needs a pause followed by new input; continuous early motion does not itself cancel the pending lock. Review informationTest scope: Focused idle test, baseline/control checks and script signalling with synthetic terminal, compositor-command and animation stand-ins. The signal command used a non-login shell. Hyprland/Quickshell upstream source was inspected; installed-version compatibility, real pointer input, terminal behavior and end-to-end lock cancellation were not tested. Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review. Automated AI review: Astra Medium performed initial inspection and synthesis, with independent technical assessments by Opus 5.5 High and GPT 6 Sol Xhigh. Claims were checked against source and targeted evidence. |
|
Tested in the Omarchy VM (Omarchy 4.0.4 / Hyprland):
Works as expected! |
|
Reviewed at 71ebdbb and verified on an Omarchy VM. This fixes #12650: pointer motion now dismisses the screensaver and cancels the pending lock. What ran. On a worker built from the Omarchy ISO, running this branch's shell, with the screensaver timeout at 5s and the lock at 45s. A virtual uinput mouse moved the pointer about two seconds after the screensaver came up, with no keyboard input at all:
Second opinion. Codex Medium reviewed the same diff and raised two timing points it would want addressed before merging. Both were checked on the worker:
It also judged this the best of the open fixes for this bug, which matches our read. #8048 and #12465 bring back terminal mouse reporting, the approach reverted in d2ea6ad because it missed Bluetooth mice. #11746 uses the same second- There is nothing for the author to do. Whether the first-second quirk matters, and which of the competing pull requests to take, is the maintainer's call. |
|
Thanks for working on this. #16800, now merged, replaced the terminal screensaver with a native Wayland overlay that dismisses itself on any key, click, scroll or mouse movement, so this fix to the terminal version is no longer needed. Closing in favour of it. |
What
Pointer/touchpad motion while the screensaver is up now dismisses it and cancels the pending idle/lock cycle.
Arm a second
IdleMonitoronly while anorg.omarchy.screensaverwindow is present. It ignores the self-inflicted launch activity until it has settled for 1s, thenpkills the screensaver script on the next seat input. The existingclosewindowpath cancels the idle cycle and stops the lock timer.Also stop clearing tracked screensaver windows at idle-cycle start so a menu-launched screensaver remains dismissable.
Why
omarchy-screensaveronly exits on keyboard stdin or focus loss. The main idle monitor reportsactivefrom the launch focus blip and then stays active, so further pointer motion never reacheshandleActiveSignal. Touchpad users could not wake the screensaver, and the lock timer could still fire while they were moving the pointer.Tests
Passes: dismiss-state pins in
IdleModel.js, QML wiring fordismissMonitor/ scriptpkill, and Stay Awake toggle checks.Fixes #12650