Repository navigation
Conversation
PAM configuration only ran from the enroll-success branch, but fprintd-enroll exits non-zero when the finger already has a print (enroll-duplicate). A machine that enrolled but never got its PAM stacks written could never recover through the wizard: every re-run died at enroll before reaching setup_pam_config. Check fprintd-list up front and skip straight to verify + PAM when a print exists. Fixes omacom#13433
|
Reviewed against
Two other open pull requests fix the same issue, and both match the real Choosing among competing fixes is up to the maintainer, so this is waiting on them. I'd suggest #13542 over this PR. |
Summary
omarchy setup security fingerprintonly calledsetup_pam_config/setup_lock_fingerprint_pamfrom the enroll-success branch, andfprintd-enrollexits non-zero for a finger that already has a print (enroll-duplicate) (#13433). So a machine with a print enrolled but no PAM configuration could never recover from the wizard: every re-run died at the enroll step and exited 1 before writing anything, leaving the enrolled print unusable for sudo, polkit, and the lock screen. (omarchy-remove-security-fingerprintdoesn't runfprintd-delete, so even remove-then-setup lands back onenroll-duplicate.)The wizard now checks
fprintd-list $USERup front: a print that is already enrolled skips straight to verify + PAM setup; the fresh-enroll path is unchanged.Fixes #13433
Testing
bash -npasses; the wizard has no shell.d coverage today (it needs live fprintd/reader + writes to/etc/pam.dvia sudo).