Skip to content

Configure fingerprint PAM when prints are already enrolled - #13612

Closed
AnPod wants to merge 1 commit into
omacom:quattrofrom
AnPod:cursor/fix-fingerprint-pam-reenroll-e0d3
Closed

AnPod wants to merge 1 commit into
omacom:quattrofrom
AnPod:cursor/fix-fingerprint-pam-reenroll-e0d3

Conversation

@AnPod

@AnPod AnPod commented Sep 28, 2026

Copy link
Copy Markdown
Contributor

Fixes #13433

omarchy setup security fingerprint only wrote PAM after a successful enroll. If a print was already enrolled, fprintd-enroll failed with enroll-duplicate and exited before PAM was configured.

  • Detect existing enrollments with fprintd-list and offer to skip enroll / configure PAM
  • If enroll fails but prints remain, still verify and write PAM
  • Shell coverage for skip-enroll, enroll-duplicate, fresh enroll, and true enroll failure

Draft.

Re-running setup used to exit on enroll-duplicate before writing PAM, leaving
enrolled prints unusable for sudo/polkit/lock. Detect existing prints via
fprintd-list, offer to skip enroll, and still configure PAM when enroll fails
but prints remain.

Co-authored-by: AnPod <AnPod@users.noreply.github.com>
@cursor
cursor Bot force-pushed the cursor/fix-fingerprint-pam-reenroll-e0d3 branch from c9fa5bd to 61f7848 Compare September 29, 2026 21:10
@omarchybot omarchybot added the bug Something isn't working label Oct 1, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Reviewed against quattro at 61f7848. The diff reads correctly: fingerprints_enrolled matches the - #N: entry lines fprintd-list prints, so it finds a saved print where the base script dead-ends on enroll-duplicate, and it would fix #13433.

It is one of three open pull requests for #13433, and #13542 is the one brought forward. Both fix the bug the same way at the core (detect a saved print with fprintd-list, then verify and write PAM). #13542 does it in a single path with no prompt, and when verification fails it tells the user to run fprintd-delete $USER and start over; it has also been run on a worker with real fprintd and libfprint's virtual reader. This one adds a gum confirm step and a second fallback branch after a failed enroll, which is more to carry for the same fix, and two things in it are worth knowing:

  • Declining or cancelling the prompt at bin/omarchy-setup-security-fingerprint:115 goes on to fprintd-enroll, which deletes a print saved under the same finger name before re-enrolling it. If that enroll then fails, the user loses a working print while only trying to configure PAM.
  • After a failed verification it still suggests enrolling again (line 87). When the finger is saved under another finger name, that repeats enroll-duplicate, with no pointer to fprintd-delete.
  • The comment at lines 109–110 says remove-then-setup leaves prints behind; on quattro, omarchy-remove-security-fingerprint already deletes the user's saved prints.

#13467 does not detect a saved print at all (fprintd-list never prints has N fingerprints enrolled).

Nothing was run for this pull request: with #13542 carrying the fix, a worker run here would test a branch that is not the candidate. The comparison was read from the three diffs and the base scripts, by Claude Opus 5.5 and by Codex Medium as a second opinion, which was asked to pick between the three without being given an answer. It also chose #13542 and raised the prompt-cancel case above. It can read this session's notes, so its agreement is not a guaranteed independent check.

Waiting on the maintainer to choose between #13542 and this one.

AnPod commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

Closing in favor of my other PR #13467 for the same issue (#13433).

@AnPod AnPod closed this Oct 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

omarchy setup security fingerprint cannot configure PAM once a print is already enrolled

3 participants