Repository navigation
Conversation
…s held Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Confirming this on a second machine, and without streaming: ASUS ZenBook S UX391UA, Omarchy 4.0.4, Hyprland 0.56.2, voxtype 1.1.0 with Omarchy's default voxtype config (Whisper To check which bind options matter, I added a test key bound exactly like F9 (a press bind plus a release bind on a key name) with
The two triggers are independent, so both options are needed: |
With ignore_mods, the push-to-talk release bind matches every modifier+F9 chord, and Hyprland consumes the press of a matching release bind, so apps stopped receiving Shift+F9, Ctrl+F9 and Alt+F9 (debug, build and run in IntelliJ, among others) on any machine with voxtype. Non-consuming passes those presses through while keeping the release stop; plain F9 is still consumed by the start bind. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
|
|
Reproduced and verified on a VM built from the Omarchy ISO (Hyprland 0.56.2), with I pushed one fix, 35bb4a2. With One thing is left for the maintainer to decide. Shift/Ctrl/Alt+F9 still runs
Second opinion: Codex Medium, over two rounds. It raised the swallowed modifier+F9 chords, which I then confirmed on the worker, and the toggle-dictation side effect above. It also agreed with the cause and with each flag's role, though its independence from this review is not guaranteed. This is waiting on the maintainer. |
| o.bind("F9", "Stop dictation (push-to-talk)", "voxtype record stop", { release = true }) | ||
| -- Transparent so keys pressed while F9 is held (including voxtype streaming output) can't shadow the release | ||
| -- Non-consuming so ignore_mods doesn't swallow app shortcuts like Shift+F9 and Ctrl+F9 | ||
| o.bind("F9", "Stop dictation (push-to-talk)", "voxtype record stop", { release = true, transparent = true, ignore_mods = true, non_consuming = true }) |
There was a problem hiding this comment.
New binding flags go untested The existing binding tests record the key, description, and release setting, but discard
transparent, ignore_mods, and non_consuming. They would still pass if a flag needed to prevent stuck recording or preserve modified F9 app shortcuts were removed, leaving these changes open to a silent regression. Please assert the new options and their intended shortcut behavior.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
quattro moved the dictation bindings from voxtype.lua to dictation.lua and routed them through omarchy-dictation, so the release-bind flags move to the F9 stop bind there. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ile it's held The ALT + Alt_R push-to-talk release bind is shadowed exactly like F9's was: tapping any key while Alt_R is held drops the stop. On a Hyprland 0.56.2 worker the stop was lost 3 of 3 without transparent and fired 3 of 3 with it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This stopped merging after
I re-verified at da08ed3 on a VM built from the Omarchy ISO (Hyprland 0.56.2), with Second opinion: Codex Medium reviewed this head and found nothing to change. It agreed with the merge resolution, with the right Alt change, and that right Alt doesn't need Two things are for the maintainer. First, the question from my last comment still stands: because of |
|
Superseded by #14645, which fixes both push-to-talk keys with |
Problem
F9 push-to-talk dictation gets stuck recording if another key is pressed while F9 is held. Hold F9, tap any key, then release F9:
voxtype record stopnever runs, and recording continues until voxtype'smax_duration_secscutoff (60 s by default).With voxtype streaming enabled (
[parakeet] streaming = true), this happens on nearly every use. voxtype types text throughwtypewhile F9 is still held, and each typed key has the same effect. voxtype avoids this for its own evdev hotkey by forcing toggle mode when streaming is on, but Omarchy's F9 binding goes through Hyprland, so it just gets stuck.Cause
This is Hyprland's bind shadowing (v0.56.2,
src/managers/KeybindManager.cpp):shadowKeybinds()(L434) marks every bind whose key is still inm_pressedKeysas shadowed (L855–L898). F9 is still held, so its release bind is shadowed.handleKeybindsskips shadowed binds (L652), so the stop never fires.Change
Mark the release bind as transparent, which Hyprland never shadows. In
default/hypr/bindings/voxtype.lua:transparent = trueis the actual fix.ignore_mods = trueis optional hardening: without it, releasing F9 while Shift is down (by the user, or bywtypetyping a capital letter) fails the modifier check and the stop is skipped again.Tested on Omarchy 4.0.4, Hyprland 0.56.2 and voxtype 1.0.1 with Parakeet streaming: push-to-talk now stops reliably on release, including while text is being typed.
Related (voxtype, not Omarchy)
With streaming, words still being processed when F9 is released are dropped by voxtype itself, which discards in-flight text on stop. Reported upstream: peteonrails/voxtype#804. Locally I work around it by delaying the stop (
sh -c 'sleep 1; voxtype record stop'), but the right delay depends on hardware and model settings, so I'm not proposing it here.🤖 Generated with Claude Code