Repository navigation
Conversation
|
Thanks for this. Making the Elsewhen put best-effort in the migration (
Also, #11015, merged on 2026-10-04, fixed the bar startup stall, which was the most likely cause of these timeouts. Related open PRs: #12797 (retry on timeout) and #13468 (yours, earlier). |
|
|
Reviewed at 9fb022a by Claude Opus 5.5, with Codex Medium as the second opinion. What was checked. On a disposable Omarchy worker I froze the real running shell so that What was found. I found no defect in the change itself, and neither did Codex. The diff does more than the title says, though. The Competing fixes. Two older open pull requests fix #13301 in
Retrying is safe for this call. #12797 addresses the cause, a transient timeout treated as fatal. Elsewhen then actually gets placed, and the migration still stays pending when placement really fails. This PR completes the migration without the widget instead. Asked to choose among the three, with no answer suggested, Codex picked #12797 for that reason. I checked its reasoning against the source and agree. The one case it does not cover is a shell that times out on every attempt for the whole retry budget. With the startup stall fixed in #11015, that case should now be rare, and whether it should stop an update is the maintainer's call. This is waiting on the maintainer to choose between #12797, #13468 and this one. |
omarchy-bar put no longer aborts migration 1790042972 when the shell is unresponsive, and ask_to_put retries "not responding" like "not ready". Co-authored-by: AnPod <AnPod@users.noreply.github.com>
9fb022a to
4083550
Compare
|
Re-reviewed at 4083550 by Claude Opus 5.5, with Codex Medium as the second opinion. Nothing was run this time: both models read the new head against What changed. The What still stands. The Competing fixes. Two other open pull requests fix #13301 in
Asked to choose among the three with no answer suggested, Codex picked #13468, because #12797 still fails the update when the shell times out on every attempt. I checked that against the source and it holds. Neither of us would bring this one forward: what it does for a timeout, #13468 does without also completing the migration on a definitive failure. Whether a shell that never answers should let the migration finish without the widget, as #13468 decides, is a policy choice, and it is the maintainer's. This is waiting on the maintainer to choose between #12797 and #13468. |
|
Re-reviewed at 5e97b01 by Claude Opus 5.5, with Codex Medium as the second opinion. The new commit only merges What still stands. The Competing fixes. #12797 and #13468 are unchanged since the last review. Asked again to choose among the three, Codex picked #13468, because #12797 still fails the update when the shell times out on every attempt, while #13468 carries on in that case and keeps an This is waiting on the maintainer to choose between #12797 and #13468. |
Fixes #13301
Migration
1790042972no longer aborts the update whenomarchy-bar puttimes out.ask_to_putretries "not responding" like "not ready", and the migration treats put failure as best-effort.Draft.