Repository navigation
Conversation
|
Verified: No actionable issue found in the tested scope at Production
The added regression test passes on head and fails against baseline production code. An isolated run of the Elsewhen migration with package installation mocked likewise changes from failing on the first timed-out placement to completing on retry. Retry limit: With a continuously unresponsive synthetic Review informationTest scope: Source inspection, baseline/head command tests, and regression-test negative controls. No live desktop, actual plugin-rebuild load, or complete system update was exercised; successful IPC replies do not establish rendered widget placement. Community review: Independent automated community review, unaffiliated with the Omarchy team, intended to help prepare PRs for their review. Automated AI review: Initial Astra inspection, independent Fable 5.1 and separate Astra reviews, followed by verification of claims against targeted evidence. |
|
Reviewed at Reproduced on an Omarchy worker VM. I ran the real Retrying is safe. Competing fixes. #13468 and #13608 make the same one-line retry change. #13468 also turns an exhausted retry budget, and a shell that disappears mid-request, into a silent success. #13608 also adds No second opinion. The reviewer (Codex Medium) answered a ping, but today's review budget is spent, so only one model (Claude Opus 5.5) reviewed this. It is labelled |
|
Closing in favor of #13468, which merged today and is on You nailed the root cause here: Thanks for digging into this, @sanjyay. |
Problem
During
omarchy update(or when running migrations likemigrations/1789581661.sh), migrations callomarchy-shell shell rescanPluginsright beforeomarchy-bar put .... While the shell is rebuilding plugins and panels, IPC calls may exceedOMARCHY_SHELL_IPC_TIMEOUT(2s), causingomarchy-shellto exit with status 124 and printomarchy-shell is not responding.In
bin/omarchy-bar:ask_to_put, the retry loop checks for*"not ready"*and*"is not running"*, but falls straight through to the fatalelsebranch upon receiving"omarchy-shell is not responding". Because migrations execute underset -euo pipefail, this aborts on the very first timeout and terminates the entire system update with pending migrations stranded.Root cause and fix
Treat
*"is not responding"*as a retriable condition alongside*"not ready"*inask_to_put, recordingSHELL_ANSWERED=1soomarchy-barwaits out the busy shell during reload/rebuild rather than failing on the first timeout.Fixes #12777.
Verification
Tested in a disposable OMAVM guest (Omarchy 4.0.3-1, Hyprland 0.56.2, Quickshell 0.3.1) from the clean
freshsnapshot:busy/ timeout state intest/shell.d/bar-test.sh. Tested inside OMAVM: all 81 assertions passed../test/cliinside OMAVM: passed cleanly.test/shell.d/elsewhen-default-migration-test.shinside OMAVM: all assertions passed.omarchy-bar put omarchy.keyboard-layout --after omarchy.clock), verifying successful placement on the bar.omavm shot) verifying desktop and bar stability.