Repository navigation
Ignore static pointer position changes on lock screen wake (#13812) - #13818
szaidi-code wants to merge 1 commit into
Conversation
Independent community review
Tested: Pointer event handling in Result: The fix operates as intended without regressions:
Testing details
|
chessing234
left a comment
There was a problem hiding this comment.
please address the remaining recovery case below.
| MouseArea { | ||
| anchors.fill: parent | ||
| hoverEnabled: true | ||
| property int lastX: -1 |
There was a problem hiding this comment.
please store lastX and lastY as real: mouse event coordinates are real-valued, but these integer properties discard the fractional part. two position events at the same (10.5, 20.5) therefore still call wakeRequested() on the second event, so the static-position wake loop remains possible at fractional coordinates; please cover this case alongside integer positions.
|
Agree with Chessing234's CHANGES_REQUESTED: |
|
Reviewed against This does not stop the loop the way #13812 asks, and older open pull requests already carry this bug. On The review from @chessing234 also holds: The older open fixes for this bug are #8581, #8896, #10343, #11991 (draft) and #13129. #10343 gates the same pointer path, and it re-arms the blank instead of swallowing the event, so the returning panel goes dark again. #13129 enables amdgpu's HDMI HPD debounce, so on AMD with HDMI the output is never removed and re-added in the first place. Both are waiting on the maintainer. Where fixes are this close, the older one keeps it, and this one has no case that the older ones miss. The |
|
Thank you for this, @szaidi-code. #10343 and #13129 got there first with fixes for the lock-screen wake loop, and this one leaves the returning monitor lit, so it is closed in favour of them. Closed at the maintainer's request. The review comment above has the details; it was done by Claude Opus 5.5 with Codex Medium as a second opinion, whose agreement is not independent. |
Closes #13812
Summary
When monitors drop HDMI hotplug in standby, Hyprland and Quickshell recreate the output and the
WlSessionLockSurface. Qt Quick dispatches a syntheticonPositionChangedtoMouseAreawith the existing cursor coordinates, which was triggeringroot.wakeRequested()and waking the display in an endless 5-second cycle.Changes
shell/plugins/lock/LockView.qmlby trackinglastXandlastYto ignore static initial surface entry coordinates and require actual mouse movement or clicks to wake.test/shell.d/lock-blank-fingerprint-test.sh.