Skip to content

Add ASUS Zenbook A16 UX3607OA board support - #13820

Closed
FixItFoundry wants to merge 2 commits into
omacom:quattrofrom
FixItFoundry:feature/asus-zenbook-a16
Closed

FixItFoundry wants to merge 2 commits into
omacom:quattrofrom
FixItFoundry:feature/asus-zenbook-a16

Conversation

@FixItFoundry

@FixItFoundry FixItFoundry commented Sep 30, 2026 •

Copy link
Copy Markdown

Adds model-gated ASUS Zenbook A16 UX3607OA support using shared linux-omarchy 7.2.8-24 and omarchy-a16-support.

Setup checks the kernel DSP ABI and root command line before changing board settings, enables early DSP/audio and keyboard/display support, and removes the late-start fallback. Normal and rescue entries refresh from Limine's current default before each build, preserving factory-reset unlock settings. Required OEM firmware comes from the owner's Windows installation.

Revision 24 is built, installed, fully tested for this bring-up scope and still running on my A16. Native build, all 8,487 module checks, packaged-header compilation, source replay and both UKIs pass. Both DSPs start before root mount; the early modprobe and battery uevent errors are gone. I confirmed audio playback, keyboard, touchscreen, charger transitions, and Bluetooth calls and audio with my phone.

Publish the package prerequisites in each target channel before merging the runtime/ISO changes. Camera and sleep remain disabled; camera work is progressing separately.

@greptile-apps

greptile-apps Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 3/5

[Medium impact] The changes reach boot and early hardware setup on one Qualcomm laptop model.

The PR still needs the missing-kernel install failure and stale early-DSP settings addressed before merging.

Findings

  1. P1 Early DSP settings survive downgrade ▶
  2. P1 A16 installation aborts ▶

Summary

Adds ASUS Zenbook A16 setup for early keyboard, display, firmware, and DSP support.

  • The Zenbook A16 loads its keyboard and display support before disk unlock.
  • The A16 prepares DSP support early and keeps a rescue boot without DSP startup.

The previous reset-unlock thread was manually resolved without explanation. The current hook refreshes both boot entries from the shared command line.

Diagram

%%{init: {'theme': 'neutral'}}%%
flowchart TD
  A[Hardware setup] --> B{Matching A16?}
  B -- No --> C[Leave board settings unchanged]
  B -- Yes --> D{Required kernel and DSP ABI?}
  D -- No --> E[Stop setup]
  D -- Yes --> F[Write board settings and link DSP profile]
  F --> G[Install boot refresh hook]
  G --> H[Read shared boot command line]
  H --> I[Write normal and rescue entries]
  I --> J[Request deferred image rebuild]
Loading

Reviews (11) · Last reviewed commit: "Complete model-gated A16 early DSP setup" · Reviewed by Greptile

Comment thread install/hardware/asus/zenbook-a16.sh Resolved
@omarchybot omarchybot added bug Something isn't working compatibility Make Omarchy work better on everything! labels Oct 3, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Thanks for this. I reviewed the diff against dragon and compared it with the Yoga Slim 7x support it's modelled on. Codex Medium reviewed it separately, and I checked each of its findings against the source myself. On a disposable x86 VM, ./test/cli and the hardware shell tests (zenbook-a16, yoga-slim7x, snapdragon, t2, xps13-sidecar-amps, bluetooth and the other install/hardware tests) all pass. Those tests stub the hardware, so none of this is checked on a real Zenbook A16.

Pushed: 0c18f75 fixes the heredoc in install/hardware/asus/zenbook-a16.sh. It's quoted, so the \n went into /etc/mkinitcpio.conf.d/zenbook-a16-initramfs.conf literally and joined two comments into one line. The note about asus_glymur_ec? now also sits above the MODULES line it explains. Nothing changes at runtime.

Before this can go further, a few things need your answer:

  • cma=128M shrinks the board's CMA pool by half. The upstream device tree for this laptop (arch/arm64/boot/dts/qcom/glymur-asus-zenbook-a16-ux3607oa.dts) already reserves a 256 MiB linux,cma pool, and cma= on the command line overrides that. Unless you measured that 128M is better on this machine, dropping the parameter keeps the device tree's 256 MiB.
  • The direct limine-mkinitcpio at the end of zenbook-a16.sh repeats a build the installer already does. On dragon, the ISO's orchestrator holds back initramfs builds while omarchy-apply-system runs. Then finalize_limine_boot runs limine-update, which rebuilds every kernel with all the hardware drop-ins in place. That's why yoga-slim7x.sh, nvidia.sh and fix-t2.sh write their drop-ins without rebuilding. Here, every A16 install pays for an extra full build, and if that build fails, hardware setup stops before the scripts after it in all.sh run. If the first-boot problem you fixed in d85631f came from an ISO without that final rebuild, the call can go, along with the test that asserts it.
  • clk_ignore_unused pd_ignore_unused are already set for every Snapdragon machine by install/hardware/qualcomm/kernel-params.sh, so they don't need to be repeated here.
  • The DMI fallback omarchy-hw-match 'Zenbook A16' is a substring match, so it would also match any future Qualcomm Zenbook A16 that isn't a UX3607OA. The device-tree compatible and UX3607OA already cover this board.

For the maintainer to weigh: plymouth.enable=0 removes Omarchy's graphical LUKS prompt on this board in favour of a text prompt, and panic=10 reboots ten seconds after a kernel panic. glymur_pci_skip=5 has no handler in the upstream kernel (it doesn't appear in pcie-qcom.c), so it only does something on a kernel carrying the patch from your bring-up repo, and asus_glymur_ec is optional for the same reason. Codex also pointed out that the firmware search prefers a compressed blob in qcom/ over an uncompressed one in updates/qcom/. That ordering comes from the Yoga script, so it's not something this PR needs to fix.

Nothing here can be reproduced on a VM. This waits on your answers above, then on someone with the hardware confirming the full head SHA on a Zenbook A16.

@FixItFoundry

Copy link
Copy Markdown
Author

Thanks for the careful bring-up; the board setup reads well and the test coverage is thorough.

What we verified on this board: its device tree reserves 256 MiB via linux,cma-default at glymur-asus-zenbook-a16-ux3607oa.dts:279-284; the ISO orchestrator's finalize step runs limine-update after the hardware phase, picking up these drop-ins; and install/hardware/qualcomm/kernel-params.sh:11 already appends the ignore-unused flags. One correction: the firmware search's suffix loop sits outside the directory loop at zenbook-a16.sh:35-41, so an uncompressed copy in the base root wins over a compressed copy under updates/, and the test at lines 56-61 proves only that uncompressed updates/ beats a compressed base-root copy. That ordering is inherited from the Yoga script, so nothing changes there.

  • Drop cma=128M at zenbook-a16.sh:52; the device tree's 256 MiB reservation stands unless you measured 128 on this machine.
  • Drop the duplicate clk_ignore_unused/pd_ignore_unused pair — qualcomm/kernel-params.sh:11 already sets them for every Snapdragon machine.
  • Drop the limine-mkinitcpio call at the end of zenbook-a16.sh, with its test assertion; the orchestrator's finalize step rebuilds with these drop-ins in place.
  • Drop the broad omarchy-hw-match 'Zenbook A16' fallback at zenbook-a16.sh:17; it could catch a future non-UX3607OA model.

@omarchybot

Copy link
Copy Markdown
Collaborator

Thanks for working through those. I read e4fe087 against dragon. All four points are handled: cma=128M and the repeated clk_ignore_unused pd_ignore_unused are gone from the Limine drop-in, the limine-mkinitcpio call and its test assertion are gone, and the DMI fallback now only matches UX3607OA. You're also right about the firmware search, and my earlier note had it backwards. The suffix loop is the outer one in install/hardware/asus/zenbook-a16.sh:35-43, so an uncompressed blob in the base firmware root wins over a compressed one under updates/.

Two comments in zenbook-a16.sh no longer match the code. Line 50 still opens with "Keep display and power domains alive", but the flags that did that are no longer in this drop-in (qualcomm/kernel-params.sh sets them now). Lines 71-73 describe rebuilding the boot artifacts before the first reboot, and the code that did it has been removed. Neither affects runtime.

I only read this revision. Nothing ran on a worker, and no second model looked at it: the reviewer, Codex Medium, is reachable but omabot's review budget for today is used up. So the classification of this pull request is unsettled for now, and it gets checked again on a later pass. Whatever happens there, the board-specific behaviour can only be confirmed by someone running the full head SHA on a Zenbook A16. plymouth.enable=0, panic=10 and glymur_pci_skip=5 are still for the maintainer to decide.

@omarchybot omarchybot removed bug Something isn't working compatibility Make Omarchy work better on everything! labels Oct 9, 2026
@birkskyum
birkskyum changed the base branch from dragon to n1x October 9, 2026 22:11
@birkskyum

Copy link
Copy Markdown
Contributor

@FixItFoundry , please rebase

@ryanrhughes
ryanrhughes force-pushed the n1x branch 2 times, most recently from dcdea0b to 2f83505 Compare October 10, 2026 04:01
@birkskyum
birkskyum force-pushed the feature/asus-zenbook-a16 branch from e4fe087 to 15613fc Compare October 10, 2026 16:13
@birkskyum

Copy link
Copy Markdown
Contributor

I rebased this onto today's n1x, since the PR had been retargeted from dragon and was showing dragon's old Snapdragon commits as its own. Your ten commits are unchanged. One commit on top swaps omarchy-hw-qualcomm-soc for omarchy-hw-aarch64-qualcomm, because the old check is gone on n1x (#14834). The Zenbook test and the Snapdragon tests pass in an ARM container. Your branch was force-pushed, so reset your local copy before adding to it. The old head was e4fe087.

@birkskyum

Copy link
Copy Markdown
Contributor

@FixItFoundry thanks for the work on this. The layout fits n1x and follows the Yoga setup. Before it can merge we need to settle which kernel it is for.

Omarchy's Snapdragon image boots Arch Linux ARM's linux-aarch64, which is a 7.2 kernel today and has no device tree for the A16. The tree is in mainline from 7.3-rc1, so the stock kernel picks it up with 7.3, and qualcomm/dtb-uki.sh already includes glymur*.dtb. Two things here go beyond that. glymur_pci_skip is a local patch in your series, so a stock kernel ignores the parameter, and asus_glymur_ec is not in mainline yet.

Which kernel did the verified install run? If it was your own build, I think this waits for 7.3 in Arch Linux ARM and then a test of this head on that kernel. It would help to know what works on a plain 7.3 without your series.

A few smaller things.

  • The check reads the device tree and also matches the DMI name. n1x keeps a single model behind omarchy-hw-match, so if UX3607OA matches on your machine the device tree read can go.
  • plymouth.enable=0 turns the boot splash off for this model. Omarchy aims for the same experience on every platform, so the reason for a difference like this belongs next to the code.
  • The two comments the bot pointed at are still there, the Limine one and the one at the end about a rebuild.

I can make the smaller changes as a commit on top if that helps.

@birkskyum

birkskyum commented Oct 11, 2026 •

Copy link
Copy Markdown
Contributor

A shared helper for the model check is up as #15064. With it the device tree part of the check becomes omarchy-hw-match-device-tree asus,zenbook-a16-ux3607oa asus,ux3607oa.

@birkskyum

Copy link
Copy Markdown
Contributor

#15064 is merged, so omarchy-hw-match-device-tree is on n1x now. A rebase onto n1x picks it up.

@birkskyum

Copy link
Copy Markdown
Contributor

A heads-up so it does not trip you up. The helper was renamed after my first note, so if your mail says omarchy-hw-dt-match, the name on n1x is omarchy-hw-match-device-tree.

@omarchybot

Copy link
Copy Markdown
Collaborator

I read c2a1e31, the rebase onto n1x. Compared with e4fe087, the pull request's own files change in one place: the board check calls omarchy-hw-aarch64-qualcomm instead of omarchy-hw-qualcomm-soc, which no longer exists on n1x, and the test stubs follow. That swap is correct, and nothing else in the change moved.

One point nobody has raised yet: install/hardware/qualcomm/kernel-params.sh already passes systemd.tpm2_wait=0 to every Snapdragon machine, so systemd does not wait for a TPM that isn't there. Is systemd.mask=dev-tpm0.device systemd.mask=dev-tpmrm0.device at install/hardware/asus/zenbook-a16.sh:51 still needed on the A16 with that in place? If not, it can go, the same way the ignore-unused flags did.

The classification is unsettled. I read this as an enhancement, because it adds support for a laptop Omarchy doesn't run on today. Codex Medium, asked separately, read it as a compatibility fix. Until that's settled the pull request carries no class label, and nothing ran on a worker this pass.

This waits on you, @FixItFoundry, to answer the questions @birkskyum asked on 10 October. The main one is which kernel the verified install ran. The smaller ones are the device-tree check through omarchy-hw-match-device-tree, the reason for plymouth.enable=0 written beside the code, and the two comments that no longer match it. After that, someone with the hardware needs to test the full head SHA on a Zenbook A16.

@FixItFoundry

Copy link
Copy Markdown
Author

Thanks @birkskyum and @omarchybot. I have read through the discussion, including the 15 October review. Here is the current status before I update the PR.

The successful installation used my custom 7.3.0-rc5 A16 bring-up kernel, not a plain Arch Linux ARM kernel. That install reached the desktop but did not establish working Wi-Fi, battery reporting or audio. My working Fedora installation also uses a custom A16 kernel. Neither is evidence that stock 7.3 supports the complete machine.

Following my separate discussions with the Omarchy team, the intended direction is the shared Omarchy 7.2.10 kernel with the necessary A16 backports, using the normal kernel packaging and ISO build flow. A local candidate has been built that way. It still needs full A16 hardware validation; I am not presenting it as merge-ready or as a reason to pin users to a private kernel indefinitely.

The immediate installer blocker is reliable firmware delivery on a stock machine with a BitLocker-protected Windows partition. The earlier installer treated extraction as optional and could complete without the required firmware. The newer local preflight stops before disk cleanup when the required stage is incomplete. That explains the apparent install regression; it does not prove a firmware ABI mismatch or establish the cause of every missing device.

I also checked the bring-up repository: its live-image scripts copy a prepared Linux firmware tree into the image, rather than require extraction from Windows during installation. Its firmware documentation describes generic upstream Glymur/QCC2072 files, but the working A16 device tree requests ASUS-specific DSP files, and the local preflight additionally requires a Wi-Fi calibration file. We have not yet established that the generic upstream files are equivalent, or the original provenance of every file on the working Fedora system. I am resolving that discrepancy before choosing the permanent delivery method. We are evaluating upstream/vendor delivery and a guided, read-only recovery-key import; requiring users to turn off BitLocker is not the only option.

The smaller review points are handled in the local changes: the shared omarchy-hw-match-device-tree helper, removal of the redundant TPM masks and stale comments, and an adjacent explanation for the temporary Plymouth setting. The earlier CMA, duplicate-parameter and extra-rebuild removals are retained. These changes have not been pushed yet.

The next acceptance step is an install and boot on the complete proposed revision, checking DSP startup, battery, Wi-Fi, audio including idle recovery, and a real kernel update/rollback. I will report the exact source SHAs and results before asking for another merge review. We are still settling the firmware delivery plan.

@birkskyum
birkskyum changed the base branch from n1x to quattro October 15, 2026 13:11
@birkskyum

Copy link
Copy Markdown
Contributor

I switched the base to quattro, since n1x went into it with #14820. The PR now lists n1x's commits as well, and rebasing your commits onto quattro leaves only yours.

@FixItFoundry
FixItFoundry force-pushed the feature/asus-zenbook-a16 branch from c2a1e31 to a34db8a Compare October 16, 2026 15:16
Comment thread install/hardware/asus/zenbook-a16.sh Resolved
Comment thread install/hardware/asus/zenbook-a16.sh Resolved
Comment thread install/hardware/asus/zenbook-a16.sh Outdated
Comment on lines +77 to +82
if [[ -n $a16_kernel ]]; then
source "$OMARCHY_INSTALL/hardware/asus/zenbook-a16-early-dsp.sh" || return 1
else
# Start the board's DSP remote processors.
mkdir -p "$systemd_dir"
cat >"$systemd_dir/zenbook-a16-remoteprocs.service" <<'UNIT'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Early DSP settings survive downgrade

If an A16 previously configured for the audited kernel later loses that kernel or its DSP ABI, setup takes this late-start branch without removing the early initramfs profile or boot-entry drop-in. A subsequent boot-image rebuild can still use the early DSP settings with a kernel that failed the capability check, defeating the separation between the two startup paths.

Knowledge Base Used: Install stages and package sets

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The late-start fallback is removed. Failed package/ABI checks stop setup before it changes the boot configuration. The initramfs profile and build hook also reject an incompatible kernel, and pacman enforces the ABI dependency. An existing profile link cannot bypass those checks. Forced dependency removal is not a supported downgrade path.

@greptile-apps

greptile-apps Bot commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

Want your agent to iterate on Greptile's feedback? Try greploops.

@FixItFoundry
FixItFoundry force-pushed the feature/asus-zenbook-a16 branch from a34db8a to 7164dbe Compare October 16, 2026 15:41
@FixItFoundry

Copy link
Copy Markdown
Author

Thanks for the review.

The unified ISO selects linux-omarchy, and omarchy-a16-support requires its DSP ABI. The kernel selection comes from the installer rather than the runtime package list.

I've removed the late-start fallback and its unused helper. A16 setup now stops before changing configuration if the required kernel capability or support profile is missing, preserving the existing DSP guard and boot settings.

Sleep now uses omarchy-sleep-disabled.conf, so the menu, suspend toggle and hibernation setup recognize the restriction. Setup also removes the old A16 sleep filename.

The ISO already rebuilds the boot images after hardware setup. Focused regression tests pass; fresh-install and hardware upgrade/rollback validation of the complete revision remain pending.

Comment on lines +29 to +31
if [[ -z $a16_kernel ]]; then
echo "A16 setup requires linux-omarchy with DSP ABI 1 and omarchy-a16-support; refusing unsafe late DSP startup." >&2
return 1

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 A16 installation aborts

On a normal Zenbook A16 install, the Qualcomm package set supplies omarchy-a16-support but not linux-omarchy. This new check therefore returns 1 before applying the board settings. The failure aborts the system hardware stage; on an image install, the deferred step stays queued and fails again on the next run.

Knowledge Base Used: Install stages and package sets

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. The runtime/ISO changes stay blocked on package publication. The proposed support package pulls in a shared kernel providing omarchy-a16-dsp-abi=1 and its release metadata. The private firmware-package dependency is removed. The replacement package set has passed build, boot and hardware validation on my A16 with revision 24.

@birkskyum

Copy link
Copy Markdown
Contributor

Thanks @FixItFoundry. Two things block this on quattro today, apart from the hardware validation.

omarchy-a16-support and asus-zenbook-a16-firmware are added to install/omarchy-aarch64-qualcomm.packages, which every Snapdragon laptop installs, and neither is in the edge aarch64 repository or has a recipe in omarchy-pkgs. The aarch64 ISO puts every platform's list into its offline mirror and stops when one is missing, so with this merged the image stops building for every board. The recipes go to omarchy-pkgs first, and the list entries follow once edge carries them.

The A16 step reads /usr/share/doc/linux-omarchy/kernel-release and /usr/lib/modules/<release>/omarchy-a16-dsp-abi, and the published linux-omarchy ships neither, so on the published kernel it refuses and returns 1. That marker has to come with the 7.2.10 kernel change in omarchy-pkgs.

@omarchybot

Copy link
Copy Markdown
Collaborator

I read 7164dbe against quattro. Codex Medium reviewed the same revision separately, and I checked each of its points against the source. Nothing ran on a worker: the board-specific paths only do something on a Zenbook A16.

I can confirm both blockers @birkskyum raised on 16 October:

  • omarchy-a16-support and asus-zenbook-a16-firmware have no recipe in omarchy-pkgs. install/omarchy-aarch64-qualcomm.packages goes to every Snapdragon machine through omarchy-pkg-defaults, with no model filter, so until those packages are published, anything that installs that list fails on every Snapdragon board, not only the A16.
  • The published linux-omarchy-aarch64 (7.2.8) ships neither /usr/share/doc/linux-omarchy/kernel-release nor omarchy-a16-dsp-abi. With that kernel, install/hardware/asus/zenbook-a16.sh:30 returns 1, and run_logged passes that failure on. A direct install stops hardware setup there. On an image install, provisioning stops with that step still queued and retries it on every run.

One smaller point that nobody has raised: zenbook-a16-early-dsp.sh writes KERNEL_CMDLINE[linux-omarchy] and KERNEL_CMDLINE[fallback] in full, and its own comment says a per-kernel line replaces the default. So the KERNEL_CMDLINE[default]+= in zenbook-a16.conf never reaches either A16 entry. The A16 entries still get those parameters, because the per-kernel lines repeat them. The default line only affects another kernel installed beside linux-omarchy, so the drop-in, and its comment about the TPM wait, can go. The Snapdragon-wide parameters from qualcomm/kernel-params.sh all appear in a16_common_params, so nothing is lost there.

Codex also suggested that the step reads the root command line from the wrong file. That is not the case. The installer writes /etc/kernel/cmdline, and install/hardware/n1x.sh reads it the same way.

The classification is still unsettled. I read this as an enhancement, because it adds support for a laptop Omarchy does not run on today. Codex Medium, asked separately, read it as a compatibility fix. Until that is settled, the pull request carries no class label.

This waits on you, @FixItFoundry. The package recipes and the kernel marker need to land in omarchy-pkgs first, and then the hardware validation you described on the 15th needs to run on this head.

@FixItFoundry
FixItFoundry force-pushed the feature/asus-zenbook-a16 branch from 7164dbe to 937b15e Compare October 18, 2026 18:26
@FixItFoundry

Copy link
Copy Markdown
Author

Thanks @birkskyum and @omarchybot. I agree the package recipes and kernel capability need to land in omarchy-pkgs and reach edge before the runtime and ISO changes merge.

The revised proposal follows Omarchy's shared 7.2.8 base. I built and installed 7.2.8-16 with support 20261014-12 on the A16. The package update rebuilt and verified both normal and rescue boot images. A normal-entry boot now passes, with audio playback, the built-in keyboard, touchpad and battery indicator working. Wi-Fi is connected, and both DSPs run.

Revision 16 adds the upstream block-mq fix already in 7.2.10. Our source-level check reproduces missing scheduler initialization without it and passes with it. The fix addresses a known Kyber queue-stall bug. Whether it explains the A16 freezes is still a working theory; long-term stability hasn't been validated. Additionally, my test environment runs off a USB-C SSD, so I suspect the stability issues might be related to that.

The local runtime follow-up removes the redundant default Limine drop-in and explains the temporary Plymouth setting beside the code. The model/kernel capability checks remain in place, and sleep is still disabled. Next step would be to work on sleep/suspend.

I noted a possible charging regression in this Omarchy build that I didn't see in my Fedora project. Our existing charger-notification patch also overlaps omacom/omarchy-pkgs#1030 and needs coordination.

@omarchybot

Copy link
Copy Markdown
Collaborator

I read 937b15e, the rebase onto quattro. Codex Medium reviewed the same revision separately, and I checked its points against the source. Nothing ran on a worker: the board-specific paths only do something on a Zenbook A16.

Against 7164dbe, the pull request's own files change in two places, and both are correct. install/hardware/asus/zenbook-a16.sh now removes the old zenbook-a16.conf drop-in instead of writing KERNEL_CMDLINE[default]+=. Its four parameters (console=tty0, plymouth.enable=0, systemd.show_status=true, vt.global_cursor_default=1) are all still on both A16 entries through zenbook-a16-early-dsp.sh. The reason for plymouth.enable=0 now sits beside it. The tests match the code.

Both blockers from 16 October still stand. omacom/omarchy-pkgs has no recipe for omarchy-a16-support or asus-zenbook-a16-firmware, and its linux-omarchy-aarch64 (7.2.8-13) ships neither /usr/share/doc/linux-omarchy/kernel-release nor omarchy-a16-dsp-abi. With this merged before those land, every Snapdragon install and omarchy-reinstall-pkgs asks pacman for two packages that don't exist, and on an A16 zenbook-a16.sh:30 returns 1. You've already said the packages and the kernel marker go first, so this is only a record that nothing has changed there.

Codex found one smaller point, and I confirmed it. zenbook-a16-early-dsp.sh:4-8 refuses a /etc/kernel/cmdline with no root=, but it runs after zenbook-a16.sh:35-75 has already written the sleep, modules-load and initramfs files and removed the old Limine drop-in. A refusal there leaves the board half configured. The installer always writes root= first, as install/hardware/n1x.sh:107 relies on, so this only matters on a broken install. Reading the command line before the first write, next to the kernel check, would make every refusal leave the system untouched, the way the kernel check's test already expects.

The classification is still unsettled. I read this as an enhancement, because it adds support for a laptop Omarchy does not run on today. Codex Medium, asked separately, read it as a compatibility fix. Until that is settled, the pull request carries no class label.

This waits on you, @FixItFoundry: the package recipes and the kernel marker in omarchy-pkgs, then the hardware validation of this head on a Zenbook A16.

@FixItFoundry

Copy link
Copy Markdown
Author

The follow-up targets linux-omarchy 7.2.8-24. After testing and debugging, I rebuilt it, installed it and completed hardware validation on my A16. It's still running. Audio playback, keyboard, touchscreen, charger transitions, and Bluetooth calls and audio with my phone passed. Both DSPs start before root mount, and the early modprobe and battery uevent errors are gone.

The update removes the private firmware-package dependency, checks prerequisites before changing board settings, and refreshes normal/rescue command lines from Limine before each build. Packages still need to publish before the runtime/ISO changes merge.

The known PMIC supplier-link warnings remain. Camera and sleep are disabled, but we have a potential path forward for camera.

@omarchybot

Copy link
Copy Markdown
Collaborator

I read b86c35c against quattro, comparing it with 937b15e from my last pass. Nothing ran on a worker: the board-specific paths only do something on a Zenbook A16.

Against 937b15e, this PR's own files changed in three ways, and all three hold up:

  • install/hardware/asus/zenbook-a16.sh:34-38 now reads the root command line before writing anything. A refusal there leaves the system untouched, which settles the half-configured case I raised on 18 October.
  • The Limine command lines are now written by a boot hook, /etc/boot/hooks/pre.d/20-zenbook-a16-cmdline, from limine-entry-tool --get-cmdline default, so both A16 entries are rebuilt from the current default before every image build. The file is written to a temporary name and then moved into place, so a failed run never leaves a partial config.
  • asus-zenbook-a16-firmware is gone from install/omarchy-aarch64-qualcomm.packages.

On the package blockers: the kernel marker the A16 step reads (/usr/share/doc/linux-omarchy/kernel-release and omarchy-a16-dsp-abi) is now proposed in omacom/omarchy-pkgs#1426, which is still open. omarchy-a16-support is still in the Snapdragon package list, and neither omarchy-pkgs nor an open pull request there has a recipe for it. Until it is published, every Snapdragon install that reads that list asks pacman for a package that doesn't exist, not only the A16.

The classification is still unsettled at this head. I read this as an enhancement, because it adds support for a laptop Omarchy doesn't run on today. Codex Medium, asked separately, read it as a compatibility fix. Codex was asked only for the classification this pass and did not review the code, so the pull request carries no class label for now.

This waits on the maintainer to settle the classification, and on omarchy-a16-support and omacom/omarchy-pkgs#1426 reaching edge before this can merge.

@FixItFoundry

Copy link
Copy Markdown
Author

Closing this older 7.2.8-based proposal in favor of the current A16 setup in #17083 and omacom/omarchy-pkgs#1875. This branch depends on the earlier support-package/DSP-ABI design. The 7.2.8-24 test results remain historical; they do not validate the new 7.3 changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants