Repository navigation
Find the bar's monitor through the live monitor list - #14162
Rishab-Agrawal wants to merge 1 commit into
Conversation
[Medium impact] This PR appears safe to merge; no actionable issues were found in the monitor lookup change. SummaryUpdates
The earlier, unnumbered test suggestion is resolved. The current tests check fullscreen behavior in Reviews (4) · Last reviewed commit: "Find the bar's monitor through the live ..." · Reviewed by Greptile |
|
Not reviewed yet. The second opinion (Codex Medium) is needed to settle what this pull request is, and it is over today's review limit, so it never ran. Without it this gets no label, no worker run and no verdict. It goes round again once reviews are available. What I did check, by reading only: Nothing was run, and this is waiting on the second opinion. |
|
I hit this on an M2 Max (Hyprland 0.56.2, dwindle, bar on top): in fullscreen, clicking where the bar sits opened the audio, display and battery panels. It isn't only a remap. I watched each layer's I ran this branch, merged with current quattro, as my live shell. Under fullscreen the bar moved to the bottom layer. After a notification came and went, clicks along the top, over the bar's icons and along the dock all went to the window. The bar worked again once fullscreen ended. It needs a rebase: against current quattro it conflicts only in |
|
@scottjones, thanks for testing the notification-remap path. That live result covers the compositor behavior the source-level test and Greptile review could not: the bar stays below fullscreen after the notification layer remaps, clicks reach the window, and the bar recovers when fullscreen ends. I linked this result back to #14079. The branch still needs its |
aa0cb24 to
7ec3b2d
Compare
|
Rebased onto current @scottjones, thanks for running it live and for finding the notification path. I've added both to the description and the code comment. |
|
@Rishab-Agrawal, thanks for rebasing this and removing the stale source-text assertion. The conflict is resolved. One concrete worker finding from #10323 still applies to this head: |
|
Switched the lookup to |
|
@Rishab-Agrawal, thanks. I checked |
|
Reviewed 1. Merged into current 2. After leaving fullscreen, the bar doesn't come back. On a single monitor I opened a terminal, pressed fullscreen and pressed it again. On this head (and on a port that resolves the duplicate property), The second opinion found the mechanism, and it matches what the worker showed. Quickshell sends What still stands on So the part of this PR that Both models on the second-opinion panel, Codex Medium and muse-wonder via pi at high thinking, reached the same two blockers. Their independence isn't guaranteed, because they could read the worker notes from this review. The Quickshell and Hyprland mechanism above came from them. They also corrected one of my hypotheses: bar tooltips don't sink with the bar, because Hyprland draws layer popups after windows. Nothing was pushed to the branch. This is waiting on @Rishab-Agrawal. |
a1f852f to
74afc40
Compare
|
Thanks for the review. I've dropped the layer move, since #16991 already covers #14079 and the bottom-layer bar didn't come back on 0.57.0. The branch is now one change on current |
|
@Rishab-Agrawal, thanks for narrowing this to the part that still applies. I checked |
|
Re-reviewed Reproduction. I fullscreened a terminal and mirrored a second output onto that display, then un-mirrored it. After doing that twice, I moved the fullscreen workspace onto the second output and clicked where the clock sits. On Nothing else moved. On a single monitor, a fullscreen window still keeps the bar from taking clicks, a maximized window still leaves the bar clickable, and the bar comes back once fullscreen ends. All of About #10323's drawing half. In these runs the bar was never drawn over the terminal before the click, on either branch. On Overlap. #18381 and #19037 both move this same The second opinion came from Codex Medium and muse-wonder via pi at high thinking, and neither found a defect. Both judged the change proportionate and the binding reactive to an output being removed and added back, through Nothing was pushed to the branch. The |





Follow-up to #16991, for the un-mirroring path in #10323.
Problem
#16991 drops the bar's input while the active workspace on its screen has a real fullscreen window. It finds that screen's monitor with
Hyprland.monitorFor(screen), which is a one-off call. Un-mirroring removes the output and adds it back as a new monitor object, and the binding keeps reading the old one. On the omarchybot worker (Hyprland 0.57.0), fullscreening a terminal, mirroring and un-mirroring a second output, and moving the workspace onto it left the bar taking clicks there: clicking where the clock sits opened the calendar over the fullscreen terminal.Fix
underFullscreenfinds the monitor inHyprland.monitors.valuesbyscreen.name, the same live lookupOverlayWindowuses, so it follows the replacement monitor. Everything else in #16991 stays as it is, including the mode-bit-2 check, so maximized windows keep a working bar.What changed in this PR
This PR first moved the bar to the bottom layer under fullscreen. #16991 has since fixed the click problem in #14079 another way, and the omarchybot review on Hyprland 0.57.0 found that the layer move left the bar missing after fullscreen ended. So that change is gone, and this PR is now only the lookup.
#10323 should stay open after this. In the worker run the bar also drew over the fullscreen window after un-mirroring, and this change only stops it taking the clicks there.
Testing
bash test/shell.d/bar-test.shgives the same results with and without the change.