Repository navigation
Conversation
Since the screensaver moved to a special workspace, the bar stays drawn across it: Hyprland hides top-layer surfaces only behind fullscreen windows on regular workspaces. The bar now reads the idle service's screensaver window count and drops to the bottom layer while a screensaver is up, so the fullscreen screensaver covers it; its exclusive zone is unchanged, so no window reflows. Fixes omacom#13700 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Tested on real hardware: Framework 13 (Ryzen AI 9 HX 370) with a 4K external display (DP-8), omarchy-dev 4.0.0.r6720, Hyprland 0.56.2, foot.
On the display, the bar is covered while the screensaver is up and draws normally after it closes. #14334 looks like a duplicate of #13700. |
|
Thanks @ssandys. Your Framework 13 and external-display run confirms the layer transition on real hardware and, more importantly, that the screensaver fully covers the bar and the bar returns normally after close. I folded that proof into the PR body. |
The bar now steps below the screensaver by the idle service's window count, but starting or cancelling an idle cycle zeroed that count while the windows stayed up. A force-launched screensaver left until the idle timeout put the bar back on top of it, since the launcher refuses to open a second one and nothing counted the first again; turning on Stay Awake over a screensaver did the same. Only the lock closes the windows, so only the lock forgets them. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
|
Reviewed on an Omarchy ISO worker (Hyprland 0.56.2, a virtual display plus a headless second output), with the shell running from this branch, and read by Claude Opus 5.5 and by Codex Medium as a second opinion, over two rounds. What ran. I read the layer of What I found and fixed (pushed as fa0c9fc). Not addressed. The count is built only from Overlap. #14162 (bar below fullscreen windows) edits the same Waiting on the reporter. @ssandys, you opened #13700 and tested an earlier head of this branch. The head has moved, so could you confirm on the same Framework and external display that the screensaver still fully covers the bar and that the bar comes back after it closes, at git clone https://github.com/manuaudio/omarchy.git ~/omarchy-13776
git -C ~/omarchy-13776 checkout fa0c9fcf8235ef4e463e66ee04c4e5dc75da3f98
omarchy dev link ~/omarchy-13776 # reboot when asked; `omarchy dev unlink` restores the package installIf it's convenient, also try |
[Medium impact] The latest changes appear safe to merge; no new blocking issue was found. SummaryThe bar moves below an open screensaver without unmapping or changing its reserved space.
All three previous, unnumbered findings are addressed: cloned bars receive the count, startup reads existing windows, and the source-text assertions were removed. manuaudio explicitly deferred the narrow stale-reply startup race and delayed-class case because a small fix was not available. Reviews (10) · Last reviewed commit: "Normalize screensaver window addresses" · Reviewed by Greptile |
The bar steps below the screensaver by the idle service's screensaver window count, but a cloned bar is not first-party and reaches that service through the narrow proxy, which had no such property. The comparison read undefined, so after `omarchy plugin clone omarchy.bar` the bar stayed drawn over the screensaver. The proxy now carries the count, bound to the live service like its other read-only state. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Re-reviewed after Greptile's comment on the cloned bar. Claude Opus 5.5 reviewed it, Codex Medium gave a second opinion, and the tests ran on an Omarchy ISO worker (Hyprland 0.56.2) with the shell running from this branch. Greptile's finding holds, and is fixed in 3efd4f6. A bar made with What ran. On the worker I cloned the bar and read Second opinion. Codex Medium traced the same path and agreed with the finding and the fix. It wrote its answer after mine, so its agreement is not guaranteed to be independent. It found nothing new: the one gap it raised is the limitation already noted here, that the count is rebuilt only from window events, so if the idle service restarts while a screensaver is up, the bar sits above that screensaver until it closes. Overlap. #14162 is still open and edits the same Waiting on the reporter. @ssandys, the head has moved again. When you have a moment, could you repeat your Framework and external-display check at git -C ~/omarchy-13776 fetch origin && git -C ~/omarchy-13776 checkout 3efd4f6a2f2800b66622d4c361f5f8cc9f6b4ad4
omarchy dev link ~/omarchy-13776 # reboot when asked; `omarchy dev unlink` restores the package installIf you don't have that clone yet, start with |
|
Verified at 3efd4f6, merged into current What ran. Reading Second opinion. Codex Medium checked that Next. This is reproduced on a worker, so it no longer waits on a hardware retest; @ssandys, a run at 3efd4f6 is still welcome but not needed. It is waiting on the maintainer. #14162 still edits the same |
quattro now checks that the IPC toggle cycles the bar background; keep that assertion beside this branch's screensaver one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This stopped merging cleanly after What ran. On a fresh Omarchy ISO worker, with the shell linked to each tree, I read Review. Claude Opus 5.5 reviewed the merge, including what Next. The branch is verified again at 8c99515. Before it can be marked ready, it needs a second opinion on this head. After that it waits on the maintainer. #14162 is still open and changes the same |
Quickshell inserts a new toplevel before Hyprland reports its class, so a model change in that gap listed a screensaver the openwindow event had already counted as not a screensaver, and the sync closed it. The count dropped to zero with the screensaver still up, putting the bar back on top of it and, during an idle cycle, cancelling the pending lock as if the screensaver had been dismissed. Sync now only adds windows it can classify; closing stays with closewindow events, which name the window that actually closed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
Quickshell rebuilds its toplevels from a clients reply at startup and on a config reload, and a reply sent just before a screensaver closes can arrive after its closewindow event, recreating the window in the model. The sync then counted a screensaver that no longer existed, and with no further close event coming the bar stayed on the bottom layer, and the next dismissed screensaver could leave the lock timer armed. The service now remembers screensavers closewindow closed and the sync skips them, until Hyprland opens a window at that address again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
The lock resets the screensaver count and then closes the screensavers, so their closewindow events found nothing counted and left no mark, and a clients reply sent before the close could still revive one as a ghost count, leaving the bar below the layer after unlock. Marking every closewindow address covers it; the map holds one address per window closed in the shell's lifetime and drops it when Hyprland opens a window there again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
|
Re-reviewed after 904cbf3, which seeds the screensaver count from Hyprland's toplevels so a shell restart no longer puts the bar back on top of an open screensaver. Claude Opus 5.5 reviewed it and Codex Medium gave a second opinion over four rounds. Everything ran on a fresh Omarchy ISO worker (Quickshell 0.3.1) with the shell linked to this branch merged into current The restart fix works. With a screensaver up, six The new sync could lose or invent a count, so I pushed three fixes to your branch:
Still open. If the screensaver closes in the moment the shell is restarting, a ghost count can remain: 2 of 20 rounds in a probe built to hit that moment. My reading, which Codex shares from Quickshell's source: the close lands before the new shell is listening for events, while its first clients reply, sent before the close, still lists the window. The bar then stays on the bottom layer until the next shell restart. Codex also points out a second gap it found in the source but I did not reproduce: if a window's class arrives without the toplevel list changing, the startup sync never sees it. Neither has a small fix. Codex's suggestion is to track screensavers through Next. This waits on the maintainer: accept the restart fix with that rarer startup case noted, or ask for the |
|
Another real-hardware reproduction of #13700 / #14334, from before this PR: Dell XPS 15 9510 (Intel iGPU), Omarchy 4.5.0rc1-1, Hyprland 0.56.2, foot, one 3440x1440 DP external as the only active output (laptop panel disabled).
One extra data point: it is intermittent here. In a second run with nothing changed, the capture showed no bar. That fits the "Hyprland hides top-layer surfaces behind fullscreen windows on regular workspaces, but not on special workspaces" explanation, and it may be why the VM run above could not reproduce the visible symptom. I have not tested this PR's branch. As a local workaround I hide the bar via the |
|
Thanks @tuthan. Your Dell and ultrawide reproduction adds a second real-hardware case and confirms the pre-fix state: the screensaver is on its special workspace while |
|
I merged current A fresh Codex review then found one remaining startup gap: Hyprland can add a toplevel before filling The new regression failed before |
|
The final review caught a second startup bug: Hyprland snapshots use |
|
Current Rebasing this branch would restore obsolete tracking and conflict with the new design. I am closing it as superseded by #16800 rather than carrying a second fix. The hardware reproduction and race regressions remain useful history, but nothing from this branch should land on current |
Fixes #13700 and #14334.
Since bf44355 moved the screensaver to a special workspace, the top-layer bar can remain above it. Hyprland hides top-layer surfaces behind fullscreen windows on regular workspaces, but not on special workspaces.
I made
Bar.qmlmove fromWlrLayer.ToptoWlrLayer.Bottomwhile the idle service reports an open screensaver. The bar stays mapped, so its exclusive zone does not change and regular windows do not reflow. Cloned bars receive the same count through the existing narrow first-party service proxy.The idle service keeps counting a force-launched screensaver across idle-cycle changes and seeds the count from Hyprland's toplevels when the shell starts. Snapshots only add windows; normal open and close events remain authoritative for removal. Remembering closed addresses prevents a stale clients reply from reviving a closed screensaver.
The focused
idle-test.shrestart regression failed before the startup sync and passes on this head. The added race regressions each failed before their corresponding fix.idle-test.sh,bar-test.sh, the JavaScript syntax check,git diff --check, and a clean merge-tree check against currentupstream/quattropass. On a fresh ISO worker, six shell restarts with a screensaver open restored the count to 1 and kept the bar at layer 1; reverting the startup sync restored the failure.Real-hardware reports cover both sides of the change. A Framework 13 with a 4K external display confirmed that an earlier branch head lowered the bar while the screensaver was open and restored it afterward. A Dell XPS 15 with an ultrawide external display reproduced the pre-fix bar at the top layer over the special-workspace screensaver.
One narrower startup race remains. If the screensaver closes while the shell is restarting, a clients reply sent before the close can leave a ghost count. A probe designed to hit that timing reproduced it in 2 of 20 rounds. The idle service now follows delayed toplevel class metadata, but it cannot observe a close event that occurs while no shell is listening; closing that gap likely requires the larger
Quickshell.Wayland.ToplevelManagerredesign.This does not change notification popups, which #9629 covers. #14162 edits the same layer binding, so whichever PR lands second must preserve both conditions.
Fixes #14334