Skip to content

Drop every voxtype package when removing dictation - #14451

Open
Elshayib wants to merge 1 commit into
omacom:quattrofrom
Elshayib:fix-voxtype-command-check
Open

Elshayib wants to merge 1 commit into
omacom:quattrofrom
Elshayib:fix-voxtype-command-check

Conversation

@Elshayib

@Elshayib Elshayib commented Oct 7, 2026 •

Copy link
Copy Markdown

Drop every voxtype package when removing dictation

What: omarchy-remove-dictation-voxtype drops voxtype-bin, voxtype-bin-rc, and voxtype instead of only voxtype-bin.

Why: Fixes leftover AUR voxtype / voxtype-bin-rc installs after Remove. Still needed after #14552; upstream quattro still only drops voxtype-bin.

How: One-line change to omarchy-pkg-drop voxtype-bin voxtype-bin-rc voxtype. Drop ignores names that are not installed.

@greptile-apps

greptile-apps Bot commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 5/5

[Medium impact] The package-removal change appears safe to merge.

Summary

Updates omarchy-remove-dictation-voxtype to remove voxtype-bin, voxtype-bin-rc, or voxtype, whichever is installed.

  • Missing packages are ignored by omarchy-pkg-drop.
  • No new actionable issues found.

Reviews (4) · Last reviewed commit: "Drop every voxtype package when removing..." · Reviewed by Greptile

@jandrusk

jandrusk commented Oct 8, 2026

Copy link
Copy Markdown

Nice cleanup for #11749. Heads-up: #14552 ("Add selectable Voxtype and Superwhisper dictation") rewrites the same scripts and menu entries. It removes install.ai.dictation and replaces the voxtype bindings, but it leaves omarchy-pkg-drop voxtype-bin unchanged in omarchy-voxtype-remove. So the two will conflict. The easiest path is probably to rebase just the remove fix (dropping voxtype-bin voxtype-bin-rc voxtype) and the command-based guard onto #14552 once it lands.

Comment thread test/shell.d/voxtype-install-test.sh Resolved
omarchy-remove-dictation-voxtype still only drops voxtype-bin, so AUR
voxtype and voxtype-bin-rc installs are left behind after Remove.
@Elshayib
Elshayib force-pushed the fix-voxtype-command-check branch from c81fa0b to 059da80 Compare October 11, 2026 07:53
@Elshayib Elshayib changed the title Detect Dictation by the voxtype command, not the voxtype-bin package Drop every voxtype package when removing dictation Oct 12, 2026
@omarchybot omarchybot added bug Something isn't working verified Omarchy Triage has verified that this issue is ready for final review ready Good to merge labels Oct 16, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Reviewed at 059da80, nothing found. The bug is real: omarchy-remove-dictation-voxtype goes ahead whenever any package provides the voxtype command, disables the service and deletes the config and models, but only ever dropped voxtype-bin, so an AUR voxtype or voxtype-bin-rc stayed installed.

Reproduced on an Omarchy ISO worker with stand-in voxtype and voxtype-bin-rc packages that each ship the command: the script as it is on quattro leaves either package installed, and this branch removes it. voxtype-bin from the omarchy repository is still removed. ./test/cli, test/shell.d/dictation-test.sh and test/shell.d/voxtype-install-test.sh pass on the worker. omarchy-pkg-drop drops only the names that are installed, so passing all three is safe.

Codex Medium reviewed it separately and found no defects. Independence is not guaranteed. It also pointed out that the Remove > Dictation menu entries still check for the voxtype-bin package, so someone with only the AUR package has to run the command directly to reach this fix. That and the installer checks are the rest of #11749, which this pull request does not close.

This is waiting on the maintainer.

@Elshayib

Copy link
Copy Markdown
Author

Thanks — closing the loop on this. #14552 merged as c248890 on 8 Oct, and this branch carries a single commit (059da80, 11 Oct) built against the merged result, so the conflict didn't materialize.

Concretely: the script is now bin/omarchy-remove-dictation-voxtype (the old bin/omarchy-voxtype-remove no longer exists), and the only change this PR carries against current quattro is one line in it:

-  omarchy-pkg-drop voxtype-bin
+  omarchy-pkg-drop voxtype-bin voxtype-bin-rc voxtype

You were right that #14552 left that drop list untouched. The command-based guard (if omarchy-cmd-present voxtype) is already upstream from that PR, so there was nothing to re-add. GitHub reports the PR MERGEABLE/CLEAN against quattro and a local merge-tree is clean, so no rebase or merge was needed — head commit 059da80 is unchanged and already pushed.

omarchy-pkg-drop only removes names that are actually installed, so listing all three is a no-op when just one is present. Verified against stubs that the script now passes all three names and still clears the selection. I'm keeping this PR scoped to the package drop and leaving the menu/installer checks to #11749.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working ready Good to merge verified Omarchy Triage has verified that this issue is ready for final review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants