Repository navigation
Conversation
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A backend with native dictation shortcuts needs to remove Omarchy's matching bindings to avoid triggering both handlers. Extract the
dictation_keysportion of #14620 into a small, generic integration contract.Populate
o.dictation_keysfrom the actual binding calls, with one entry per chord for both press and release. Reset ownership on every configuration load, including when default bindings are disabled. The registry is empty without a selected backend. Backend integrations can check the registry and callhl.unbind(keys)once before registering their own shortcut. Document the contract, including disabled default bindings and personal overrides.Validation: dictation, Hyprland default configuration, and binding conflict tests pass. Verified in the running compositor that one
hl.unbind("F9")removes both F9 bindings without config errors; restored the original configuration afterwards.Claude review identified stale ownership when disabling default bindings; fixed with a regression test that seeds previous ownership. Confirmed that removing the reset makes the test fail.