Skip to content

Install intel-media-driver for GPUs pci.ids names "[Intel Graphics]" - #15094

Closed
omarchybot wants to merge 1 commit into
quattrofrom
fix/issue-11958
Closed

omarchybot wants to merge 1 commit into
quattrofrom
fix/issue-11958

Conversation

@omarchybot

Copy link
Copy Markdown
Collaborator

install/hardware/intel/video-acceleration.sh installs intel-media-driver libvpl vpl-gpu-rt only when the lowercased lspci line contains hd graphics, uhd graphics, xe, iris, arc or panther lake. Current pci.ids names a whole run of recent Intel GPUs plain [Intel Graphics] — Wildcat Lake, Meteor Lake, Arrow Lake, Lunar Lake, Raptor Lake-P/U, Alder Lake-N, Panther Lake and Battlemage — so on Wildcat Lake (and the rest of that list) setup installs no VA-API driver and hardware video decode does not work until the packages are added by hand.

This adds intel graphics to the regex. All 30 Intel entries in pci.ids (hwdata 0.412) carrying that name are Gen12 or newer, which intel-media-driver supports, and none is a pre-Broadwell part that would need libva-intel-driver. The regex only gains an alternative, so every GPU that matched before still gets the same packages. panther lake stays for databases that named it differently.

test/shell.d/intel-video-acceleration-test.sh sources the leaf with lspci and omarchy-pkg-add stubbed and checks which packages each GPU name gets; it fails on quattro at the Wildcat Lake case and passes with this change.

Existing installs on these GPUs are not repaired by this, since updates run migrations rather than hardware setup; whether to add a migration for them is left to the maintainer.

Reviewed by Codex Medium, which found no defects in the fix and suggested the test prologue the testing docs ask for, now applied.

Fixes #11958

The gate matched marketing names (UHD, Iris, Xe, Arc) and Panther Lake by codename. Current pci.ids names Wildcat Lake, Meteor Lake, Arrow Lake, Lunar Lake, Raptor Lake-P/U, Alder Lake-N and Battlemage plain "[Intel Graphics]", so those machines got no VA-API driver. Every such entry is Gen12 or newer, which intel-media-driver supports.

Fixes #11958

Co-Authored-By: Codex Medium <noreply@openai.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerConfidence Score: 4/5

[Medium impact] Expands GPU detection for Intel video acceleration.

The PR appears safe to merge, with a non-blocking improvement needed in the new test.

Findings

  1. P2 Failed scripts can pass ▶

Summary

Adds intel graphics to the Intel GPU name check so fresh installs select intel-media-driver, libvpl, and vpl-gpu-rt for these devices.

  • Intel GPUs named [Intel Graphics] now get video drivers.

Reviews (1) · Last reviewed commit: "Install intel-media-driver for GPUs pci...." · Reviewed by Greptile

Comment on lines +27 to +28
TEST_GPU=$1 TEST_INSTALLED="$test_tmp/installed" PATH="$fake_bin:$PATH" \
bash -c 'source "$ROOT/install/hardware/intel/video-acceleration.sh"'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Failed scripts can pass

installed_for ignores the child Bash process’s exit status. If the script fails before writing the package file for the non-Intel case, its empty output still passes the “nothing is installed” check. This can hide future failures in that path. Check the child’s exit status explicitly and fail the test before checking its output.

Suggested change
TEST_GPU=$1 TEST_INSTALLED="$test_tmp/installed" PATH="$fake_bin:$PATH" \
bash -c 'source "$ROOT/install/hardware/intel/video-acceleration.sh"'
TEST_GPU=$1 TEST_INSTALLED="$test_tmp/installed" PATH="$fake_bin:$PATH" \
bash -c 'source "$ROOT/install/hardware/intel/video-acceleration.sh"' ||
fail "video acceleration setup succeeds for $1"

@jandrusk

Copy link
Copy Markdown

Good fix for GPUs pci.ids names only [Intel Graphics] (#13987, also #11958). Same change is already open as #14252 — please pick one and close the other so we don't double-merge install/hardware/intel/video-acceleration.sh.

@omarchybot

Copy link
Copy Markdown
Collaborator Author

Closing this as a duplicate of #14252, which is older and makes the same change: both add intel graphics to the name regex in install/hardware/intel/video-acceleration.sh so that GPUs pci.ids names only [Intel Graphics] (Arrow Lake, Meteor Lake, Lunar Lake, Wildcat Lake, Battlemage and the rest) get intel-media-driver libvpl vpl-gpu-rt. Same cause, same fix, same base branch (quattro). #14252 also carries a migration for existing installs, which this pull request left out; what this one adds is a stub-based test in test/shell.d/intel-video-acceleration-test.sh, and #9824 already carries a test of the same shape.

I compared the two diffs, and Codex Medium, asked separately with only the two pull requests in front of it, agreed they are the same change (independence is not guaranteed, since it can read this session's working files). Nothing was run on a worker for this one, since it is not going ahead.

Two other open pull requests fix the same detection differently: #8514 selects the driver by PCI device ID and has been verified on a worker, and #9824 installs intel-media-driver for any Intel display device that isn't GMA. Which of these lands is the maintainer's decision.

If this was closed by mistake, reopen it.

@omarchybot omarchybot added the duplicate This issue or pull request already exists label Oct 17, 2026
@omarchybot omarchybot closed this Oct 17, 2026
massisalva added a commit to massisalva/omarchy that referenced this pull request Oct 25, 2026
Capture the lspci output before matching so grep -q can't make the
pipeline fail under pipefail. Add a stub-based test for the install
script and the migration, adapted from omacom#15094.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working compatibility Make Omarchy work better on everything! duplicate This issue or pull request already exists

Projects

None yet

Development

Successfully merging this pull request may close these issues.

intel/video-acceleration.sh doesn't match Intel Wildcat Lake GPU, skips installing intel-media-driver

2 participants