Repository navigation
Install intel-media-driver for GPUs pci.ids names "[Intel Graphics]" - #15094
omarchybot wants to merge 1 commit into
Conversation
The gate matched marketing names (UHD, Iris, Xe, Arc) and Panther Lake by codename. Current pci.ids names Wildcat Lake, Meteor Lake, Arrow Lake, Lunar Lake, Raptor Lake-P/U, Alder Lake-N and Battlemage plain "[Intel Graphics]", so those machines got no VA-API driver. Every such entry is Gen12 or newer, which intel-media-driver supports. Fixes #11958 Co-Authored-By: Codex Medium <noreply@openai.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
| TEST_GPU=$1 TEST_INSTALLED="$test_tmp/installed" PATH="$fake_bin:$PATH" \ | ||
| bash -c 'source "$ROOT/install/hardware/intel/video-acceleration.sh"' |
There was a problem hiding this comment.
installed_for ignores the child Bash process’s exit status. If the script fails before writing the package file for the non-Intel case, its empty output still passes the “nothing is installed” check. This can hide future failures in that path. Check the child’s exit status explicitly and fail the test before checking its output.
| TEST_GPU=$1 TEST_INSTALLED="$test_tmp/installed" PATH="$fake_bin:$PATH" \ | |
| bash -c 'source "$ROOT/install/hardware/intel/video-acceleration.sh"' | |
| TEST_GPU=$1 TEST_INSTALLED="$test_tmp/installed" PATH="$fake_bin:$PATH" \ | |
| bash -c 'source "$ROOT/install/hardware/intel/video-acceleration.sh"' || | |
| fail "video acceleration setup succeeds for $1" |
|
Closing this as a duplicate of #14252, which is older and makes the same change: both add I compared the two diffs, and Codex Medium, asked separately with only the two pull requests in front of it, agreed they are the same change (independence is not guaranteed, since it can read this session's working files). Nothing was run on a worker for this one, since it is not going ahead. Two other open pull requests fix the same detection differently: #8514 selects the driver by PCI device ID and has been verified on a worker, and #9824 installs If this was closed by mistake, reopen it. |
Capture the lspci output before matching so grep -q can't make the pipeline fail under pipefail. Add a stub-based test for the install script and the migration, adapted from omacom#15094. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
install/hardware/intel/video-acceleration.shinstallsintel-media-driver libvpl vpl-gpu-rtonly when the lowercasedlspciline containshd graphics,uhd graphics,xe,iris,arcorpanther lake. Currentpci.idsnames a whole run of recent Intel GPUs plain[Intel Graphics]— Wildcat Lake, Meteor Lake, Arrow Lake, Lunar Lake, Raptor Lake-P/U, Alder Lake-N, Panther Lake and Battlemage — so on Wildcat Lake (and the rest of that list) setup installs no VA-API driver and hardware video decode does not work until the packages are added by hand.This adds
intel graphicsto the regex. All 30 Intel entries inpci.ids(hwdata 0.412) carrying that name are Gen12 or newer, whichintel-media-driversupports, and none is a pre-Broadwell part that would needlibva-intel-driver. The regex only gains an alternative, so every GPU that matched before still gets the same packages.panther lakestays for databases that named it differently.test/shell.d/intel-video-acceleration-test.shsources the leaf withlspciandomarchy-pkg-addstubbed and checks which packages each GPU name gets; it fails onquattroat the Wildcat Lake case and passes with this change.Existing installs on these GPUs are not repaired by this, since updates run migrations rather than hardware setup; whether to add a migration for them is left to the maintainer.
Reviewed by Codex Medium, which found no defects in the fix and suggested the test prologue the testing docs ask for, now applied.
Fixes #11958