Repository navigation
Install Intel video acceleration on GPUs named only Intel Graphics - #14252
massisalva wants to merge 2 commits into
Conversation
Arrow Lake-U reports itself in lspci as "Intel Graphics", which the detection regex missed, leaving video decoding on the CPU. Match that name and add a migration for existing installs. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] The PR appears safe to merge. SummaryAdds support for Intel GPUs whose names contain only “Intel Graphics.”
The previous migration finding is fully addressed. No new actionable issues were found. Reviews (2) · Last reviewed commit: "Avoid SIGPIPE in Intel Graphics migratio..." · Reviewed by Greptile |
chessing234
left a comment
There was a problem hiding this comment.
Reviewed head 53f516319f6c11c3b873f808a63c473d0c8751c8.
Reviewed the added plain Intel Graphics match and the existing-user migration condition. Both paths select the same acceleration packages for that new device label. No actionable defect found in the changed matching. I did not install packages or verify VA-API on Intel hardware.
|
Thanks for the clear writeup on the Arrow Lake-U naming. Heads-up that #9824 also targets this: it switches detection to "any Intel display device" and has an Arrow Lake-U Small nit on the migration: migrations run under gpus=$(lspci | grep -iE 'vga|3d|display' || true)
if grep -qi 'intel graphics' <<<"$gpus"; then
omarchy-pkg-add intel-media-driver libvpl vpl-gpu-rt
fi |
|
Thanks for the clear write-up. I read the diff at 53f5163 against Two older pull requests change the same detection in Nothing is needed from you for now. |
|
Compared the PRs for
#14252 is the one to merge now that #15094 was closed in its favour: the same one-word change to the name regex, and it passes every case. It has no test; the stub test from #15094 could be carried over. #9824 (class-based detection) and #8514 (PCI-generation helper) are larger rewrites of the same fix. Suggestion: add |
Capture the lspci output before matching so grep -q can't make the pipeline fail under pipefail. Add a stub-based test for the install script and the migration, adapted from omacom#15094. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for the reviews. Pushed two changes:
Also linked #11958 and #13987, which this fixes. Happy to coordinate with #9824 or #8514 if the maintainers prefer one of those approaches. The migration would apply on top of either. |
|
Thanks for the fix, @massisalva, and for picking up the SIGPIPE nit and the test from #15094. Since your last push, #17150 was merged to Two models reviewed it, Codex Medium and muse-wonder (via pi, thinking high), and both concluded the same. Neither found a real device that your looser I've recommended to the maintainer that this be closed as fixed by #17150. #11958 and #13987 are still open, but #17150 fixes them too. Nothing is needed from you. |
|
Closing as fixed by #17150, which landed the same fix on |
On a ThinkPad T14s Gen 6,
lspcinames the Arrow Lake-U GPU only asIntel Corporation Arrow Lake-U [Intel Graphics](8086:7d41). None of the names in the detection regex ininstall/hardware/intel/video-acceleration.shmatch it, so the install never addsintel-media-driver,libvplorvpl-gpu-rt. With no VA-API driver, browsers and players decode video on the CPU.Add
intel graphicsto the regex. The older GPUs that should keeplibva-intel-driverreport names such as4th Gen Core Processor Integrated Graphics ControllerorMobile 4 Series Chipset Integrated Graphics Controller, and those still don't match.Hardware setup only runs at install time, so existing installs on these GPUs stay without the driver. A migration installs the same packages there.
omarchy-pkg-addskips packages that are already installed, so running it again does nothing.After installing the packages on the affected machine,
vainforeports the iHD driver with H.264, HEVC, VP9 and AV1 decode.Fixes #11958
Fixes #13987
🤖 Generated with Claude Code