Repository navigation
Install Intel VA-API drivers by device, not by marketing name - #9824
ifigueroap wants to merge 1 commit into
Conversation
video-acceleration.sh matched the lspci line against an allowlist of marketing names: hd graphics, uhd graphics, xe, iris, arc, panther lake. Intel ships many recent parts as a bare "[Intel Graphics]" with no such branding, so the allowlist matched nothing and the leaf silently installed no VA-API driver at all. 25 device IDs across 13 families miss, including Raptor Lake-P/U, all of Meteor, Arrow and Lunar Lake, Alder Lake-N, Wildcat Lake, and discrete Battlemage -- which misses despite the "arc" token, because pci.ids does not spell out the brand for those boards. "panther lake" is in that list because the same failure was already hit on one family and patched there rather than at the root, so it regressed again for everyone else. Invert the test: any Intel display device gets intel-media-driver, and only the pre-Broadwell parts still need a name. That set stopped growing in 2014, so new hardware now works by default instead of waiting for another token. Select the device with lspci -d 8086::0300 as well. The old grep -iE 'vga|3d|display' also matched unrelated lines whose hex device ID contains "3d" -- on the reporting machine it pulled in a PCI bridge, "Device a73d". Pre-Broadwell parts that are not named GMA, such as Ivy Bridge and Haswell, now get intel-media-driver, which cannot drive them and leaves decoding in software. That is what they already got from matching no token at all, so this is not a regression, but it is not a fix for them either. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BT3H7mj63CxzHWKLd4apWk
|
Reviewed at The bug is real. In the current #8514 fixes the same bug a different way: it picks the driver from the PCI device ID in sysfs. Both models compared the two side by side, and both conclude that #8514 is the one to take forward:
#8514 is much larger: a 120-line table of ID ranges, against 12 lines here. The second opinion also found one ancient part it would misroute to iHD ( Only one of the two should land, so this pull request was not run on a worker. Choosing between competing fixes is the maintainer's call, and this is waiting on them. |
|
Reviewed again at Both models compared all three. The conclusion is the same as before: #8514 is the one to take forward. It is the oldest of the three, and it is the only one that handles Intel GPUs reporting class 0380, gives Ivy Bridge and Haswell This pull request does have one thing #8514 lacks: test cases for the families that Nothing was run on a worker. The choice between these fixes is the maintainer's, and this is waiting on them. |
The name regex this replaces missed every part whose pci.ids entry is a bare "[Intel Graphics]": Raptor Lake-P/U, Meteor Lake, Arrow Lake, Lunar Lake, Alder Lake-N, Wildcat Lake and discrete Battlemage. Pin all 25 of those ids to intel-media-driver, and pin that an Intel GPU reporting display class 0380, as a non-boot GPU does, still gets its package. The ids and the class 0380 case come from omacom#9824. Co-Authored-By: Ismael Figueroa <ifigueroap@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Problem
install/hardware/intel/video-acceleration.shdecides which VA-API driver to install by matching thelspciline against an allowlist of marketing names:Intel ships many recent parts as a bare
[Intel Graphics]with no Iris/UHD/Arc branding, so the allowlist matches nothing and the leaf silently installs no VA-API driver at all.25 device IDs across 13 families miss, per
pci.ids:8086:a7aaa7aba7aca7ad7d407d457d607dd57d417d677dd1b640642064b046d346d4fd80fd81e202e20de210e215e216e220e221Battlemage is discrete Arc and misses despite the
arctoken, becausepci.idsdoes not spell out the brand for those boards.panther lakeis in that allowlist because this same failure was already hit on one family and patched there rather than at the root — so it regressed again for every other family.Evidence from an affected machine
Intel Raptor Lake-P
[8086:a7ab], Omarchy 4.0.2. After a normal install:vpl-gpu-rt— not installed (3rd package on thatomarchy-pkg-addline, so the line never ran)libvpl— installed, but as anffmpegdependencyintel-media-driver— not installedvulkan-intel— installedThat last one is the contrast.
install/hardware/vulkan.shruns in the same install and matches on vendor ((VGA|Display).*Intel); it worked. This leaf matches on model names; it did not.The practical result was no
iHD_drv_video.soon disk at all, so the only VA-API driver present was NVIDIA's — which on a hybrid laptop means video decodes on the dGPU and every frame crosses the PRIME boundary. That surfaced as flicker while scrolling video (see #9812, which is the other half of this and independent of it).Fix
Invert the test. Any Intel display device gets
intel-media-driver; only the pre-Broadwell parts still need a name, and that set stopped growing in 2014. New hardware now works by default instead of waiting for another token to be added.Also select the device with
lspci -d 8086::0300. The oldgrep -iE 'vga|3d|display'matched unrelated lines whose hex device ID contains3d— on the reporting machine it pulled in a PCI bridge,Device a73d, alongside the GPU.Tradeoff
Pre-Broadwell parts that are not named GMA — Ivy Bridge, Haswell — now get
intel-media-driver, which cannot drive them, leaving decode in software. That is exactly what they already got from matching no token at all, so this is not a regression, but it is not a fix for them either. Handling them properly needs generation detection rather than name matching, which felt like a separate change.Tests
test/shell.d/intel-video-acceleration-test.shstubslspciandomarchy-pkg-addand covers each missed family, discrete Battlemage, the GMA fallback, no-Intel-GPU, and the previously-matching names (Iris Xe, UHD, Panther Lake) as regression cases.Against the current script it fails exactly as reported:
test/clipasses.test/shellhas 3 failures (config-test,snapper-test,unowned-system-paths-test) that reproduce identically on unmodifiedquattro.🤖 Generated with Claude Code
https://claude.ai/code/session_01BT3H7mj63CxzHWKLd4apWk
Fixes #13987