Repository navigation
Conversation
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryAdds
Reviews (5) · Last reviewed commit: "Merge quattro into fix-14887-skip-fuse-i..." · Reviewed by Greptile |
davfs2 mounts with filesystem type `fuse` on Linux, which Arch's default PRUNEFS already skips, so `davfs` never matches a mount in /proc/self/mountinfo and the docs promised a WebDAV exclusion this option does not provide. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reviewed and verified on a disposable Omarchy worker (plocate 1.1.25, systemd 262), with a second opinion from Codex Medium. Reproduction. I mounted a local directory through One fix pushed (79cec20): Second opinion. Codex Medium found the same Related. This covers the crawling half of #14887. The foreground Waiting on the maintainer. |
quattro's omacom#16756 removed locate-test.sh's checks of updatedb and plocate's own behaviour, which is where this branch's real-updatedb prunefs check sat, so that check goes with them. The remaining options check still holds all three callers to the same --add-prunefs list. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This had stopped merging cleanly into The merge. The only conflict was Reproduction, repeated at the new head. I made a root Second opinion. Codex Medium and muse-wonder via pi (thinking high) each reviewed the merge and the full change and found no defects. Their independence is not guaranteed. Both agreed that dropping the debug-output check matches what #16756 removed. muse-wonder added one point about scope: a Not added, and why. #14887 also suggested Related. #14914 was closed without merging (#16568 replaced it), so the foreground Waiting on the maintainer. |
omacom#18917 removed install/post-install/localdb.sh, so the install-time updatedb this branch extended is gone; the scheduled service and the AUR refresh keep the --add-prunefs option. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This stopped merging cleanly into The merge. The only conflict was Reproduction, repeated at the new head. I made a root Second opinion. Codex Medium and muse-wonder via pi (thinking high) each reviewed the merge and the full change and found no defects. Their independence is not guaranteed. Both confirmed that nothing else still refers to The description is out of date. @americos, three lines no longer match the branch: the install step ( Related. #16100 still re-indents the same Waiting on the maintainer. |
Follow-up to #14887. This stops the daily indexing job from crawling network and cloud mounts.
Arch's default
PRUNEFSalready skipsfuse,fuse.sshfs,nfs,nfs4,cifsandsmbfs, but notfuse.rclone,smb3orceph(davfs2 mounts show up as plainfuse, which is already skipped). So a mounted rclone remote or SMB3 share gets walked on every scheduled run. This adds those three with--add-prunefs, which adds to the system's/etc/updatedb.confinstead of replacing it. Omarchy still never rewrites that file.The scheduled service and the AUR refresh (
omarchy-pkg-aur-install) keep identical options, whichtest/shell.d/locate-test.shenforces.#16100 re-indents the same
updatedbline inomarchy-pkg-aur-install. Whichever lands second should keep the full option list.AI assistance was used to prepare this change.
Fixes #14887