Skip to content

Skip rclone, SMB3, and Ceph mounts when indexing files - #15178

Open
americos wants to merge 5 commits into
omacom:quattrofrom
americos:fix-14887-skip-fuse-indexing
Open

americos wants to merge 5 commits into
omacom:quattrofrom
americos:fix-14887-skip-fuse-indexing

Conversation

@americos

@americos americos commented Oct 12, 2026 •

Copy link
Copy Markdown

Follow-up to #14887. This stops the daily indexing job from crawling network and cloud mounts.

Arch's default PRUNEFS already skips fuse, fuse.sshfs, nfs, nfs4, cifs and smbfs, but not fuse.rclone, smb3 or ceph (davfs2 mounts show up as plain fuse, which is already skipped). So a mounted rclone remote or SMB3 share gets walked on every scheduled run. This adds those three with --add-prunefs, which adds to the system's /etc/updatedb.conf instead of replacing it. Omarchy still never rewrites that file.

The scheduled service and the AUR refresh (omarchy-pkg-aur-install) keep identical options, which test/shell.d/locate-test.sh enforces.

#16100 re-indents the same updatedb line in omarchy-pkg-aur-install. Whichever lands second should keep the full option list.

AI assistance was used to prepare this change.

Fixes #14887

@greptile-apps

greptile-apps Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable defects were found.

Summary

Adds fuse.rclone, smb3, and ceph to the filesystem exclusions used by scheduled indexing and AUR package refreshes.

  • Indexing skips rclone, SMB3, and Ceph mounts.

Reviews (5) · Last reviewed commit: "Merge quattro into fix-14887-skip-fuse-i..." · Reviewed by Greptile

Comment thread test/shell.d/locate-test.sh Resolved
@omarchybot omarchybot added the bug Something isn't working label Oct 17, 2026
davfs2 mounts with filesystem type `fuse` on Linux, which Arch's default PRUNEFS already skips, so `davfs` never matches a mount in /proc/self/mountinfo and the docs promised a WebDAV exclusion this option does not provide.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@omarchybot omarchybot added verified Omarchy Triage has verified that this issue is ready for final review ready Good to merge labels Oct 17, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Reviewed and verified on a disposable Omarchy worker (plocate 1.1.25, systemd 262), with a second opinion from Codex Medium.

Reproduction. I mounted a local directory through rclone mount --allow-other as root under /home, which shows up as fuse.rclone, and ran the real plocate-updatedb.service. With the quattro drop-in the mount's files were indexed. With this branch's drop-in they were skipped. Restoring the quattro drop-in indexed them again. systemd reads --add-prunefs="..." as a single argument, and install/post-install/localdb.sh from this branch skips the mount as well. ./test/cli, test/shell.d/locate-test.sh and test/shell.d/config-test.sh pass on the worker.

One fix pushed (79cec20): davfs is gone from the list in all three callers, the test and docs/file-layout.md. On Linux, davfs2 mounts with the filesystem type fuse, and Arch's default PRUNEFS already skips that. A davfs2 mount on the worker showed fuse in mountinfo and was not indexed on quattro, so davfs never matched anything, and the docs promised a WebDAV exclusion the option did not add. smb3 (a mount -t smb3 share) and ceph are real filesystem types that the defaults miss, so they stay. The title still mentions WebDAV.

Second opinion. Codex Medium found the same davfs problem on its own, independence not guaranteed. It confirmed the systemd quoting and plocate's case-insensitive exact matching, and found nothing left on the new head. It also noted that the new test only checks that updatedb received the exclusions, not that a real mount gets skipped, because a unit test cannot mount FUSE. The worker reproduction above covers that.

Related. This covers the crawling half of #14887. The foreground updatedb in omarchy-pkg-aur-install is #14914, which conflicts with this branch's hunk in that file. Whichever lands second needs that resolved. I have not linked #14887 to close, since this alone does not fix the hang it describes.

Waiting on the maintainer.

@americos americos changed the title Skip rclone, SMB3, WebDAV, and Ceph mounts when indexing files Skip rclone, SMB3, and Ceph mounts when indexing files Oct 17, 2026
@omarchybot omarchybot removed ready Good to merge verified Omarchy Triage has verified that this issue is ready for final review labels Oct 27, 2026
quattro's omacom#16756 removed locate-test.sh's checks of updatedb and plocate's own behaviour, which is where this branch's real-updatedb prunefs check sat, so that check goes with them. The remaining options check still holds all three callers to the same --add-prunefs list.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@omarchybot omarchybot added the verified Omarchy Triage has verified that this issue is ready for final review label Nov 1, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

This had stopped merging cleanly into quattro, so I pushed a merge of quattro into the branch (c8388e1) and verified it again on a disposable Omarchy worker (plocate 1.1.25, systemd 262.1).

The merge. The only conflict was test/shell.d/locate-test.sh. #16756 removed that file's checks of updatedb and plocate's own behaviour, and this branch's check that updatedb's debug output names FUSE.RCLONE, SMB3 and CEPH was part of that block, so it is gone too. What remains is the options check, now with --add-prunefs=fuse.rclone smb3 ceph. It still runs localdb.sh and omarchy-pkg-aur-install and compares their arguments with the drop-in, so it fails if any of the three callers drops or changes the option. Nothing else changed.

Reproduction, repeated at the new head. I made a root rclone mount --allow-other under /home (type fuse.rclone) and ran the real plocate-updatedb.service. With quattro's drop-in the mount was indexed. With this branch's drop-in it was skipped. Restoring quattro's drop-in indexed it again. install/post-install/localdb.sh from the branch skipped it as well. ./test/cli and test/shell.d/locate-test.sh pass on the worker.

Second opinion. Codex Medium and muse-wonder via pi (thinking high) each reviewed the merge and the full change and found no defects. Their independence is not guaranteed. Both agreed that dropping the debug-output check matches what #16756 removed. muse-wonder added one point about scope: a ceph-fuse mount reports fuse.ceph, and the ceph entry does not match it, so only kernel CephFS is covered.

Not added, and why. #14887 also suggested fuse.gvfsd-fuse and fuse.portal. Those mount under /run/user/<uid>, which is a tmpfs, and tmpfs is already in Arch's PRUNEFS, so updatedb never gets down to them.

Related. #14914 was closed without merging (#16568 replaced it), so the foreground updatedb in omarchy-pkg-aur-install stays. With this change it no longer walks an rclone mount, which is the hang #14887 reports, so this pull request is now linked to close #14887. Two lines of the description are out of date: the test no longer checks that updatedb skips the new types, and the note about #14914 no longer applies. Open #16100 re-indents the same updatedb line in omarchy-pkg-aur-install. That is a textual conflict only, and whichever lands second should keep the full option list.

Waiting on the maintainer.

@omarchybot omarchybot removed the verified Omarchy Triage has verified that this issue is ready for final review label Nov 16, 2026
omacom#18917 removed install/post-install/localdb.sh, so the install-time updatedb this branch extended is gone; the scheduled service and the AUR refresh keep the --add-prunefs option.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@omarchybot omarchybot added the verified Omarchy Triage has verified that this issue is ready for final review label Nov 17, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

This stopped merging cleanly into quattro again, so I pushed another merge of quattro into the branch (89f5892) and verified it again on a disposable Omarchy worker (plocate 1.1.25, rclone 1.76.0).

The merge. The only conflict was install/post-install/localdb.sh, which #18917 deleted: the installer no longer builds a locate database and leaves it to the Persistent timer. The merge keeps that deletion, so the option now lives in the two places that still run updatedb: the plocate-updatedb.service drop-in and omarchy-pkg-aur-install. test/shell.d/locate-test.sh and docs/file-layout.md merged without conflict and still check and describe both. Nothing else changed.

Reproduction, repeated at the new head. I made a root rclone mount --allow-other under /home (type fuse.rclone) and ran the real plocate-updatedb.service. With quattro's drop-in the mount was indexed. With this branch's drop-in it was skipped. Restoring quattro's drop-in indexed it again. The updatedb line from this branch's omarchy-pkg-aur-install skipped it too. ./test/cli, test/shell.d/locate-test.sh and test/shell.d/config-test.sh pass on the worker.

Second opinion. Codex Medium and muse-wonder via pi (thinking high) each reviewed the merge and the full change and found no defects. Their independence is not guaranteed. Both confirmed that nothing else still refers to localdb.sh, and that the test fails if either remaining caller drops or changes the option. muse-wonder suggested the docs overstate things because ceph is already in plocate's default PRUNEFS. It isn't: the worker's /etc/updatedb.conf from plocate 1.1.25 lists cifs, smbfs and plain fuse, but not ceph, smb3 or fuse.rclone, so the docs sentence stands.

The description is out of date. @americos, three lines no longer match the branch: the install step (localdb.sh) is gone from quattro, the test no longer runs updatedb to check that it skips the new types (#16756 removed those checks), and #14914 was closed without merging, so the omarchy-pkg-aur-install hunk stays. Updating them would save the next reader from checking.

Related. #16100 still re-indents the same updatedb line in omarchy-pkg-aur-install. That is a textual conflict only, and whichever lands second should keep the full option list.

Waiting on the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working verified Omarchy Triage has verified that this issue is ready for final review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

omarchy-pkg-aur-install hangs after transaction: foreground updatedb scans FUSE/network mounts

2 participants