Skip to content

Skip Synaptics fingerprint ids that libfprint cannot drive - #15185

Open
afurm wants to merge 2 commits into
omacom:quattrofrom
afurm:fix-hw-fingerprint-unsupported-synaptics
Open

afurm wants to merge 2 commits into
omacom:quattrofrom
afurm:fix-hw-fingerprint-unsupported-synaptics

Conversation

@afurm

@afurm afurm commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

Fixes #13754.

omarchy-hw-fingerprint treats any unbound Synaptics (06cb) device as a reader. Setup then asks for sudo and fails with NoSuchDevice on readers no libfprint driver claims, such as the T480's 06cb:009a. The vendor guess now skips the 06cb ids that libfprint lists under "Known unsupported devices" in its autosuspend.hwdb. The Tudor ids 00be/00da/00fd/00ff stay detectable so the synaTudor path (#14342) keeps working. Product-name matches don't change. This doesn't overlap with #11047, which only changes the setup message. If the python-validity setup (#13187) lands, 009a should come off this list.

I checked it with bash test/shell.d/hw-fingerprint-test.sh, which passes. The new 06cb:009a case fails on the old detector.

@greptile-apps

greptile-apps Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Medium impact] The PR appears safe to merge.

Summary

Stops the vendor-only check from detecting listed unsupported Synaptics readers.

  • Fingerprint checks skip unsupported Synaptics USB IDs.

Reviews (2) · Last reviewed commit: "Merge branch 'quattro' into fix-hw-finge..." · Reviewed by Greptile

@omarchybot

Copy link
Copy Markdown
Collaborator

Reviewed at 1a8e0cf, nothing to fix.

What was checked, on a disposable Omarchy worker: test/shell.d/hw-fingerprint-test.sh passes on this head (15 of 15), also with the branch merged onto current quattro (cce8b1c). With the detector put back to quattro's version, the new 06cb:009a case fails, so the test catches the bug in #13754. ./test/cli and the other fingerprint tests (fingerprint-invitation-test.sh, fingerprint-package-test.sh) pass too. I checked the 22 ids in unsupported_synaptics against libfprint master. They are exactly the 06cb ids listed under "Known unsupported devices" in data/autosuspend.hwdb, minus the Tudor ids 00be/00da/00fd/00ff, and none of them is in the Synaptics driver's id_table (00bd–01a4). A device whose product string names it a reader is still detected, because that match runs before the new skip.

Second opinion: Codex at medium effort reviewed the diff and found no defects. It agreed that the list is correct and the change is proportionate (independence not guaranteed, since it can read this session's notes). It also raised the same overlap noted below.

One thing for the maintainer to decide, not the author: #13187 and #15535 add python-validity support that covers 06cb:009a, and both still start setup with if ! omarchy-hw-fingerprint. With this merged, a 009a-only machine would never reach that path. Your description already says 009a should come off the list if python-validity lands. Which way the T480 goes is the maintainer's call. #15130, #15334 and #15586 also edit bin/omarchy-hw-fingerprint, so whichever merges later may need a small rebase.

Waiting on the maintainer.

@omarchybot omarchybot removed ready Good to merge verified Omarchy Triage has verified that this issue is ready for final review labels Oct 19, 2026
@omarchybot omarchybot added the verified Omarchy Triage has verified that this issue is ready for final review label Oct 21, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator

Re-checked at f381baf, after the merge of quattro into this branch. Nothing to fix, and it merges cleanly onto current quattro (087f73d).

The change is the same 24 lines as before. It sits correctly beside the platform-reader block quattro gained in #14675: that block runs first, and the new continue skips only the current USB device. On a disposable Omarchy worker, test/shell.d/hw-fingerprint-test.sh passes on this head. With bin/omarchy-hw-fingerprint put back to quattro's version, the 06cb:009a case fails, so the test still catches #13754. fingerprint-invitation-test.sh, fingerprint-package-test.sh and ./test/cli pass too.

Second opinion: Codex at medium effort reviewed the diff at this head and found no defects. It agreed that the id list and the placement are right and that the change is proportionate, though its independence is not guaranteed. It also noted that a listed id whose product string names it a fingerprint reader is still detected. That is consistent with this pull request's scope.

Two things for the maintainer, not the author:

Waiting on the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working compatibility Make Omarchy work better on everything! verified Omarchy Triage has verified that this issue is ready for final review

Projects

None yet

2 participants