Repository navigation
Conversation
[Medium impact] The PR appears safe to merge. SummaryStops the vendor-only check from detecting listed unsupported Synaptics readers.
Reviews (2) · Last reviewed commit: "Merge branch 'quattro' into fix-hw-finge..." · Reviewed by Greptile |
|
Reviewed at 1a8e0cf, nothing to fix. What was checked, on a disposable Omarchy worker: Second opinion: Codex at medium effort reviewed the diff and found no defects. It agreed that the list is correct and the change is proportionate (independence not guaranteed, since it can read this session's notes). It also raised the same overlap noted below. One thing for the maintainer to decide, not the author: #13187 and #15535 add python-validity support that covers 06cb:009a, and both still start setup with Waiting on the maintainer. |
|
Re-checked at f381baf, after the merge of The change is the same 24 lines as before. It sits correctly beside the platform-reader block Second opinion: Codex at medium effort reviewed the diff at this head and found no defects. It agreed that the id list and the placement are right and that the change is proportionate, though its independence is not guaranteed. It also noted that a listed id whose product string names it a fingerprint reader is still detected. That is consistent with this pull request's scope. Two things for the maintainer, not the author:
Waiting on the maintainer. |
Fixes #13754.
omarchy-hw-fingerprinttreats any unbound Synaptics (06cb) device as a reader. Setup then asks for sudo and fails withNoSuchDeviceon readers no libfprint driver claims, such as the T480's06cb:009a. The vendor guess now skips the06cbids that libfprint lists under "Known unsupported devices" in itsautosuspend.hwdb. The Tudor ids00be/00da/00fd/00ffstay detectable so the synaTudor path (#14342) keeps working. Product-name matches don't change. This doesn't overlap with #11047, which only changes the setup message. If the python-validity setup (#13187) lands,009ashould come off this list.I checked it with
bash test/shell.d/hw-fingerprint-test.sh, which passes. The new06cb:009acase fails on the old detector.