Repository navigation
Conversation
omarchy-hw-fingerprint matches readers on vendor ID, and 06cb and 138a are both on its list. Three of those devices -- 06cb:009a, 138a:0090 and 138a:0097 -- have no libfprint driver at all; only the community's reverse-engineered python-validity daemon talks to them. So setup detects a reader, installs libfprint-git, and runs all the way to enrollment before fprintd reports "No devices available". That surfaces as the generic "Enrollment failed. Please try again.", which is indistinguishable from a bad swipe and sends people into a retry loop that cannot succeed. Check for those three IDs on enrollment failure and say what is actually wrong, pointing at python-validity. The device list is python-validity's own udev match set from 94-validity-sensors.rules. This only changes the failure message; nothing new is installed and the supported path is untouched. Verified on a ThinkPad T480 with 06cb:009a (Synaptics Metallica MIS Touch), where the reader does work once python-validity is driving it. The helper matches that device, and declines both an unrelated device and an empty device tree. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CqYR76DqmNVGYtGYUpyJmv
python-validity's SupportedDevices drives 138a:009d as well as the three IDs its udev rules match, and the pinned libfprint-git lists it under known unsupported devices, so it hit the same "Please try again" dead end. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com>
|
Keyed on the USB ID alone, the message also fired when a reader python-validity already drives failed for a bad swipe or a timeout, telling the user a retry could not help when it could. fprintd-list reporting no device is what says libfprint could not claim it. The setup test now covers the listed reader with and without a device, and an unlisted one. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Reviewed and verified at 712eb38, with two small commits pushed to your branch. I reviewed it with Codex Medium as a second opinion, which can see my reasoning, so where it agreed that is not independent confirmation. The problem is real. On a worker with the pinned What I pushed:
Tests: Second opinion: Codex's last round on 712eb38 found nothing open in the script. It pointed out that the older cases in the setup test still read the host's Related: #13187 takes the other route for the same readers and installs python-validity from the AUR, which is a decision for the maintainer. If it lands, this message needs to know which backend setup chose. #11721 and #13754 report this failure on This is now waiting on the maintainer. |
|
Looks good — clear message + tests for the Validity/python-validity readers that libfprint cannot drive (#13754). Please coordinate with #15185 (skip those IDs at detect) and #15080 (name fprintd-invisible readers) so we don't ship three partial answers. Happy to take the messaging half from this PR if detect-side lands in #15185. |
omarchy-hw-fingerprintmatches readers on vendor ID, and06cband138aare both on its list. Three of those devices —06cb:009a,138a:0090and138a:0097— have no libfprint driver at all; only the community's reverse-engineered python-validity daemon talks to them.So
omarchy setup security fingerprintdetects a reader, installslibfprint-git, and runs all the way to enrollment before fprintd reportsNo devices available. That surfaces as:which is indistinguishable from a bad swipe, and sends people into a retry loop that cannot succeed. The script already anticipates this shape of failure — the comment above
setup_pam_confignotes that an Elan MOC sensor outside the elanmoc table "gets this far and then fails to enroll" — this just names the cause for the three devices where it's knowable up front.Change
On enrollment failure, check for those three IDs and say what's actually wrong:
Only the failure message changes. Nothing new is installed, the supported path is untouched, and the device list is python-validity's own udev match set from
94-validity-sensors.rulesrather than a guess.Verification
Tested on a ThinkPad T480 with
06cb:009a(Synaptics Metallica MIS Touch), where the reader does work once python-validity is driving it —fprintd-listgoes from "No devices available" to "found 1 devices", and enrollment andfprintd-verifythen succeed.The helper honours
OMARCHY_USB_DEVICES_PATH, so it is testable the same wayomarchy-hw-fingerprintis:1234:5678→ declines🤖 Generated with Claude Code
https://claude.ai/code/session_01CqYR76DqmNVGYtGYUpyJmv