Repository navigation
Authorize the quiet boot migration without sudo -v - #15729
Conversation
Under sudo's default verifypw=all, sudo -v asks for a password even when passwordless sudo is enabled, so an unattended omarchy update stopped on this migration's prompt. Run a command instead, as omarchy-update does. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] This change appears safe to merge. SummaryReplaces
Reviews (2) · Last reviewed commit: "Merge quattro, dropping the migration te..." · Reviewed by Greptile |
|
Reviewed and verified; nothing found that needs changing. Reproduced on a disposable worker built from the Omarchy ISO, with The updated Second opinion: Codex at medium effort reviewed the diff and found no defects. It agreed the problem is real and the change proportionate, and that the other #15527 also edits this migration and changes the same line of the test's sudo stub, so whichever lands second will need that line reconciled. They fix different bugs and do not compete. This is waiting on the maintainer. |
quattro removed migration tests in omacom#16302 (migrations get no suite test), so the test this branch changed goes with them; the migration fix stays. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
This had stopped merging cleanly, so I merged current I re-verified the merged head on a disposable worker built from the Omarchy ISO, with Second opinion: Codex at medium effort and muse-wonder (via pi, thinking high) each reviewed the merged diff and the conflict resolution and found no defects. Both agreed the deletion follows #15527 still edits this migration for a different bug. With the test gone, the two no longer touch the same lines. This is waiting on the maintainer. |
Summary
Migration
1791898365(#15301) checks for an unreadable Limine menu withsudo -vbefore runningsudo test -f. Under sudo's defaultverifypw=all,sudo -vasks for a password whenever any of the user's rules needs one, even when every command runs passwordless. That puts the #9066 failure back on the update path:omarchy update -yon a passwordless machine stops at the prompt after packages are already upgraded, and the run aborts.This change authorizes with
sudo true, the same approachomarchy-updateuses (#13323). A denied prompt still makes the command fail, so underbash -euo pipefailthe migration stays pending, which is what the original comment requires.Fixes #15728
Test plan
test/shell.d/limine-quiet-boot-migration-test.shso its sudo stub behaves like passwordless sudo underverifypw=all: commands run,-vfails. Before the fix the test fails on the "no Limine menu" case. After the fix all seven cases pass.test/shell.d/config-test.shandtest/shell.d/migrate-notify-test.shpass.omarchy update -yfinished.🤖 Generated with Claude Code