Repository navigation
Conversation
Pacman succeeds even when a DKMS hook fails, so an update can install a kernel without a driver its hardware requires. After the boot check, run the verifiers that installed compatibility packages ship against the stock and fallback kernels, and fail the update without the reboot prompt when one reports a missing module. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
[Medium impact] The PR appears safe to merge; both previous findings are addressed and no new actionable issues were found. SummaryThe PR adds a required-driver check before the update offers a reboot.
|
The gate now lives in omacom#15905, rebuilt on quattro's boot check and extended to the linux-omarchy kernel. This reverts commit e0ad4dc. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A failed pacman -Qlq inside process substitution went unnoticed, and an installed kernel without modules.order contributed no targets, so either let the check pass without verifying that kernel. Use the documented test header. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Read at The classification is unsettled. Claude Opus 5.5 read this as an This waits on the maintainer to decide what it is, and whether the update pipeline should carry a fixed list of one model's compatibility verifiers ahead of the packages that provide them. |
Summary
Pacman exits successfully even when a DKMS
PostTransactionhook fails. An update can therefore install a kernel that is missing a driver its hardware needs, and still offer the reboot. This adds a driver check to the gate that already holds the reboot back after the boot check:omarchy-update-verify-kernel-modulesis hidden, read-only and runs as the user:linux-omarchy) and the Archlinuxkept as its fallback are checked. Other kernels (lts,zen,t2) are alternatives the user manages. Module directories preserved from earlier boots are not checked.This is the update gate split out of #7732, as the review there suggested. It is rebuilt on current
quattro's boot-check gate, replacing the earlier separate step and the directomarchy-update-restartrefusal.Evidence
ERROR: Missing facetimehd for stock kernel 7.2.3-arch1-3, yet pacman returned 0 and the update offered the reboot. After the reboot, the camera had no driver and the speakers fell back to the stock CS8409 driver.test/shell.d/update-sequence-test.sh, the module check fails while every other step succeeds. The update exits 1, says "The update is not finished", releases Stay Awake, and does not offer the reboot. On unmodifiedquattro, the same suite fails its step-order assertion because nothing runs the check.test/shell.d/update-kernel-modules-test.shcovers seven cases:./test/cli,update-boot-verify,update-restart-phasesandupdate-sequence.linux-omarchy 7.2.8-9andlinux 7.2.11installed and the packages from Add MacBookPro13,1 camera and audio packages omarchy-pkgs#182, the command exits 0.update-restart-kernel-test.shfails on this host on unmodifiedquattroas well. It reads the host's kernel state, and this change doesn't touch it.Merge Danger
Door: two-way
Reverting the commit removes the step. It writes nothing, and no other component consumes its exit status apart from the update's existing
boot_verifiedgate.Blast Radius: narrow
On machines without one of the listed compatibility packages, it is a no-op that runs no
pacmanquery. On machines with them, a driver that genuinely failed to build now fails the update and withholds the reboot prompt. A faulty verifier would cause the same outcome: the update reports unfinished and the user is told to repair the drivers, while the system stays on its current kernel. The update's failure message now reads "the updated system" rather than "its boot files", because it covers both checks.🤖 Generated with Claude Code