Repository navigation
Conversation
There was a problem hiding this comment.
Pull request overview
Adds targeted MacBookPro13,1 support while preserving existing behavior for other Apple models.
Changes:
- Adds model-gated audio and camera installation.
- Migrates existing systems from the obsolete SPI DKMS driver.
- Adds offline packages, documentation, and focused tests.
Tip
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
install/hardware/all.sh |
Runs the new hardware installers. |
install/hardware/apple/fix-spi-keyboard.sh |
Uses in-tree applespi for this model. |
install/hardware/apple/install-macbookpro13-1-audio.sh |
Installs Cirrus audio support. |
install/hardware/apple/install-macbookpro13-1-camera.sh |
Installs camera driver and firmware. |
install/omarchy-other.packages |
Caches compatibility packages offline. |
migrations/1787257711.sh |
Migrates existing installations. |
manual/44-mac-support.md |
Documents support and limitations. |
test/shell.d/macbookpro13-1-hardware-test.sh |
Tests setup, migration, and documentation contracts. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
|
Reviewed at What ran. On a disposable Omarchy worker, Found:
The manual's corrected T1 list is right: A1708 is the two-port MacBookPro13,1 without a T1, A1706 the four-port 13-inch, A1707 the 15-inch. Overlapping pull requests. These cover the same hardware in different ways and would conflict or duplicate work if both landed:
#12968 (draft, audio recovery on this model) complements this one rather than competing with it. Which approach to take is the maintainer's call, so none of these was brought to ready. Second opinion. Codex Medium reviewed it too. It agreed on the package ordering, the migration timestamp and the manual (independence isn't guaranteed). It raised the marker override and the test stub ignoring its pattern on its own, and I confirmed both against the code and on the worker. It couldn't read the competing diffs, so it didn't rank them. Next: waiting on the maintainer to choose between the overlapping approaches and to land omacom/omarchy-pkgs#182. The three fixes above are yours, if this is the approach they pick. |
[Medium impact] No actionable issue remains from the changes since the previous review. SummaryAdds
No new actionable findings were accepted. No previous review threads were supplied. Reviews (2) · Last reviewed commit: "Move the kernel-module update gate to it..." · Reviewed by Greptile |
|
Looked again at Classification is unsettled, so the earlier Still open from the earlier review, unchanged at this head:
Also new: this branch no longer merges cleanly into On the new commit: the interface it expects ( Next: waiting on the maintainer to settle what this pull request is, and whether the update gate belongs in it. It also still needs them to choose among the overlapping Intel Mac pull requests (#12684, #12686, #12689, all drafts) and to land omacom/omarchy-pkgs#182. |
The gate now lives in omacom#15905, rebuilt on quattro's boot check and extended to the linux-omarchy kernel. This reverts commit e0ad4dc. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Thanks for both reviews. Here's where this stands now. Update gate split out. The kernel-module check now has its own PR: #15905. It is rebuilt on current Packages first. omacom/omarchy-pkgs#182 has been updated for Findings accepted. I'm not disputing any of the three code findings. If this is the approach you pick, I'll:
Overlap with the Intel Mac series. That choice is yours. I've offered my MacBookPro13,1 (A1708) for attended testing of #12686, #12689 and #12684, and proposed #182 as the package layer for this model on the series' package PRs. Until you decide, I'm converting this to a draft so it doesn't read as ready. |
Summary
Depends on omacom/omarchy-pkgs#182.
Validation
Deep suspend and hibernation are not supported on MacBookPro13,1. The reference-device deep-suspend test left both analog audio outputs silent until reboot, so no experimental downstream workaround is included. See the upstream deep-suspend audio proposal and jack-detection issue for technical background.