Skip to content

Install the pre-T2 FaceTime HD camera driver and firmware - #11381

Open
rand0mdud3 wants to merge 6 commits into
omacom:quattrofrom
rand0mdud3:fix-facetimehd-pre-t2
Open

rand0mdud3 wants to merge 6 commits into
omacom:quattrofrom
rand0mdud3:fix-facetimehd-pre-t2

Conversation

@rand0mdud3

@rand0mdud3 rand0mdud3 commented Sep 11, 2026 •

Copy link
Copy Markdown

Fixes #11373.

Pre-T2 Macs' built-in FaceTime HD camera (Broadcom 1570) has no in-tree driver: the PCI function sits driverless, no /dev/video exists, and Omarchy references the stack nowhere. This adds install/hardware/apple/fix-facetimehd.sh (gated on Apple DMI + 14e4:1570), wired into all.sh, plus migration 1789743826.sh sourcing the leaf for existing installs. It installs facetimehd-firmware + facetimehd-dkms-git via omarchy-pkg-aur-add and best-effort modprobes on live sessions (PCI alias binds it at boot). Never fatal, following fix-synaptic-touchpad.sh: failed installs warn, chroot modprobe mismatches stay quiet.

Proven on MacBookPro11,5, not just mocked: Apple's firmware CDN served the download (hashes OK), DKMS built clean against 7.2.3-arch1-3, modprobe created /dev/video0 reporting 1280x720@30, and three frames captured (varied sizes, live sensor). live leaf re-run no-ops cleanly with the camera up.

Tests: test/shell.d/apple-facetimehd-test.sh 9/9 (gating incl. older Apple vendor string, non-clobber paths, failed-install warning path, migration). ./test/cli green.

@omarchybot

Copy link
Copy Markdown
Collaborator

Reviewed at 24760fc against quattro. The migration works, but on a fresh install this change never installs the camera driver.

What was checked. I tested on a disposable Omarchy VM running 7.2.5-3-omarchy. It has no 1570 camera, so lspci and the DMI vendor were stubbed to look like a pre-T2 Mac.

  • ./test/cli passes, and so do test/shell.d/apple-facetimehd-test.sh (9/9) and t2-hardware-test.sh (6/6).
  • Migration path, run as the user, works. migrations/1789743826.sh built facetimehd-dkms-git against the running kernel (/lib/modules/7.2.5-3-omarchy/updates/dkms/facetimehd.ko.zst), installed facetimehd-firmware (firmware.bin), and exited 0.
  • Install path, run as root, installs nothing. During an ISO install, install/hardware/all.sh is sourced by bin/omarchy-apply-hardware, which refuses to run unless it is root. In that context install/hardware/apple/fix-facetimehd.sh:12 calls omarchy-pkg-aur-add, and makepkg refuses both packages: ==> ERROR: Running makepkg as root is not allowed. The leaf prints its warning, returns 0, and neither package gets installed. The tests stub omarchy-pkg-aur-add, so they can't see this. A fresh install also marks existing migrations as done, so a pre-T2 Mac installed from the ISO would never pick the driver up through the migration either.

Why this needs a decision rather than a patch. Every other DKMS hardware driver in install/hardware/ installs through omarchy-pkg-add from Omarchy's own package repository: macbook12-spi-driver-dkms, broadcom-wl-dkms, yt6801-dkms, tuxedo-drivers-nocompatcheck-dkms. Each is listed in install/omarchy-other.packages, which the ISO builder mirrors so offline installs work. Neither facetimehd package is in that repository today. Fixing the install path means either packaging both there and switching this leaf to omarchy-pkg-add, or deciding that only the migration and the manual path are supported. That choice involves another repository and the redistribution of Apple's camera firmware, so it belongs to the maintainer and isn't something to push onto this branch.

Smaller, same leaf: fix-facetimehd.sh:19-22 runs a bare modprobe. When the migration runs it as the user, that load can never succeed, so the "takes effect after reboot" warning prints every time. sudo modprobe would load it on a live session. The other root-scoped leaves, such as fix-spi-keyboard.sh, already use sudo.

The camera itself was not reproduced here. Your report on a MacBookPro11,5 is the only hardware evidence. The PR body names migration 1789095456.sh, but the file is 1789743826.sh.

Second opinion: none ran. The configured reviewer (Codex Medium) answered a ping, but today's review budget was spent, so this review is one model's (Claude Opus 5.5).

Next: this waits on the maintainer to choose how the facetimehd packages should be shipped.

The migration runs as the user, so a bare modprobe can never succeed and the "takes effect after reboot" warning prints every time. Follow fix-spi-keyboard.sh and sudo the load; the -qn probe stays bare (works unprivileged). Test asserts the sudo line.
@rand0mdud3

Copy link
Copy Markdown
Author

Good catches, all three addressed or answered:

  • sudo modprobe pushed (4bdee1e): the live load now runs through sudo like fix-spi-keyboard.sh; the -qn probe stays bare since it works unprivileged. Test extended with a sudo modprobe facetimehd assertion — suite still 9/9.
  • PR body filename fixed: 1789743826.sh, thanks.
  • Fresh-install path: agreed this needs the maintainer's call, not a branch patch. If the decision is Omarchy-packaged binaries, I'm happy to do that packaging in omarchy-pkgs (dkms module + firmware, following the existing -dkms precedent) — with the caveat that Apple's firmware redistribution needs a policy answer first; the AUR package sidesteps it by downloading at build time, and an Omarchy package would need the same shape or a legal OK. If the decision is migration/manual-only, this PR is already that, and I'd update the body to say the ISO path is out of scope.

@greptile-apps

greptile-apps Bot commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Medium impact] The changes affect camera and hibernation behavior on Macs with one specific camera.

The PR still needs a working package-install path for fresh installs before merging.

Findings

  1. P1 Fresh installs miss camera support ▶
  2. P2 Camera failures lack test coverage ▶

Summary

Adds FaceTime HD camera support for matching pre-T2 Macs through hardware setup and a migration.

  • Pre-T2 Macs with the Broadcom camera can use their built-in FaceTime camera.
  • The camera driver stays out of hibernation and returns after wake.

Reviews (4) · Last reviewed commit: "Clear the facetimehd marker at the start..." · Reviewed by Greptile

Comment on lines +12 to +13
omarchy-pkg-aur-add facetimehd-firmware facetimehd-dkms-git ||
echo "Warning: could not install the FaceTime HD camera packages" >&2

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Fresh installs miss camera support

omarchy-apply-hardware runs this script as root, but omarchy-pkg-aur-add calls yay without switching users. Building these AUR packages fails because makepkg refuses to run as root. Neither package is in the ISO package lists, so offline installs cannot supply them either.

Setup warns and finishes without camera support. First-user setup then marks the migration complete, so it will not automatically retry. Ship the packages through the ISO package source and install them with omarchy-pkg-add; keep AUR builds in a non-root, online path.

Knowledge Base Used:

Comment on lines +52 to +59
cat >"$stub_bin/modprobe" <<'SH'
#!/bin/bash

printf 'modprobe' >>"$TEST_LOG"
printf '\t%s' "$@" >>"$TEST_LOG"
printf '\n' >>"$TEST_LOG"
(( ${MODPROBE_FAIL:-0} == 0 ))
SH

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Camera failures lack test coverage

No test sets MODPROBE_FAIL, so neither a missing module nor a failed live load is checked. The failed-package case also does not assert the warning it claims to test. These tests can stay green if the quiet probe or nonfatal warning behavior breaks.

Give the modprobe stub separate results for the probe and load. Check that a failed probe skips loading and that a failed load warns without returning an error. Capture and assert the package warning too.

@omarchybot

Copy link
Copy Markdown
Collaborator

Re-reviewed at 4bdee1e against quattro. The sudo modprobe change works. The fresh-install path still installs nothing, and the migration has one more gap, below. Both come down to how the packages ship, so this still waits on the maintainer.

What was checked. On a disposable Omarchy VM running 7.2.5-3-omarchy, with lspci and the DMI vendor stubbed to look like a pre-T2 Mac, since the VM has no 1570 camera:

  • ./test/cli passes, and so do test/shell.d/apple-facetimehd-test.sh (9/9) and t2-hardware-test.sh (6/6).
  • The live load now works from the migration. Run as the user at the previous head (24760fc), migrations/1789743826.sh built and installed both packages but printed "could not load facetimehd (takes effect after reboot)" and left the module unloaded. At 4bdee1e the same run printed no warning and facetimehd was loaded. With the module unloaded and the old leaf run again, the warning came back. So the old leaf fails, the new one passes, and reverting the change brings the failure back.
  • The install path is unchanged. With both packages removed, sourcing install/hardware/apple/fix-facetimehd.sh as root, which is how bin/omarchy-apply-hardware runs it during an ISO install, still hits ==> ERROR: Running makepkg as root is not allowed. The leaf prints its warning and exits 0, and neither package is installed. The previous comment covers why fixing this is a packaging decision rather than a patch to this branch. Your offer to package both in omarchy-pkgs is one of the two options, and the firmware redistribution question you raise is part of that decision.

New: a failed install in the migration is never retried. fix-facetimehd.sh:12-13 turns a failed omarchy-pkg-aur-add into a warning, so the migration exits 0. bin/omarchy-migrate then writes the migration's completion marker, and later updates never run it again. That happens if the AUR is unreachable, Apple's firmware CDN is down, or the DKMS build fails. Elsewhere, a migration that fails stops omarchy-migrate and is retried on the next run. Making the leaf never fatal suits the install path, where a camera must not halt setup. The migration doesn't need the same protection, and it is the only path that installs the packages today. How to fix it depends on the packaging choice above, so I haven't pushed a change.

The camera itself was not reproduced here. Your MacBookPro11,5 test, run at the earlier head, is still the only hardware evidence.

Second opinion: Codex Medium reviewed the new commit and the full diff. It agreed that the sudo change is correct both as the user and as root, and that the install-path finding still holds. It agreed after the earlier finding was already written down, so its agreement isn't independent. The migration-retry finding above is its own, and I confirmed it against bin/omarchy-migrate. It found nothing wrong with the gating or with re-running. This review was otherwise written by Claude Opus 5.5.

Next: this waits on the maintainer to decide how the facetimehd packages should ship. That decision also settles the migration retry.

@hyuricane

Copy link
Copy Markdown

Thanks for working on this!

One important compatibility finding for this driver: facetimehd breaks system hibernation on pre-T2 MacBooks. When the driver is loaded, triggering systemctl hibernate causes a hard system lockup at PM: hibernation: hibernation entry because the driver's power management callback fails during kernel device freezing (this is also the root cause behind #11351).

To avoid breaking hibernation for pre-T2 users who install this driver, could we bundle a system-sleep hook alongside it in fix-facetimehd.sh?

Installing an executable hook (0755) at /usr/lib/systemd/system-sleep/facetimehd:

#!/bin/sh
case "$1" in
  pre)
    modprobe -r facetimehd 2>/dev/null || true
    ;;
  post)
    modprobe facetimehd 2>/dev/null || true
    ;;
esac

Tested and verified on a MacBookAir7,2 with the 14e4:1570 camera: with this hook in place, both the camera and hibernation work cleanly without freezing.

@rand0mdud3

Copy link
Copy Markdown
Author

A caveat this installer would introduce, worth deciding before merge.

On a MacBookPro11,5 with facetimehd (DKMS, 14e4:1570) loaded, #11351 (comment) reports that hibernation hard-freezes at PM: hibernation: hibernation entry, with fthd_pci_suspend tearing down state during the device-freeze, and that a systemd-sleep hook unloading the module on pre and reloading on post fixes it. Our unit had the driver loaded throughout the hibernate attempts recorded in #11351, so the correlation holds here too, though our symptom is resume-side (frozen lock screen, dead input, no journal) rather than a freeze at entry.

If that holds up, this PR hands pre-T2 users a camera and takes away hibernation on the same machines, so the install leaf should probably ship that sleep hook alongside the module, or the migration should, and the PR body should say so.

Happy to implement it here — a default/systemd/system-sleep/facetimehd pre/post unload-reload pair installed next to fix-spi-keyboard.sh's hook, with a shell test — if that's wanted. I have not tested the hook itself: S3 with the module loaded works on this unit (deep S3 cycles, camera still enumerated after), but a hibernate cycle needs its own run and this machine is not currently set up to hibernate cleanly.

The driver's PCI suspend runs inside the kernel's device-freeze and the machine
deadlocks at "PM: hibernation: hibernation entry", before the image is written,
so installing the camera took hibernation away from the pre-T2 Macs that have
it. A system-sleep hook unloads the module for hibernate and loads it again
after resume. S3 is unaffected and the hook leaves it alone.

The leaf installs the hook next to the packages; failing to do so warns, the
same as the package install, so an optional camera never halts hardware setup.
@rand0mdud3

Copy link
Copy Markdown
Author

Implemented the hook in 9051faaf, since the caveat is ours to fix rather than document:

  • default/systemd/system-sleep/facetimehd — pre unloads the module when the action is hibernate, post loads it again. Gated on hibernate deliberately: S3 is clean with the driver loaded on this unit, so the hook keeps its blast radius to the failure reported.
  • install/hardware/apple/fix-facetimehd.sh installs it next to the packages with install -Dm755. A failure warns instead of aborting, matching how the package install already behaves, so an optional camera never halts hardware setup.
  • The migration runs the same leaf, so existing installs get the hook too.
  • test/shell.d/apple-facetimehd-test.sh gains the install assertion and three hook cases: unloads for hibernate, does nothing for suspend, loads again after resume. 13/13 pass, and the new cases fail with the hook removed.

Not verified: the hang itself, and whether the hook clears it. This unit's hibernation is also not set up (resume.conf absent, no resume=), so the test needs both repaired first; I'll report back with the result when I run it.

One thing worth a second pair of eyes before merge: modprobe -r facetimehd can pull videobuf2_* with it when nothing else holds them, and post reloads only facetimehd. That is harmless here (the driver pulls its dependencies back), but if someone finds a case where uvcvideo loses a shared videobuf2 module across hibernate, the hook should pin them with modprobe -r facetimehd && modprobe -ra videobuf2... or simply not unload. I did not see it on this unit.

Comment thread test/shell.d/apple-facetimehd-test.sh Resolved
@geeknees

Copy link
Copy Markdown

Additional hardware validation: MacBook8,1 (Early 2015), Omarchy edge, kernel 7.2.15-2-omarchy.

  • The facetimehd/0.7.0.1 DKMS module is installed on this kernel.
  • The real /dev/video0 camera produces video, works in continuous capture, and can be reopened after suspend/resume.
  • On this particular setup, Chrome / Google Meet did not accept the camera's direct video mode. A working local workaround is ffmpeg reading /dev/video0 at 848×588, 30fps, scaling/padding to 1280×720, then publishing YUV420p to /dev/video10 using v4l2loopback/0.15.4 (exclusive_caps=1). This is controlled on demand by an Omarchy plugin.
  • This virtual-camera workaround is not a requirement for basic facetimehd capture. It should remain optional and avoid running the camera continuously when unused.

The installed driver was built from a pinned external source in my integration PoC, rather than directly through the packaging path proposed by this PR, so this result does not validate the PR's AUR/package dependency resolution or its fresh-install behavior. The initial ISO was also customized.

Integration PoC: https://github.com/geeknees/omarchy/tree/macbook81/poc-2026-11

@rand0mdud3

Copy link
Copy Markdown
Author

Useful, and one detail is worth chasing because it may be the driver version rather than the camera.

This unit exposes 1280×720 only, on the AUR packages this PR installs:

$ dkms status | grep facetimehd
facetimehd/0.7.2.r10.gc5c7fac, 7.2.15-2-omarchy, x86_64: installed
$ pacman -Q facetimehd-dkms-git facetimehd-firmware
facetimehd-dkms-git 0.7.2.r10.gc5c7fac-1
facetimehd-firmware 1:1.43_5-2
$ v4l2-ctl --list-formats-ext -d /dev/video0
[0]: 'YUYV'   Size: Discrete 1280x720   Interval: 0.033s (30.000 fps)
[1]: 'YVYU'   Size: Discrete 1280x720   Interval: 0.033s (30.000 fps)

Two discrete sizes only, both 1280×720 — no 848×588 entry at all. Your facetimehd/0.7.0.1 is older than the 0.7.2.r10 in the AUR packages here, and the mode list is set by the driver, not by the sensor, so the 848×588 you had to pad from may be that version's only mode rather than a property of the MacBook8,1 camera.

If that is the explanation, the Chrome/Meet workaround you built is version-specific and would not be needed after a rebuild against the AUR facetimehd-dkms-git. The check that settles it:

v4l2-ctl --list-formats-ext -d /dev/video0     # before and after the rebuild

If the newer driver lists 1280×720 there, that also gives this PR the fresh-install/package-path validation your own note correctly says your PoC does not provide, since you would be building exactly what the leaf installs.

Two things from this side that match yours: the camera is fine across S3 here too (deep cycles, reopened afterwards), and the hibernation hook added in 9051faaf is hibernate-only — it leaves suspend alone, so it changes nothing about the behaviour you tested.

omarchybot and others added 3 commits November 16, 2026 23:51
The sudo stub runs its command for real, so the hook install reached /usr/lib/systemd/system-sleep on whatever machine ran the suite: as root it left a real facetimehd hook behind, and as a user it failed while the assertion, which reads only the call log, still passed.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…aded

hybrid-sleep writes the same hibernation image as hibernate, so it goes through the same device-freeze the driver hangs in, but the hook only unloaded for hibernate. And post loaded the driver after every wake, suspend included, so a driver the user had removed came back on resume. The hook now leaves a marker in /run when it unloads the module and reloads only when that marker is there, following the yoga-slim7x-lid-wake hook.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Codex Medium <noreply@openai.com>
Co-Authored-By: muse-wonder via pi, thinking high <noreply@pi.dev>
A hibernate whose post never ran left the marker behind, so a later suspend reloaded a driver the user had since removed. Each pre now clears it first, so the marker only ever means this cycle unloaded the driver. The hybrid-sleep and suspend-then-hibernate cases now assert the reload as well as the unload.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Codex Medium <noreply@openai.com>
Co-Authored-By: muse-wonder via pi, thinking high <noreply@pi.dev>
@omarchybot

Copy link
Copy Markdown
Collaborator

Re-reviewed the new hibernation hook from 9051faa against quattro. It does what it says for plain hibernate. I pushed three fixes: one to the test and two to the hook. The branch is now at b13bbb7. The fresh-install and migration-retry questions from the earlier reviews haven't changed and still wait on the maintainer.

What I pushed, and why

  • c0d21c9, test only. The test's sudo stub runs its arguments for real, so install -Dm755 reached the real /usr/lib/systemd/system-sleep. When I ran the suite as root on a disposable VM, it left a real facetimehd hook on the machine. Run as a normal user, the install failed with "Permission denied" and the "installs the hibernate hook" assertion still passed, because it only reads the call log. An install stub now catches it. Greptile raised the same thing.
  • ef57fa9, the hook. hybrid-sleep writes the same hibernation image as hibernate, so it goes through the same device freeze, but the hook only unloaded the driver for hibernate. Also, post ran modprobe facetimehd after every wake, plain suspend included, so a driver someone had removed on purpose came back on resume. The hook now unloads for hibernate and hybrid-sleep (including the hibernation step of suspend-then-hibernate), but only when the module is loaded. It leaves a marker in /run when it unloads, and post reloads only when that marker is there. That is the same pattern default/systemd/system-sleep/yoga-slim7x-lid-wake uses.
  • b13bbb7, the hook. If a sleep's post never ran, the marker stayed behind, and a later suspend would reload a driver the user had since removed. Each pre now clears the marker first. The hybrid-sleep and suspend-then-hibernate cases in the test now check the reload as well as the unload.

What was checked. All of this ran on a disposable Omarchy VM on 7.2.15-2-omarchy. The VM has no 14e4:1570 camera, so lspci and the DMI vendor were stubbed to look like a pre-T2 Mac.

  • test/shell.d/apple-facetimehd-test.sh passes at the final head, 16/16, both as a user and as root, and running it as root no longer leaves a file behind. Each new hook case fails against the earlier hook: hybrid-sleep, the stale marker, a driver the user removed, and the reload after hybrid-sleep. t2-hardware-test.sh (6/6) and ./test/cli passed at 9051faa, and the later commits touch only the hook and this test.
  • I ran migrations/1789743826.sh as the user. It built facetimehd-dkms-git 0.7.2.r59, installed facetimehd-firmware, loaded the module and installed the hook. I then ran the installed hook with each SYSTEMD_SLEEP_ACTION and argument that systemd-sleep passes, as root, and checked lsmod after each step. At the final head:
    • Hibernate, hybrid-sleep and the hibernation step of suspend-then-hibernate unload the driver, and their post loads it again.
    • Plain suspend leaves it alone.
    • A driver the user unloaded stays unloaded after both suspend and hibernate, including when an earlier hibernate never got its post.
  • Sourcing the leaf as root still prints Running makepkg as root is not allowed and installs neither package. That is how bin/omarchy-apply-hardware runs it during an ISO install. It does now install the hook. The hook does nothing while the module is missing.

Not verified. No real hibernation ran. A VM can't reproduce the hang, so nothing here shows that unloading the driver avoids it on a real Mac. @hyuricane, your MacBookAir7,2 test used a hook that unloaded on every pre. This one only unloads for hibernate and hybrid-sleep, and reloads only what it unloaded. If you can run hibernate, resume, and then open the camera at b13bbb7, that would be the hardware evidence this change still lacks.

Left for you, @rand0mdud3

  • The PR body doesn't mention the sleep hook yet. It should say what the hook does and that it is installed into /usr/lib/systemd/system-sleep.
  • The test file conflicts with the Tests section of quattro's AGENTS.md in three places:
    • It tests a migration: the migration grep at lines 15-17 and run_migration at lines 121-140.
    • It greps all.sh for the line it adds, at lines 11-13.
    • It adds a new file, where the rules ask to extend an existing one; t2-hardware-test.sh already builds the same Apple stubs.
  • The hook cases and the hardware gating are real logic and worth keeping.

Second opinion. Codex Medium and muse-wonder (via pi, thinking high) reviewed three rounds. The hybrid-sleep gap, the unconditional reload and the stale marker were their findings, not mine. I confirmed each against the real driver on the VM before fixing it. Both agreed the install stub was right, and the last round, on b13bbb7, found nothing more. They also pointed out that the leaf installs the hook directly with install -Dm755, while bin/omarchy-hibernation-setup stages its hooks first. It works either way, so I left it as it is. The rest of the review was by Claude Opus 5.5.

Next. This waits on the maintainer to decide how the facetimehd packages ship. That decision also settles whether a failed install in the migration should be retried.

@rand0mdud3

Copy link
Copy Markdown
Author

Re-verified b13bbb71 here, and two of the three fixes correct defects that were mine:

  • The install stub (c0d21c9) — correct, and the same class of mistake I made on Keep hibernation resume offset in sync with the swapfile #13768: my sudo stub ran commands for real, so as root the suite would have written a real hook into /usr/lib/systemd/system-sleep, and as a user it failed while the log-only assertion still passed. Running the suite now leaves that directory byte-identical (md5sum of its contents before and after), 16/16 pass.
  • Reload only what pre unloaded (ef57fa9) — this was a real defect in my version: post loaded the module after every wake, S3 included, so a driver the user had deliberately removed came back. The marker is the right shape, and hybrid-sleep belongs in the unload condition for the reason you give: it writes the same image through the same device-freeze.
  • Clear the marker each pre (b13bbb7) — correct for the hibernate whose post never runs, which is not hypothetical here: this machine aborts hibernation before the image is written (Hibernation aborts with ENOMEM inside suspend_nvs_save() after the image preallocation consumes all free memory (XPS 13 DX13260, 7.2.15-1-omarchy) #17824), so an aborted cycle is the common case rather than the edge.

Hand-run against the real module on this 11,5, with only the marker path overridden:

pre hibernate   → module 1 → 0, marker created
post hibernate  → module 0 → 1, marker removed
pre suspend     → module stays 1, marker stays absent, no modprobe call

So the hook is hibernate/hybrid-only as intended, and S3 is untouched.

Unchanged caveat: the end-to-end path still cannot be tested on this board, because no hibernation image is ever written here — that is the #17824 abort, not the camera. The hook's behaviour across the actual freeze is therefore still verified only by construction and by hyuricane's report on #11351, not by a completed cycle.

@omarchybot

Copy link
Copy Markdown
Collaborator

Thanks for running the hook on the MacBookPro11,5 against the real module, @rand0mdud3. Your results match the VM's. pre hibernate unloads the driver and post loads it again. pre suspend leaves it alone. The head is still b13bbb7.

This time the review also compared this PR with the other open PRs for the same camera. The one I'm recommending to the maintainer is #12067, not this one.

Why. This PR is the oldest, and the oldest fix wins unless a newer one handles a case it misses. It misses fresh installs:

  • bin/omarchy-apply-hardware runs install/hardware/all.sh as root. At install/hardware/apple/fix-facetimehd.sh:12, makepkg refuses to build omarchy-pkg-aur-add's packages as root (Running makepkg as root is not allowed). On a disposable VM the leaf installed neither package and still returned 0.
  • Because it returns 0, a failed AUR build on an existing install also gets migrations/1789743826.sh marked done. bin/omarchy-migrate touches the marker after any zero exit, so the migration is never retried.

Publishing packages wouldn't fix either case, because this PR builds from the AUR. #12067 installs facetimehd-dkms, facetimehd-firmware and facetimehd-data with omarchy-pkg-add. That works both as root during an install and from a migration. #12067 can't land until those three packages are published in [omarchy] (omacom/omarchy-pkgs#556 and #182 are open). That's a missing dependency, not a defect in its code. quattro is going the same way: #19168 just moved the T2 Mac packages into the Omarchy repository.

The other two PRs don't change the choice:

What this PR has that's worth keeping

What was checked. I read all four PRs against the current quattro (3b36b9e), along with bin/omarchy-apply-hardware, bin/omarchy-pkg-aur-add and bin/omarchy-migrate. The root-install result above, and the "target not found" result for #12067's packages, come from earlier runs on disposable Omarchy VMs. Nothing new ran on a VM this time, because the head hasn't changed.

Second opinion. Codex Medium and muse-wonder (via pi, thinking high) each compared the four PRs. They had the diffs and the VM results, but not my conclusion. Both picked #12067 for the same reason. Both also named the live module load and the sleep hook as the parts of this PR worth keeping. Their independence from my reasoning isn't guaranteed. Both noticed the silent failed unload in the hook. The rest of the review was by Claude Opus 5.5.

Next. This waits on the maintainer to choose between this PR and #12067.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working compatibility Make Omarchy work better on everything!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

No driver path for the pre-T2 FaceTime HD camera (Broadcom 1570)

4 participants