Repository navigation
Conversation
Automated AI review
Verified: detection matches the driver's only PCI ID ( As wired into Fresh ISO installs on
|
| Case | Hardware IDs | AUR step | Result |
|---|---|---|---|
| PR head | A1466 camera + BCM4360 | fails | leaf exits 1, fix-bcm43xx.sh never runs, hardware setup exits 1 |
| Base branch | same | same | completes, broadcom-wl-dkms installed |
| PR head (control) | same | succeeds | both leaves complete |
Impact: the hardware this PR targets cannot complete a fresh install from the ISO.
Suggested change: follow the pattern other DKMS drivers use: build the package in omarchy-pkgs, list it in install/omarchy-other.packages (currently broadcom-wl-dkms, macbook12-spi-driver-dkms, yt6801-dkms and others), and install it with omarchy-pkg-add. The alternative is to move the AUR build out of root ISO setup into a user-context step with network, such as a migration. Either way, camera setup should not be able to halt the OS install. This would be the only omarchy-pkg-aur-add call under install/.
linux-headers is not the header package Omarchy boots
omarchy-pkg-add linux-headers installs headers for Arch's stock linux. Fresh installs boot linux-omarchy (or linux-t2 on T2 Macs), and the ISO installs that kernel's matching headers before hardware setup. agents/skills/install-scripts.md states: "The base install supplies matching kernel headers before hardware setup. DKMS installers should install their driver packages and assume the headers exist."
Impact: the package gives the booted kernel nothing it lacks. Without the stock kernel's modules tree, Arch's DKMS hook prints ==> ERROR: Missing <kver> kernel modules tree for module ... for each DKMS module when these headers are installed (the hook still exits 0). It is also an extra package that must be available at this step.
Suggested change: drop the linux-headers line.
Existing installs do not receive the fix
omarchy update runs migrations but not omarchy-apply-hardware, and the PR adds no migration. The leaf's comment targets "an already-running install", and neighbouring hardware fixes ship a companion migration (for example migrations/1786391100.sh for the brcmfmac supplicant quirk).
Impact: existing A1466 owners get no camera support from omarchy update.
Suggested change: add a guarded migration that detects 14e4:1570. Migrations run as the user with network, which is the context where omarchy-pkg-aur-add works if the AUR route is kept.
The bdc_pci unload and its blacklist comment are stale
bdc_pci, the driver that used to bind14e4:1570, was removed from Linux in 5.12 (commit7766cafea0ec, "usb: bdc: Remove the BDC PCI driver"). Thelinux-omarchyandlinux-t2configs have only the platformUSB_BDC_UDC, somodprobe -r bdc_pciis a no-op.- The comment says facetimehd's DKMS package blacklists
bdc_pcifor future boots. The current AURfacetimehd-dkmsPKGBUILD strips upstream'sMODULES_CONFblacklist line, and neither AUR package installs a modprobe file. - Both
modprobecalls discard errors (2>/dev/null || true), so a failed DKMS build still reports success. Inside the ISO chroot,modprobe facetimehdlooks for a module for the live installer kernel rather than the installed system's kernel.
Impact: the unload does nothing on current kernels, the comment misdescribes what the package blacklists, and a failed DKMS build is reported as success.
Suggested change: remove the bdc_pci unload and comment. Keep any immediate modprobe facetimehd to a booted system, and report when it fails.
Optional test improvement: test/shell.d/facetimehd-test.sh passes on the PR head and fails on the base branch. However, mutations that remove the bdc_pci unload or the linux-headers install (or swap in linux-omarchy-headers) make it fail, so it will need updating alongside the changes above. Because it stubs both package helpers, it cannot detect the install-halting failure. Its final label, "installs firmware", covers no firmware step.
Review information
Test scope: source review of the PR, Omarchy's install pipeline and helpers, omarchy-iso's install orchestration and offline mirror build, the AUR facetimehd-dkms/facetimehd-firmware PKGBUILDs, upstream facetimehd 0.7.2, yay, Arch's dkms hook and the kernel bdc history. One sandboxed run (no network, non-root) used the real install helpers with stubbed package manager, lspci, modprobe and sudo, and included mutation checks of the new test. Not tested: an ISO build or VM install, a real Mac or camera, a DKMS build against linux-omarchy, or root yay inside the chroot with network. Whether linux-headers resolves from a built ISO's offline repository was not determined.
AI process: Opus 5.5 Medium coordination and synthesis, independent Opus 5.5 Xhigh and GPT 6 Sol Xhigh technical assessments, Opus 5.5 Medium editorial check.
Opt out: To stop receiving these reviews, reply to this comment saying so.
Hermes review of the updated PRVerdict: changes needed before merge. The live A1466 test is valid, but the install integration is not safe for Omarchy’s actual installation and update paths. Blocking findings
WarningThe I could not submit a formal “request changes” review because GitHub does not allow the PR author to review their own PR, so this is posted as a review comment instead. |
|
Follow-up: I pushed commit
This PR now depends on the package definitions and repository publication in omacom-io/omarchy-pkgs#182. The PR is currently mergeable, but that package PR must land before this one can be built or merged safely. |
|
Validation update: the focused Omarchy test still passes after commit What is not yet proven: a complete fresh ISO build/install using the published repository packages. That requires omarchy-pkgs#182 to merge and the package repository/ISO builder to consume it. |
chessing234
left a comment
There was a problem hiding this comment.
please keep a failed boot-image rebuild retryable in the new migration.
| fi | ||
|
|
||
| modules_conf=/etc/modules-load.d/facetimehd.conf | ||
| if omarchy-pkg-present facetimehd-dkms facetimehd-firmware && [[ -f $modules_conf ]] && |
There was a problem hiding this comment.
please only treat the migration as complete after limine-mkinitcpio succeeds: package installation and facetimehd.conf both happen before that call, so a rebuild failure leaves this guard true on the next run. a failing-rebuild fixture exits 1 first, then exits 0 on retry with only one rebuild attempt and no reboot-required marker, allowing omarchy-migrate to mark it complete without running the remaining driver-loading and reboot-notification steps.
There was a problem hiding this comment.
Fixed in e75f42e. The migration now uses a machine-wide completion marker written only after the initramfs rebuild and setup succeed, so an interrupted/failed rebuild remains retryable even if the packages and modules-load config were already installed. The regression test makes the first rebuild fail, confirms the second migration run retries and completes, and verifies a later run is a no-op. The focused FaceTime test passes.
|
Automated AI review
Outcome: a failed driver build still completes the migration; packages are unpublished. Earlier review: AUR, headers, migration, tests resolved; failed-build success, Still present: a failed build completes the migrationArch's dkms hook returns 0 on a failed build, so the migration still writes its marker; later runs skip. The pinned 0.7.0.2 driver uses Suggested change: fail without the marker if DKMS did not build Reproducer (fails at 92ef771)Reproducer: a facetimehd module that was never built still marks migration 1790297558 completeReviewed commit: Scenario:
The test asserts that the migration does not write its machine-wide completion marker in that state. Run: save the file below as #!/bin/bash
set -euo pipefail
source "$(cd -- "$(dirname -- "${BASH_SOURCE[0]}")" && pwd)/base-test.sh"
migration="$ROOT/migrations/1790297558.sh"
test_tmp=$(mktemp -d)
trap 'rm -rf "$test_tmp"' EXIT
stub_bin="$test_tmp/bin"
calls="$test_tmp/calls.log"
marker="$test_tmp/migration-complete"
mkdir -p "$stub_bin"
: >"$calls"
cat >"$stub_bin/lspci" <<'SH'
#!/bin/bash
printf '%s\n' '02:00.0 Multimedia controller [0480]: Broadcom Inc. and subsidiaries 720p FaceTime HD Camera [14e4:1570]'
SH
# The DKMS build of facetimehd failed. Arch's dkms ALPM hook prints a warning
# and still returns 0, so pacman, and with it omarchy-pkg-add, succeed.
cat >"$stub_bin/omarchy-pkg-add" <<'SH'
#!/bin/bash
printf 'omarchy-pkg-add\t%s\n' "$*" >>"$TEST_LOG"
SH
cat >"$stub_bin/limine-mkinitcpio" <<'SH'
#!/bin/bash
printf 'limine-mkinitcpio\n' >>"$TEST_LOG"
SH
# No facetimehd.ko exists for any kernel: loading it fails, and so does
# looking it up. DKMS still lists the source as added but not installed.
cat >"$stub_bin/modprobe" <<'SH'
#!/bin/bash
printf 'modprobe\t%s\n' "$*" >>"$TEST_LOG"
if [[ $1 == facetimehd ]]; then
echo "modprobe: FATAL: Module facetimehd not found." >&2
exit 1
fi
SH
cat >"$stub_bin/modinfo" <<'SH'
#!/bin/bash
echo "modinfo: ERROR: Module facetimehd not found." >&2
exit 1
SH
cat >"$stub_bin/dkms" <<'SH'
#!/bin/bash
[[ $1 == status ]] && echo "facetimehd/0.7.0.2: added"
exit 0
SH
cat >"$stub_bin/lsmod" <<'SH'
#!/bin/bash
echo "Module Size Used by"
SH
cat >"$stub_bin/omarchy-state" <<'SH'
#!/bin/bash
printf 'omarchy-state\t%s\n' "$*" >>"$TEST_LOG"
SH
cat >"$stub_bin/sudo" <<'SH'
#!/bin/bash
if [[ $1 == tee ]]; then
cat >"${@: -1}"
else
"$@"
fi
SH
chmod +x "$stub_bin"/*
run_migration() {
TEST_LOG="$calls" \
OMARCHY_FACETIMEHD_MODULES_CONF="$test_tmp/modules-load-facetimehd.conf" \
OMARCHY_FACETIMEHD_MODPROBE_CONF="$test_tmp/modprobe-facetimehd.conf" \
OMARCHY_FACETIMEHD_MIGRATION_MARKER="$marker" \
PATH="$stub_bin:$PATH" \
bash -euo pipefail "$migration"
}
status=0
run_migration >"$test_tmp/out" 2>&1 || status=$?
grep -Fxq $'modprobe\tfacetimehd' "$calls" ||
fail "the migration tries to load facetimehd" "$(cat "$calls")"
pass "the migration tries to load facetimehd"
if (( status == 0 )) && [[ -e $marker ]]; then
first_run=$(cat "$calls")
: >"$calls"
run_migration >/dev/null 2>&1
fail "a facetimehd module that was never built does not mark the migration complete" \
"first run exit status: $status, machine-wide marker written
first run output:
$(cat "$test_tmp/out")
first run commands:
$first_run
commands on the next run: $(wc -l <"$calls")"
fi
pass "a facetimehd module that was never built does not mark the migration complete"Actual output at The PR's own test now asserts this behaviour for any load failure. Lines 199-210 of
elif ! sudo modprobe facetimehd 2>/dev/null; then
- echo "Could not load facetimehd now; it is configured to load after reboot." >&2
+ echo "facetimehd did not load; check the DKMS build output above." >&2
+ exit 1
fi
elif ! sudo modprobe facetimehd 2>/dev/null; then
+ if ! modinfo facetimehd >/dev/null 2>&1; then
+ echo "facetimehd was not built; check the DKMS build output above." >&2
+ exit 1
+ fi
echo "Could not load facetimehd now; it is configured to load after reboot." >&2
fiIt also passes the PR's test, once that test gets a printf 'Module Size Used by\nbdc_pci 16384 0\n'
SH
+cat >"$stub_bin/modinfo" <<'SH'
+#!/bin/bash
+exit 0
+SHActual output of this test with change 2 (exit status 0): Change 2 is an illustration. HistoryAt At At New: packages not publishedomacom/omarchy-pkgs#182 is open. The ISO build downloads every listed package, so it would fail on all hardware (not run), and the migration fails, blocking later ones. Suggested change: publish both ( Details
More findingsNew: New: the explicit Still present: the New: overlapping open PRs. #11381, #12067 and #12686 also add New: possible conflict with AUR Optional notes:
Reproducer: lspci pipefail skip (fails at 92ef771)Reproducer:
|
|
Reviewed at Of the four, #12067 looks like the one to build on. It installs the same packages through What this pull request adds beyond that, at
Whichever one lands is also blocked on packaging: neither Second opinion: Codex Medium reviewed this pull request at |
|
Thank you for this, @drbree82. #12067 got there first with a fix for the same problem, so this is closed in favour of it, and the credit stays with the first fix. If it does not cover your case, please say so there. Closed at the maintainer's request. The review comment above has the details; it was done by Claude Opus 5.5 with Codex Medium as a second opinion, whose agreement is not independent. |
Summary
facetimehd-dkmspackage, which brings the required Apple camera firmware.facetimehdimmediately when possible and persist it across boots.Root cause
The A1466 camera is a Broadcom 1570 PCIe device (
14e4:1570), not a USB/UVC webcam. Omarchy had no hardware installer for its out-of-tree driver and firmware, so no/dev/video*node was created and mpv reportedNo such file or directory.Test plan
./test/shell.d/facetimehd-test.sh— passes.bash -n install/hardware/apple/fix-facetimehd.sh test/shell.d/facetimehd-test.sh— passes.git diff --check— passes../test/shell— five unrelated pre-existing failures remain in the agent usage, config, snapper, and package ownership tests; the new test passes.facetimehd-dkmsandfacetimehd-firmware, verified DKMS registration for the running kernel, confirmed thefacetimehddriver bound to PCI device14e4:1570, confirmed/dev/video0, and opened a live 1280x720 30 fps stream with mpv.Verification on target hardware
The target machine reports
Broadcom 720p FaceTime HD Camera [14e4:1570]at02:00.0, matching the detection path in this change.