Repository navigation
Finish system updates when mise tool downloads fail - #16318
Conversation
[Medium impact] The PR appears safe to merge; no blocking issues were found. SummaryA failed mise tool update no longer stops the remaining system update steps.
No actionable new issues or repository-rule violations were found. No previous review threads were supplied. Review checks were read-only; no tests were run.
|
|
Reviewed at 918bea5 against What was checked, on a disposable Omarchy worker:
Second opinion: Codex Medium and muse-spark-1.3-contributor (via pi, thinking high) reviewed the same diff and also found no blocking defect. They read this review's notes, so their agreement is not independent. They raised two points that are behaviour choices rather than defects:
Overlap: #14800 and #14914 change the same mise line in Fixes #16281. Waiting on the maintainer. |
The mise+boot case repeats update-boot-verify-test.sh, since the boot gate never reads the mise result, and the new hook-security block repeats that file's success-path checks: the code between mise and AUR is the same either way. The interactive pass adds nothing over -y.
A failed mise tool download could abort an otherwise successful system upgrade before boot verification and the reboot prompt. Record the mise failure, continue the remaining update steps, and print a warning with
omarchy update miseretry guidance before the reboot prompt.A mise-only failure now completes with a warning. Failed system package upgrades and failed boot verification still stop completion; boot verification failure still suppresses the reboot prompt. Sudo authorization is revoked before AUR work and on exit.
Validation in an updated RC virtual machine:
This also stops the abort in #16054, though not the download timeout behind it.
Fixes #16281