Repository navigation
Conversation
[Low impact] The documentation appears safe to merge; no new actionable issues were found. SummaryDocuments how to keep macOS alongside Omarchy and prepare for Mac-specific recovery needs.
Reviews (4) · Last reviewed commit: "Require the T1 EFI backup before any ins..." · Reviewed by Greptile |
There was a problem hiding this comment.
🟡 Changes recommended
The T1 guidance needs explicit EFI-data backup requirements and a warning against installing conflicting support stacks together.
2 open issues
What changed in this PR
Updates the Mac support manual to document the existing dual-boot installation path and explain recovery considerations for T1 and T2 hardware.
Changes:
- Distinguishes full-disk and free-space installations and links the dual-boot procedure.
- Adds T1 community-project links and kernel-module rebuild guidance.
- Clarifies firmware availability and T2 Wi-Fi recovery requirements.
| File | Description |
|---|---|
manual/44-mac-support.md |
Documents Mac installation choices, recovery prerequisites, and community hardware support. |
Review effort: Balanced
The Known Issues line grouped audio with the Touch Bar under community software, but neither linked project handles audio: T1Bridge's README lists speakers as out of its scope, and mbp-t1-touchbar drives only the Touch Bar. Restore the plain sound line and keep the community-software line to the Touch Bar. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: Codex Medium <noreply@openai.com> Co-Authored-By: muse-wonder <noreply@pi.dev>
|
Reviewed as a documentation change: only One fix was pushed to this branch as d40bdfd. The T1 Known Issues said "Touch Bar and audio support require additional community-maintained software", but neither linked project handles audio, and T1Bridge's README lists speakers as out of its scope. The page now keeps "Sound is not functioning" and limits the community-software line to the Touch Bar. Codex Medium and muse-wonder (via pi, thinking high) both reviewed it. Both flagged the audio wording in their first round, and both found nothing open in a second round at d40bdfd. They agreed with this review, but their independence from it is not guaranteed. This waits on the maintainer, for two reasons:
|
The T1 FDRData backup steps sat under the free-space section, but a full-disk install erases the Apple EFI partition too. Point T1 owners at the backup before any install. The T2 fallback now links the t2linux Wi-Fi guide and says its recovery-image method needs another connection and does not work on the iMac Pro.
|
Thanks for the review. I've pulled d40bdfd and agree with it: T1 speakers need a separate CS8409 driver, which neither linked project provides. That is #15776's scope. I pushed 63e0de9 with two follow-ups:
T2 and #16427 / omacom/omarchy-iso#356: my T2 paragraph describes today's ISO, where a full-disk install can leave a T2 Mac without Wi-Fi. Once omacom/omarchy-iso#356 is in a released ISO and #16427 merges, I'll replace that paragraph with a pointer to #16427's "Wi-Fi Firmware on T2 Macs" section. I'll also stop presenting T2 Wi-Fi as a reason to keep macOS. Until then, the warning stays as it is. Overlap with #15776, #16101 and #16427: I'll rebase this onto whichever of them lands first and merge the overlapping Known Issues and T2 text. |
|
Re-reviewed 63e0de9, focusing on the changes since d40bdfd. The T1 backup warning now covers full-disk installs, and the T2 recovery link, alternative-network requirement and iMac Pro exclusion match the linked upstream guides. The T2 warning also matches Codex High reviewed the revision, with second opinions from Opus 5.5 High and muse-wonder via pi, thinking high. Both agreed that the two revised caveats are accurate; independence from this review is not guaranteed. Both also identified competing T1 guidance in the older #16101. This PR's pre-install EFI backup guidance is being handed to that PR's review for inclusion with credit to @heymaaz. The APFS free-space preparation is separate work, so this is not an exact duplicate and remains open. This waits on the maintainer to decide how to separate the dual-boot instructions from the overlapping T1/T2 material in #16101 and #16427. There is also a current merge conflict in |

Summary
Document the existing free-space installation path and explain why preserving macOS or a recovery path matters on T1 and T2 Macs.
Evidence
git diff --checkpasses.Merge Danger
Door: Two-way
Documentation-only change; it can be reverted independently.
Blast Radius: Mac documentation
Hardware context
Existing documentation
The current Mac support page lists Touch Bar and sound as non-functional on T1 Macs. This PR links the community projects and documents the firmware/recovery precautions involved.
Community Touch Bar stack in use
A 2016 13-inch four-port MacBook Pro running Omarchy with an illuminated Touch Bar and media keys. This illustrates the community setup; this documentation PR does not automatically install or enable these drivers.
Supporting setup record
The tested 2016 MacBook Pro recovery, dual-boot, T1, and kernel-maintenance record is documented in the Omarchy MacBook T1 setup gist. It provides supporting hardware context, not a prerequisite for this documentation change.