Skip to content

Tell T2 Mac owners to save their Wi-Fi firmware before installing - #16427

Open
omarchybot wants to merge 8 commits into
quattrofrom
fix/issue-16287
Open

omarchybot wants to merge 8 commits into
quattrofrom
fix/issue-16287

Conversation

@omarchybot

Copy link
Copy Markdown
Collaborator

The Mac support page tells T2 owners the installer sets up Apple's Broadcom Wi-Fi and Bluetooth firmware. On the only install the page supports, it cannot. install/hardware/apple/fix-t2.sh installs apple-bcm-firmware-fetcher, which takes the firmware from an on-disk macOS volume and nowhere else, and runs in the installed system after the single-OS install has wiped that volume. Its install hook reports the failure and carries on, so the Mac boots with no Wi-Fi interface, and a T2 MacBook has no Ethernet port to get the firmware with.

This corrects the page: it drops the claim from the T2 section and from the general list of fixes, and adds a step before installing that has T2 owners save the firmware with t2linux's tarball method (Method 2) to a second USB drive, with the one command that puts it in place afterwards. For a Mac whose macOS is already gone, it points at t2linux's recovery-image download, which needs another connection and does not work on the iMac Pro. Only the English chapter changes; the translation sync picks it up, per docs/i18n.md.

It does not fix the installer. Fetching the firmware while macOS is still on the drive, then installing it into the target, has to happen in the ISO's installer before partitioning, which is the maintainer's call, so #16287 stays open for it.

Refs #16287

Reviewed by Codex Medium and muse-spark-1.3-contributor via pi, thinking high.

🤖 Generated by Opus 5.5 in Claude Code. Reviewed by Codex Medium and muse-spark-1.3-contributor High.

The Mac support page said the installer sets up Apple's Broadcom Wi-Fi and Bluetooth firmware on T2 Macs. It cannot on the only supported install: fix-t2.sh installs apple-bcm-firmware-fetcher, which only reads the firmware off an on-disk macOS volume, and the single-OS install has already wiped it. The page now says so, and tells T2 owners to save the firmware with t2linux's tarball method before installing, or to use its recovery-image method afterwards.

Co-Authored-By: Codex Medium <noreply@openai.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Oct 23, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 4/5

[Low impact] The PR changes guidance for T2 Mac owners preparing to install.

The PR should not merge while the guide still promises a firmware backup that the installer does not perform.

Findings

  1. P1 Firmware backup does not happen ▶

Summary

Adds a T2 firmware section to the Mac installation guide.

  • T2 Mac owners get firmware-source guidance before installing.

Reviews (5) · Last reviewed commit: "Say the T2 firmware comes from the insta..." · Reviewed by Greptile

@omarchybot omarchybot added the documentation Improvements or additions to documentation label Oct 23, 2026
omarchybot and others added 2 commits October 23, 2026 19:44
A USB volume name often has a space in it, which splits an unquoted path. The page also said the fetcher reads macOS "on the same drive it wipes", which is more than the code shows: it reads an on-disk macOS volume, and the install wipes it.

Co-Authored-By: Codex Medium <noreply@openai.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The page's list of T2 models leaves out several, among them the 2019 and 2020 MacBook Air and the 16-inch MacBook Pro, so an owner who looked their Mac up there could skip saving the firmware. Apple's System Information check covers every model.

Co-Authored-By: Codex Medium <noreply@openai.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@omarchybot omarchybot added verified Omarchy Triage has verified that this issue is ready for final review ready Good to merge labels Oct 23, 2026
@omarchybot

Copy link
Copy Markdown
Collaborator Author

Reviewed as a documentation change: only manual/44-mac-support.md changes, so nothing was run. Every claim on the page was checked against the repository at its head and against the sources it points at. install/hardware/apple/fix-t2.sh installs apple-bcm-firmware-fetcher, which reads the firmware off an on-disk macOS volume, and nothing else installs T2 Wi-Fi firmware. The t2linux guide matches the page: its Method 2 writes firmware.tar to Downloads, the tarball extracts into /lib/firmware/brcm, the recovery-image method needs a connection on Linux, and neither of the Linux-side methods works on the iMac Pro.

Codex Medium reviewed it over three rounds, and three small fixes were pushed to this branch:

  • The extraction command now quotes the path, because a USB volume name with a space in it would split an unquoted one.
  • The page no longer says the installer reads macOS "on the same drive it wipes". The code shows it reads an on-disk macOS volume that the install wipes, and nothing about which drive.
  • The new section no longer sends readers to the page's list of T2 models to find out whether they have one. That list leaves out several T2 Macs, among them the 2019 and 2020 MacBook Air and the 16-inch MacBook Pro, so an owner could skip saving the firmware. It now gives Apple's own check in System Information.

The last round, at 04fc239, found nothing open. Codex also noticed that the T1 list on this page has the port counts of A1706 and A1708 the wrong way round. That was there before this pull request, so it is left out of it. Codex read the same repository and sources, so its agreement is not guaranteed to be independent; the three fixes above are its own findings.

CI is green. This still refers to #16287 rather than closing it, because the installer itself still fetches the firmware after macOS is gone. It now waits on the maintainer.

omarchybot and others added 2 commits October 31, 2026 19:50
The firmware may only be taken from macOS, which a single-boot install wipes before fix-t2.sh runs, so apple-bcm-firmware-fetcher always came up empty. The ISO is to save it before the disk is written, into the firmware stage it already carries into the target for Qualcomm; fix-t2.sh now installs whatever it finds under firmware-stage/apple-bcm into /lib/firmware/brcm and writes the fetcher's record of it, so removing the fetcher removes them as before. The manual drops the manual save for the installer doing it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@omarchybot omarchybot added bug Something isn't working and removed documentation Improvements or additions to documentation verified Omarchy Triage has verified that this issue is ready for final review labels Oct 31, 2026
omacom/omarchy-iso#356 saves the firmware from macOS before the disk is written and installs it into the target's /usr/lib/firmware/brcm, with the fetcher's installed-files record, before omarchy-apply-system runs. It never writes the firmware stage fix-t2.sh read, so that block and its test would only be dead code; fix-t2.sh goes back to quattro's.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@omarchybot omarchybot added documentation Improvements or additions to documentation and removed bug Something isn't working labels Oct 31, 2026
Comment thread manual/44-mac-support.md Outdated

#### Wi-Fi Firmware on T2 Macs

On a Mac with a T2 chip, the Wi-Fi and Bluetooth firmware can only be taken from macOS, so the installer saves it from macOS before it wipes the drive and puts it in place on the new system. Leave macOS installed until then.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Firmware backup does not happen

This paragraph promises that the installer saves T2 firmware before wiping macOS, but no such step exists. fix-t2.sh only installs apple-bcm-firmware-fetcher during target-side hardware setup. Its own comment says the fetch fails once macOS has been wiped.

Owners who follow this advice without saving the firmware can finish installing with no Wi-Fi or Bluetooth. Replace the automatic-backup claim with instructions to save the firmware to a second USB drive before installing and restore it afterwards, as the PR description proposes.

Knowledge Base Used: Hardware, devices, and power

Saving the firmware is best-effort in the ISO: when the macOS volume is gone or unreadable it logs a warning and installs anyway, so the recovery-image fallback applies then too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Codex Medium <noreply@openai.com>
@omarchybot

Copy link
Copy Markdown
Collaborator Author

The maintainer asked for a technical fix rather than a manual step before installing, so this pull request no longer asks T2 owners to save the firmware themselves.

That fix lives in the installer, and it already exists: omacom/omarchy-iso#356 by @piotrsynowiec. Before the disk is cleaned, it runs apple-bcm-firmware-fetcher in the live environment, while macOS is still on the drive. The live ISO boots linux-t2 on a Mac, and that kernel carries the APFS driver the fetcher reads macOS with. It keeps the firmware in /run and copies it into the installed system's /usr/lib/firmware/brcm, together with the fetcher's own record of what it installed, before omarchy-apply-system runs. It extracts the fetcher's script from the package rather than installing it, so the package's install hook never runs while the ISO is built. Nothing in this repository needs to change for it: install/hardware/apple/fix-t2.sh stays as it is on quattro.

What this pull request now changes is manual/44-mac-support.md. The page says the installer saves the firmware from macOS before wiping the drive, so macOS has to stay installed until then. If macOS is already gone, or the installer cannot read it, the install carries on without Wi-Fi, and the page points at the t2linux recovery-image download as the fallback. That fallback needs another connection and does not work on the iMac Pro.

Codex Medium and muse-wonder (via pi, thinking high) reviewed it. Both found that an earlier wording promised the save unconditionally, while #356 is best-effort. The fallback now covers an install where macOS could not be read. That last one-line change has not been through another review round. Codex read the same sources, so its agreement elsewhere is not guaranteed to be independent.

Nothing was run for this pull request, since it changes Markdown only. #356 itself has not yet been tested on a T2 Mac that still has macOS installed; its description says so.

This should merge only once #356 is in an ISO people download. Until then the page describes behaviour the current installer does not have. It waits on the maintainer, and on #356.

The page said the firmware can only be taken from macOS and then offered Apple's recovery image as a source, which reads as a contradiction. The installer reads the Mac's installed macOS; the recovery image is the fallback, and the iMac Pro has only the installed copy.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Codex Medium <noreply@openai.com>
@omarchybot

Copy link
Copy Markdown
Collaborator Author

Pushed 2faf818, a wording fix to manual/44-mac-support.md. The new section said the T2 firmware "can only be taken from macOS", and the next paragraph then offered Apple's recovery image as a source. It now says the installer saves the firmware from the Mac's installed macOS, and that the iMac Pro can only get its firmware from an installed macOS.

The rest of the section was checked against omacom/omarchy-iso#356 at 7ddaf50 and holds. prepare_live calls _stage_apple_t2_firmware() before the disk cleanup. _prepare_target_setup copies the staged files into the new system's /usr/lib/firmware/brcm. A failed or empty fetch logs a warning, and the install carries on without Wi-Fi.

Greptile's inline note, "Firmware backup does not happen", was made against 1570f8e. It is right about quattro and today's ISO: nothing saves the firmware until #356 ships, and that is why this waits on #356. Its suggestion to go back to a manual save step is the approach the maintainer asked to replace.

Two more things for the maintainer. The pull request description still describes the earlier manual-save version: this session has no checked command for editing it, so it is left as it is. And #16673 by @heymaaz rewrites the same T2 paragraphs on this page as part of documenting dual boot. The two will conflict, and #16673 still says a full-disk install may leave a T2 Mac without Wi-Fi.

Codex Medium and muse-wonder (via pi, thinking high) reviewed the section at 8515f9e. muse-wonder found nothing open. Codex could not reach GitHub to read #356, and it raised the wording issue fixed above. Both found nothing open in the fix. Codex read the same sources, so its agreement is not guaranteed to be independent. Nothing was run, since the change is Markdown only.

This still waits on #356 reaching a released ISO, and on the maintainer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant