Repository navigation
Conversation
[Medium impact] The PR appears safe to merge; unsupported arguments stop early and supported calls remain unchanged. Summary
No actionable issues were found. This review checked the code and callers; it did not run tests.
|
|
Thanks for this, @Hamza0101. The guard does what it says: on this head, Two other open pull requests fix #16770 in the dispatcher, where the bug actually comes from: #16944 and #17016. I read all three against This change still adds something #16944 does not: it covers calls that never go through Second opinion: Codex Medium agreed that the guard has no defect and that the branch conflicts with Waiting on the maintainer to choose between the fixes for #16770. |
…nown-arguments # Conflicts: # bin/omarchy-update
|
Merged On #16944: agreed, the router is where #16770 comes from, and it covers |
|
The startup conflict was resolved in 9c63ac5. I checked the revised diff, your reply, #16770 and the current competing fixes. Against current #16944 remains the broader fix for the reported dispatcher bug: it also rejects a typo after GPT-6 in Codex (reasoning effort not exposed) reviewed this revision, with second opinions from Opus 5.5 High and muse-wonder via pi, thinking high. Both agreed that #16944 should carry the broader fix while preserving this endpoint protection; independence is not guaranteed. The reviews also identified the unknown-flag coverage, which I checked against both diffs. This was a source-and-diff comparison on the coordinator; no worker tests ran because this PR remains behind the competing fix, and no code was changed or pushed. Waiting on the maintainer to decide whether to retain this guard separately or include it in #16944. If included there, its direct-call tests should retain Hamza0101's contribution and add an explicit |
omarchy update firmwre(meant:omarchy update firmware) starts a full system update. The router resolves a command it can't find to the nearest one it can, so the typo arrives asomarchy-update firmwre, andomarchy-updateonly ever looks at whether$1is-y. Everything else is ignored: the user confirms what looks like the usual prompt and gets the package prune, the snapshot, the full upgrade, migrations, AUR and mise, which the prompt itself says can't be stopped once started.omarchy update aur pkgdoes the same, and so does-yanywhere but alone. That is #16770.The issue suggests teaching the router to reject a leftover word for every group. That changes how every command receives its arguments and is a bigger call; this does the part that matters most on its own.
omarchy-updatetakes no argument but-y, so anything else is refused first thing, right afterset -e, before the sudo prompt, the lock, the log or any step:It exits 2.
omarchy updateandomarchy update -yare unchanged, and the updater's own re-execs for logging and the lock pass the same arguments through, so they are unaffected. The only caller inside Omarchy,omarchy-channel-set, passes-y.Reproduce on a VM
On
quattrothis shows the usual "Ready to update?" confirmation, and answering yes runs the whole update. On this branch it printsand exits 2 before asking for a password.
omarchy update -y aurandomarchy update aur -ybehave the same way;omarchy updateandomarchy update -yare unchanged.Validation
test/shell.d/update-sequence-test.shgains one case:firmwre,aur pkg,-y firmwreandfirmwre -yare each refused with the usage line, and no step runs, the confirmation included. In an Arch container, with the change, it passes along withupdate-user-path,update-disk-space,update-hook-security,update-boot-verify,channel-sudo-boundary,snapshot-createandsecurity-source-root. Withbin/omarchy-updatereverted, it fails atan update given 'firmwre' is refused.update-lock-test.shfails in that container on the base as well, before this change.bash -n,git diff --checkandscripts/i18n-sync.py extract-scan --checkpass. Not run on an Omarchy install.Human check
omarchy update firmwreshould print the two lines above and return without asking for a password.omarchy updateshould still show the usual confirmation.