Repository navigation
Conversation
`omarchy update firmwre` resolved `omarchy-update`, which ignores extra arguments, so a typo started a full system update. A group parent that documents no operand now reports the unknown command and points at its help. A parent that documents an operand (`omarchy theme set <theme>`) still forwards its leftovers, and `--` keeps everything after it literal.
[Medium impact] The PR appears safe to merge. SummaryThe router now rejects leftover words under commands that have children but document no operands, rather than accidentally running the parent command.
No actionable issues found. Bash syntax checks passed; the full test suites were not run. Reviews (7) · Last reviewed commit: "Correct router guidance and keep coverag..." · Reviewed by Greptile |
quattro's omarchy-agent now documents value-taking options (`--local-model <recipe>`, `--agent <id>`) in omarchy:args, so the dispatcher counts it as taking an operand and forwards `omarchy agent Review this project` to the launcher, which answers with its own `omarchy agent prompt` guidance. The router-path assertion expected the dispatcher's unknown-command error and failed once this branch met quattro. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Alias and metadata routes are dispatched by dispatch_or_help, whose rejection had no test: removing that check left test/cli green while `omarchy up firmwre` ran the parent again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-Authored-By: muse-wonder <noreply@anthropic.com>
|
Thanks @vitally. The fix does what it says, and I pushed two small commits to your branch so it holds on current What was run. On a disposable Omarchy worker I copied the real What I pushed.
Competing fixes. #16777 (older) and #17016 (newer) also fix #16770. This one covers cases both of them miss. #16777 guards only Second opinion. Codex Medium and muse-wonder (via pi, thinking high) reviewed it over two rounds, and the final round on this head found no defects (independence not guaranteed). Neither found a shipped no-operand group parent that legitimately takes a bare word, and my own pass over Waiting on the maintainer to choose between the fixes for #16770. |
A parent whose omarchy:args are only flags must still run when given just a flag (omarchy update -y); the bare-word check must not reject it. Co-Authored-By: Luca Volpe <lucavolpe97@gmail.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
I pushed one more commit to your branch: cbc3ea6 folds in a test from #17016 by @Liukskywalkerr, credited to them as co-author. It checks that a flags-only group parent still runs when it gets only its flag ( What was run. On a disposable Omarchy worker, What I checked. I went through every command in Second opinion. Codex Medium and muse-wonder (via pi, thinking high) reviewed the new commit and found no defects. Independence is not guaranteed. Next. |
Co-Authored-By: muse-wonder via pi, thinking high <noreply@meta.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
I pushed one commit to your branch, 95a57f6, which adds a sentence to the Dispatch section of Review. Claude Opus 5.5 wrote the sentence. The second opinion, Codex Medium and muse-wonder (via pi, thinking high), read it against the code over two rounds. In the first round, muse-wonder found two inaccuracies in the original wording, and the sentence above fixes both. It had claimed every flags-only parent refuses a bare word, which One more case worth knowing about when choosing between the fixes for #16770. Nothing is needed from you. This waits on the maintainer. |
|
CI's only failure here is |
|
Refreshed the branch on current For whoever reviews: #18798 arrived on the same guard while this was waiting, and the added code is the same in both. They differ only in where the docs sentence lives ( |
Keep the group-parent typo guard beside the updated required-argument exit status documentation. Co-Authored-By: GPT-6 High <noreply@openai.com>
Nested command help shows usage without listing subcommands. Keep the error hint accurate, document the matched-command metadata read and flag-value exemption, and drop the direct agent assertion that does not exercise this router change. Co-Authored-By: GPT-6 High <noreply@openai.com> Co-Authored-By: Opus 5.5 High <noreply@anthropic.com> Co-Authored-By: muse-wonder via pi, thinking high <noreply@openrouter.ai>
|
This branch now merges cleanly onto current On a disposable Omarchy worker, the reproduction fails on GPT-6 High in Codex reviewed the change and audited all 19 affected group parents for undeclared positional operands. Opus 5.5 High and muse-wonder via pi (thinking high) reviewed the corrected head and found no remaining actionable defects. Independence is not guaranteed. #16777 remains open for validation inside the updater, including unknown flags and direct binary calls. Nothing is needed from the author here; awaiting the maintainer. |
Fixes #16770.
omarchy update firmwreresolvedomarchy-update, which ignores extra arguments, so a typo started a full system update and the confirmation prompt described the whole update instead of what was typed. The same applied to every group parent that takes no operand.How
bin/omarchynow looks at the leftovers after a resolved command before executing it (find_unknown_subcommand, used on both the direct-route and full-table paths):omarchy-<name>-*children.# omarchy:argsis empty or flags only), soomarchy theme set <theme>andomarchy hook <name> argsstill forward.omarchy update -y firmwreis caught too, and a--keeps everything after it literal.omarchy update firmware,omarchy update aur pkgs), and--helpbehaves as before.omarchy up firmwre).The operand contract is documented in
agents/skills/command-metadata.md.One visible change:
omarchy agent Review this projectnow fails at the dispatcher (pointing atomarchy agent --help) instead of reachingomarchy-agent's own "useomarchy agent prompt" error. The launcher's guidance is still there for callers that invokeomarchy-agentdirectly, and the test covers both paths.Tests
test/cli— added fixtures for rejection (exit 127), no parent execution, a bare word after a flag,--passthrough, child resolution, and a parent documenting no arguments at all.test/shell.d/default-agent-test.sh— updated for the router path, plus direct launcher coverage../test/shell: 12 of the 13 failing files fail identically onorigin/quattro(battery math, widevine, kernel reboot, i18n, a missingomarchy-install-video-decode, etc.).remote-session-service-testis live-session portal noise from a fixture that only runsprobe.sh.