Repository navigation
Report first-party shell startup failures during restart - #16818
cobrakoral wants to merge 4 commits into
Conversation
[Medium impact] The PR appears safe to merge; no actionable defects were found. SummaryAdds
No actionable issues were found. Review checks were based on the diff and current code; tests were not run.
|
Track initial configuration, plugin discovery, service instances, and configured widget compilation independently of root IPC. Retain load diagnostics, gate readiness on enabled first-party plugins, and report third-party errors as warnings. Document the IPC contract and cover loading, failure, exclusions, and readiness with the production status calculation.
Add an isolated offscreen Quickshell fixture using the production loader and status functions. Check compilation diagnostics, optional-plugin exclusions, widget instantiation, and registry and external IPC calls. Run it from the plugin suite when Quickshell is available; keep it separate from the pure status-contract checks.
After core IPC responds and failsafe lock recovery re-secures the session, wait for startupStatus to become ready. Fail with retained plugin diagnostics or a bounded timeout, and surface third-party warnings. Keep notification readiness separate. Cover delayed startup, required-plugin failures, and existing lock recovery behavior, and document the restart contract.
Announce startup readiness only after omarchy-restart-shell succeeds. Explain a refused or failed restart while keeping the service phase best-effort so later update phases can continue. Add a regression for a refused restart and suppress the premature success message.
1e080d5 to
8c31c74
Compare
|
I reviewed this PR together with #16880 to evaluate their interaction and determine whether either change supersedes the other. My conclusion is that both PRs are complementary and should remain separate. I recommend merging #16880 first and this PR second. The distinction is important: #16880 mitigates a reproduced persistent QML disk-cache coherence failure, whereas this PR corrects the shell restart readiness contract. A successful root IPC This PR addresses that gap through I particularly support preserving the existing restart sequence: establish core IPC, restore the failsafe lock when necessary, and only then check plugin readiness. This avoids making security-relevant lock recovery depend on unrelated plugin initialization. The distinction between required first-party components, disabled or unconfigured components, and third-party warnings also keeps the readiness contract appropriately scoped. Similarly, retaining best-effort behavior in the update phase prevents a shell restart failure from unnecessarily aborting subsequent update operations, without falsely announcing successful startup. The relationship with #16880 is straightforward:
Neither implementation needs the other to function. Their current diffs do not overlap, and merging them independently preserves a clearer history and smaller review surfaces. For combined integration testing, I would focus on three scenarios:
The existing focused tests already cover much of the failure classification and restart orchestration. The remaining value is validating both mechanisms together in the same Quickshell process and performing a limited graphical smoke test. The aggregate shell-test failures reported by both PRs should be evaluated against their respective baselines rather than compared as raw counts. They do not, by themselves, establish a regression caused by either change. Conclusion: I support #16818 as an independent observability and correctness improvement, not as a substitute for #16880's cache mitigation. Merging #16880 first and this PR afterward provides a logical progression from mitigating the reproduced failure to reliably reporting any remaining startup failures. |
|
Thanks for this, @cobrakoral. Triage got as far as classifying it and stopped there, because the two models classifying it disagreed.
Because the classification is unsettled, no type label went on and nothing was run on a worker. Neither model has reviewed the diff line by line or tested it yet. It is waiting on the maintainer to decide whether this is a fix or a feature, and the review follows from that decision. |
A shell restart can currently report success while first-party plugins have failed to load. The root
shell pinghandler answers independently of asynchronous widget loading, andomarchy-update-restartprints “All plugins have been reloaded” before attempting the restart.Add
shell startupStatusto report configuration/discovery progress, instantiated enabled first-party services, and compiled first-party widgets used by the configured layout. Retain component diagnostics so restart can fail with the plugin ID and QML error. Disabled plugins and unconfigured widgets do not block startup; observed third-party errors are warnings. Preserve core IPC and failsafe lock recovery before checking unrelated plugin status.The update service phase now announces readiness only after a successful restart and explains a refused or failed restart. It remains best-effort so later update hooks and boot verification still run.
Refs #16126. This is a focused correction to false restart success, not a claim that the reported persistent cache state has been fixed.
Reproduction and limits:
0.3.2.r7.g2b4501a-1, Qt6.12.0, current Omarchy basebc220e7028d5ab0ee467a0f094dd1a8da98b6c0a.ShellIpc is not a typeand removes the representative plugin IPC target.file:plugin URLs create compiledqmlcache/*.qmlcfiles; the warm-cache restart still recovers.Related work:
Validation:
The focused regressions fail on the unchanged base and pass with this change. They cover delayed startup status after ping, required plugin failure diagnostics, disabled/unconfigured optional plugins, third-party warnings, existing live-lock refusal and failsafe recovery, and update-phase failure reporting. Script fixtures exercise the real orchestration with dependency stand-ins; they do not establish Qt cache behavior.
The included isolated offscreen Quickshell fixture executes the production loader/status functions with real QML components. It observes loading → failed → ready, verifies the import error, instantiates a representative ShellIpc component, and calls its IPC through both the registry and Quickshell's external client. It is a reduced host, not a complete desktop integration test.
The aggregate CLI suite passes. The aggregate shell run has 13 failures out of 404 files: ten also fail individually on the base; the other three (i18n-startup, passwordless-sudo-indicator, preinstalls) pass individually on both base and changed trees. Their parallel-run failure causes remain unestablished. Graphical tests are skipped without a compositor. QML lint finds the same existing unqualified-access warning on both trees; ShellCheck finds the same existing SC2053/SC2001 reports on both trees.
No real upgrade, active desktop restart, live lock manipulation, or user-cache deletion was performed.